2017-11-24 17:34:09

by Trond Myklebust

Subject: Re: sunrpc: infinite unkillable console spam in xs_tcp_setup_socket

T24gTW9uLCAyMDE3LTExLTIwIGF0IDE0OjAyICswMTAwLCBEbWl0cnkgVnl1a292IHdyb3RlOg0K
PiBIZWxsbywNCj4gDQo+IFRoZSBmb2xsb3dpbmcgcHJvZ3JhbSB0cmlnZ2VycyBpbmZpbml0ZSBz
dHJlYW0gb2YgdGhlIGZvbGxvd2luZw0KPiBvdXRwdXQNCj4gb24gY29uc29sZS4gVGhlIHByb2dy
YW0gaXMgdW5raWxsYWJsZSBhbmQgdGhpcyBlZmZlY3RpdmVseSBicmluZ3MgdGhlDQo+IG1hY2hp
bmUgZG93bjoNCj4gDQo+IA0KPiAqKiAxNiBwcmludGsgbWVzc2FnZXMgZHJvcHBlZCAqKiBbMTI4
NzUuMDIyOTE3XSB4c190Y3Bfc2V0dXBfc29ja2V0Og0KPiBjb25uZWN0IHJldHVybmVkIHVuaGFu
ZGxlZCBlcnJvciAtMTEzDQo+DQoNCkRvZXMgdGhlIGZvbGxvd2luZyBmaXggdGhlIGlzc3VlPw0K
DQo4PC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
DQpGcm9tIGY0OGQzZjAxZGY0NWY1MGYwMTQ1MDYwZjUyNzJjY2YxYWVhODU1YWMgTW9uIFNlcCAx
NyAwMDowMDowMCAyMDAxDQpGcm9tOiBUcm9uZCBNeWtsZWJ1c3QgPHRyb25kLm15a2xlYnVzdEBw
cmltYXJ5ZGF0YS5jb20+DQpEYXRlOiBGcmksIDI0IE5vdiAyMDE3IDEyOjAwOjI0IC0wNTAwDQpT
dWJqZWN0OiBbUEFUQ0hdIFNVTlJQQzogQWxsb3cgY29ubmVjdCB0byByZXR1cm4gRUhPU1RVTlJF
QUNIDQoNClJlcG9ydGVkLWJ5OiBEbWl0cnkgVnl1a292IDxkdnl1a292QGdvb2dsZS5jb20+DQpT
aWduZWQtb2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1c3QgPHRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0
YS5jb20+DQotLS0NCiBuZXQvc3VucnBjL3hwcnRzb2NrLmMgfCAxICsNCiAxIGZpbGUgY2hhbmdl
ZCwgMSBpbnNlcnRpb24oKykNCg0KZGlmZiAtLWdpdCBhL25ldC9zdW5ycGMveHBydHNvY2suYyBi
L25ldC9zdW5ycGMveHBydHNvY2suYw0KaW5kZXggNGRhZDVkYTM4OGQ2Li44Y2I0MGY4ZmZhNWIg
MTAwNjQ0DQotLS0gYS9uZXQvc3VucnBjL3hwcnRzb2NrLmMNCisrKyBiL25ldC9zdW5ycGMveHBy
dHNvY2suYw0KQEAgLTI0MzcsNiArMjQzNyw3IEBAIHN0YXRpYyB2b2lkIHhzX3RjcF9zZXR1cF9z
b2NrZXQoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQ0KIAljYXNlIC1FQ09OTlJFRlVTRUQ6DQog
CWNhc2UgLUVDT05OUkVTRVQ6DQogCWNhc2UgLUVORVRVTlJFQUNIOg0KKwljYXNlIC1FSE9TVFVO
UkVBQ0g6DQogCWNhc2UgLUVBRERSSU5VU0U6DQogCWNhc2UgLUVOT0JVRlM6DQogCQkvKg0KLS0g
DQoyLjE0LjMNCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRh
aW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg==

2017-11-28 10:01:17

by Dmitry Vyukov

Subject: Re: sunrpc: infinite unkillable console spam in xs_tcp_setup_socket

On Fri, Nov 24, 2017 at 6:34 PM, Trond Myklebust
<[email protected]> wrote:
> On Mon, 2017-11-20 at 14:02 +0100, Dmitry Vyukov wrote:
>> Hello,
>>
>> The following program triggers infinite stream of the following
>> output
>> on console. The program is unkillable and this effectively brings the
>> machine down:
>>
>>
>> ** 16 printk messages dropped ** [12875.022917] xs_tcp_setup_socket:
>> connect returned unhandled error -113
>>
>
> Does the following fix the issue?


Re-run the provided reproducer with the patch.
I don't see any kernel output and the process is perfectly killable now.

Tested-by: Dmitry Vyukov <[email protected]>





> 8<-----------------------------------------------------
> From f48d3f01df45f50f0145060f5272ccf1aea855ac Mon Sep 17 00:00:00 2001
> From: Trond Myklebust <[email protected]>
> Date: Fri, 24 Nov 2017 12:00:24 -0500
> Subject: [PATCH] SUNRPC: Allow connect to return EHOSTUNREACH
>
> Reported-by: Dmitry Vyukov <[email protected]>
> Signed-off-by: Trond Myklebust <[email protected]>
> ---
> net/sunrpc/xprtsock.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
> index 4dad5da388d6..8cb40f8ffa5b 100644
> --- a/net/sunrpc/xprtsock.c
> +++ b/net/sunrpc/xprtsock.c
> @@ -2437,6 +2437,7 @@ static void xs_tcp_setup_socket(struct work_struct *work)
> case -ECONNREFUSED:
> case -ECONNRESET:
> case -ENETUNREACH:
> + case -EHOSTUNREACH:
> case -EADDRINUSE:
> case -ENOBUFS:
> /*
> --
> 2.14.3
>
> --
> Trond Myklebust
> Linux NFS client maintainer, PrimaryData
> [email protected]