This file is not part of "git clone" and is not #included from any
C file.
Signed-off-by: Chuck Lever <[email protected]>
---
support/nfsidmap/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Hey Steve-
I don't see nfsidmap_internal.h anywhere. Wondering if I missed
something?
diff --git a/support/nfsidmap/Makefile.am b/support/nfsidmap/Makefile.am
index 9466f92..8b5dfe4 100644
--- a/support/nfsidmap/Makefile.am
+++ b/support/nfsidmap/Makefile.am
@@ -25,7 +25,7 @@ pkgplugin_LTLIBRARIES = nsswitch.la static.la $(UMICH_LDAP_LIB) $(GUMS_MAPPING_L
# <age> The number of previous additional interfaces supported
# by this library.
-libnfsidmap_la_SOURCES = libnfsidmap.c nfsidmap_internal.h nfsidmap_common.c
+libnfsidmap_la_SOURCES = libnfsidmap.c nfsidmap_common.c
libnfsidmap_la_LDFLAGS = -version-info 1:0:0
libnfsidmap_la_LIBADD = -ldl ../../support/nfs/libnfsconf.la
On Wed, 2018-01-17 at 17:10 -0500, Chuck Lever wrote:
> This file is not part of "git clone" and is not #included from any
> C file.
>
> Signed-off-by: Chuck Lever <[email protected]>
> ---
> support/nfsidmap/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hey Steve-
>
> I don't see nfsidmap_internal.h anywhere. Wondering if I missed
> something?
It was removed as part of my ABI cleanup (commit f080188e) to stop
libnfsidmap from leaking all sorts of private symbols.
Some of it went to libnfsidmap_plugin.h and some to
libnfsidmap_private.h
Some external packages which offered libnfsidmap plugins were using
these undocumented symbols by copying libnfsidmap_internal.h, so i
reworked the neccessary parts into an API as libnfsidmap_plugin.h and
hid the rest.
I clearly missed this reference to the file as it didn't generate any
warnings for me, sorry about that.
> On Jan 18, 2018, at 4:28 AM, Justin Mitchell <[email protected]> wrote:
>
> On Wed, 2018-01-17 at 17:10 -0500, Chuck Lever wrote:
>> This file is not part of "git clone" and is not #included from any
>> C file.
>>
>> Signed-off-by: Chuck Lever <[email protected]>
>> ---
>> support/nfsidmap/Makefile.am | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Hey Steve-
>>
>> I don't see nfsidmap_internal.h anywhere. Wondering if I missed
>> something?
>
> It was removed as part of my ABI cleanup (commit f080188e) to stop
> libnfsidmap from leaking all sorts of private symbols.
>
> Some of it went to libnfsidmap_plugin.h and some to
> libnfsidmap_private.h
>
> Some external packages which offered libnfsidmap plugins were using
> these undocumented symbols by copying libnfsidmap_internal.h, so i
> reworked the neccessary parts into an API as libnfsidmap_plugin.h and
> hid the rest.
>
> I clearly missed this reference to the file as it didn't generate any
> warnings for me, sorry about that.
No apologies needed. Are you confirming that this clean up is OK?
Can I get an amen? (I mean, can I get a Reviewed-by?)
--
Chuck Lever
On Thu, 2018-01-18 at 09:26 -0500, Chuck Lever wrote:
>
> > On Jan 18, 2018, at 4:28 AM, Justin Mitchell <[email protected]> wrote:
> >
> > On Wed, 2018-01-17 at 17:10 -0500, Chuck Lever wrote:
> >> This file is not part of "git clone" and is not #included from any
> >> C file.
> >>
> >> Signed-off-by: Chuck Lever <[email protected]>
> >> ---
> >> support/nfsidmap/Makefile.am | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> Hey Steve-
> >>
> >> I don't see nfsidmap_internal.h anywhere. Wondering if I missed
> >> something?
> >
> > It was removed as part of my ABI cleanup (commit f080188e) to stop
> > libnfsidmap from leaking all sorts of private symbols.
> >
> > Some of it went to libnfsidmap_plugin.h and some to
> > libnfsidmap_private.h
> >
> > Some external packages which offered libnfsidmap plugins were using
> > these undocumented symbols by copying libnfsidmap_internal.h, so i
> > reworked the neccessary parts into an API as libnfsidmap_plugin.h and
> > hid the rest.
> >
> > I clearly missed this reference to the file as it didn't generate any
> > warnings for me, sorry about that.
>
> No apologies needed. Are you confirming that this clean up is OK?
> Can I get an amen? (I mean, can I get a Reviewed-by?)
>
>
> --
> Chuck Lever
>
Yes, all looks good. thanks
Reviewed-by: Justin Mitchell <[email protected]>
On 01/17/2018 05:10 PM, Chuck Lever wrote:
> This file is not part of "git clone" and is not #included from any
> C file.
>
> Signed-off-by: Chuck Lever <[email protected]>
Committed...
steved.
> ---
> support/nfsidmap/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hey Steve-
>
> I don't see nfsidmap_internal.h anywhere. Wondering if I missed
> something?
>
> diff --git a/support/nfsidmap/Makefile.am b/support/nfsidmap/Makefile.am
> index 9466f92..8b5dfe4 100644
> --- a/support/nfsidmap/Makefile.am
> +++ b/support/nfsidmap/Makefile.am
> @@ -25,7 +25,7 @@ pkgplugin_LTLIBRARIES = nsswitch.la static.la $(UMICH_LDAP_LIB) $(GUMS_MAPPING_L
> # <age> The number of previous additional interfaces supported
> # by this library.
>
> -libnfsidmap_la_SOURCES = libnfsidmap.c nfsidmap_internal.h nfsidmap_common.c
> +libnfsidmap_la_SOURCES = libnfsidmap.c nfsidmap_common.c
> libnfsidmap_la_LDFLAGS = -version-info 1:0:0
> libnfsidmap_la_LIBADD = -ldl ../../support/nfs/libnfsconf.la
>
>