2013-09-26 04:27:39

by Jongman Heo

[permalink] [raw]
Subject: Re: Re: Regression caused by commit 4bdc33ed ("NFSDv4.2: Add NFS v4.2 support to the NFS server")

Pg0KPi0tLS0tLS0gT3JpZ2luYWwgTWVzc2FnZSAtLS0tLS0tDQo+DQo+U2VuZGVyIDogQW5uYSBT
Y2h1bWFrZXI8c2NodW1ha2VyLmFubmFAZ21haWwuY29tPg0KPg0KPkRhdGUgOiAyMDEzLTA5LTI1
IDIyOjUyIChHTVQrMDk6MDApDQo+DQo+VGl0bGUgOiBSZTogUmVncmVzc2lvbiBjYXVzZWQgYnkg
Y29tbWl0IDRiZGMzM2VkICgiTkZTRHY0LjI6IEFkZCBORlMgdjQuMiBzdXBwb3J0IHRvIHRoZSBO
RlMgc2VydmVyIikNCj4NCj4NCj4NCj5IaSBKb25nbWFuLA0KPg0KPklzIHRoZSBwYW5pYyBvbiB5
b3VyIGNsaWVudCBvciBzZXJ2ZXI/ICBJIGRvbid0IHNlZSBob3cgdGhlIHBhdGNoIHlvdXINCj5i
aXNlY3QgbGVkIHlvdSB0byBjb3VsZCBjYXVzZSB0aGUgcHJvYmxlbSwgc2luY2UgYWxsIGl0IGRv
ZXMgaXMgZXhwYW5kDQo+dGhlIG1pbm9yIHZlcnNpb24gYXJyYXkgb24gdGhlIHNlcnZlci4gIFlv
dXIgY2xpZW50IGRvZXNuJ3QgaGF2ZSBORlNEDQo+ZW5hYmxlZCwgc28gdGhpcyBjb2RlIHNob3Vs
ZG4ndCBldmVuIGJlIGFmZmVjdGluZyBpdC4NCj4NCj5BIGZldyBxdWVzdGlvbnM6ICB3aGF0IGlz
IHlvdXIgL2V0Yy9leHBvcnRzIG9uIHRoZSBzZXJ2ZXI/ICBXaGF0DQo+dmVyc2lvbiBvZiBORlMg
YXJlIHlvdSB1c2luZyBmb3IgbmZzcm9vdD8NCj4NCj5UaGFua3MhDQo+QW5uYQ0KPg0KPk9uIFdl
ZCwgU2VwIDI1LCAyMDEzIGF0IDE6MTkgQU0sIEpvbmdtYW4gSGVvIHdyb3RlOg0KPj4NCj4+IEhp
IGFsbCwNCj4+DQo+PiBNeSBlbWJlZGRlZCBkZXZlbG9wbWVudCBib3ggZmFpbHMgdG8gTkZTLWJv
b3Qgd2l0aCBORlMgc2VydmVyIHdoaWNoIHVzZXMgcmVjZW50IGtlcm5lbC4NCj4+DQo+PiBVc2lu
ZyBnaXQgYmlzZWN0LCBJIGZvdW5kIGl0IGlzIGNhdXNlZCBieSBjb21taXQgNGJkYzMzZWQgKCJO
RlNEdjQuMjogQWRkIE5GUyB2NC4yIHN1cHBvcnQgdG8gdGhlIE5GUyBzZXJ2ZXIiKS4NCj4+DQo+
Pg0KPj4gMS4gZG1lc2cgKE5GUyBib290IGZhaWx1cmUgY2FzZSkNCj4+DQo+PiAuLi4NCj4+IFsg
ICAgMi4wNDA4OTNdIEFERFJDT05GKE5FVERFVl9VUCk6IGV0aDA6IGxpbmsgaXMgbm90IHJlYWR5
DQo+PiBbICAgIDIuMDQ2MjA3XSBlMTAwMDogZXRoMCBOSUMgTGluayBpcyBVcCAxMDAwIE1icHMg
RnVsbCBEdXBsZXgsIEZsb3cgQ29udHJvbDogUlgNCj4+IFsgICAgMi4wNTM1NzBdIEFERFJDT05G
KE5FVERFVl9DSEFOR0UpOiBldGgwOiBsaW5rIGJlY29tZXMgcmVhZHkNCj4+IFsgICAgMy4wNTUw
MjNdIElQLUNvbmZpZzogR3Vlc3NpbmcgbmV0bWFzayAyNTUuMjU1LjAuMA0KPj4gWyAgICAzLjA1
OTk3OV0gSVAtQ29uZmlnOiBHYXRld2F5IG5vdCBvbiBkaXJlY3RseSBjb25uZWN0ZWQgbmV0d29y
ay4NCj4+IFsgICAgMy4wNjYzMzBdIExvb2tpbmcgdXAgcG9ydCBvZiBSUEMgMTAwMDAzLzIgb24g
MTY1LjIxMy44OC4yNDkNCj4+IFsgICAgMy4wNzQwMDFdIExvb2tpbmcgdXAgcG9ydCBvZiBSUEMg
MTAwMDA1LzEgb24gMTY1LjIxMy44OC4yNDkNCj4+IFsgICAgMy4xMjI4NzhdIFZGUzogVW5hYmxl
IHRvIG1vdW50IHJvb3QgZnMgdmlhIE5GUywgdHJ5aW5nIGZsb3BweS4NCj4+IFsgICAgMy4xMjkx
MzRdIFZGUzogQ2Fubm90IG9wZW4gcm9vdCBkZXZpY2UgIm5mcyIgb3IgdW5rbm93bi1ibG9jaygy
LDApDQo+PiBbICAgIDMuMTM1NDc4XSBQbGVhc2UgYXBwZW5kIGEgY29ycmVjdCAicm9vdD0iIGJv
b3Qgb3B0aW9uOyBoZXJlIGFyZSB0aGUgYXZhaWxhYmxlIHBhcnRpdGlvbnM6DQo+PiBbICAgIDMu
MTQzODMxXSAxZjAwICAgICAgICAgICAgMzA3MiBtdGRibG9jazAgKGRyaXZlcj8pDQo+PiBbICAg
IDMuMTQ4Nzk4XSAxZjAxICAgICAgICAgICAgICA2NCBtdGRibG9jazEgKGRyaXZlcj8pDQo+PiBb
ICAgIDMuMTUzNzU4XSAxZjAyICAgICAgICAgICAgICA2NCBtdGRibG9jazIgKGRyaXZlcj8pDQo+
PiBbICAgIDMuMTU4NzE5XSAxZjAzICAgICAgICAgICAgICA2NCBtdGRibG9jazMgKGRyaXZlcj8p
DQo+PiBbICAgIDMuMTYzNjgyXSAxZjA0ICAgICAgICAgICAgICA2NCBtdGRibG9jazQgKGRyaXZl
cj8pDQo+PiBbICAgIDMuMTY4NjQ0XSAxZjA1ICAgICAgICAgICAgICA2NCBtdGRibG9jazUgKGRy
aXZlcj8pDQo+PiBbICAgIDMuMTczNjA3XSAxZjA2ICAgICAgICAgICAgICA2NCBtdGRibG9jazYg
KGRyaXZlcj8pDQo+PiBbICAgIDMuMTc4NTY4XSAwODAwICAgICAgIDQ4ODM4NjU4NCBzZGEgZHJp
dmVyOiBzZA0KPj4gWyAgICAzLjE4MzA5OV0gICAwODAxICAgICAgICAgIDUwNjAxNiBzZGExDQo+
PiBbICAgIDMuMTg2OTI3XSAgIDA4MDIgICAgICAgICA0MDA4MjE3IHNkYTINCj4+IFsgICAgMy4x
OTA3NTVdICAgMDgwMyAgICAgICA0ODM4Njk3Njcgc2RhMw0KPj4gWyAgICAzLjE5NDU4NF0gYjMw
MCAgICAgICAgIDE4ODAwNjQgbW1jYmxrMCBkcml2ZXI6IG1tY2Jsaw0KPj4gWyAgICAzLjE5OTgw
Ml0gICBiMzAxICAgICAgICAgICAgNDA5NiBtbWNibGswcDENCj4+IFsgICAgMy4yMDQwNjNdICAg
YjMwMiAgICAgICAgICAxMDI0MDAgbW1jYmxrMHAyDQo+PiBbICAgIDMuMjA4MzMwXSAgIGIzMDMg
ICAgICAgICAgICA0MDk2IG1tY2JsazBwMw0KPj4gWyAgICAzLjIxMjU5NF0gICBiMzA0ICAgICAg
ICAgICAgICAgMSBtbWNibGswcDQNCj4+IFsgICAgMy4yMTY4NTVdICAgYjMwNSAgICAgICAgICAg
IDIwNDggbW1jYmxrMHA1DQo+PiBbICAgIDMuMjIxMTE2XSAgIGIzMDYgICAgICAgICAgICAyMDQ4
IG1tY2JsazBwNg0KPj4gWyAgICAzLjIyNTM4Ml0gICBiMzA3ICAgICAgICAgICAgMjA0OCBtbWNi
bGswcDcNCj4+IFsgICAgMy4yMjk2NDRdICAgYjMwOCAgICAgICAgICAgIDQwOTYgbW1jYmxrMHA4
DQo+PiBbICAgIDMuMjMzOTA2XSAgIGIzMDkgICAgICAgICAgIDEyMjg4IG1tY2JsazBwOQ0KPj4g
WyAgICAzLjIzODE3Nl0gICBiMzBhICAgICAgICAgICAxNjM4NCBtbWNibGswcDEwDQo+PiBbICAg
IDMuMjQyNTI0XSAgIGIzMGIgICAgICAgICAgMTQyMzM2IG1tY2JsazBwMTENCj4+IFsgICAgMy4y
NDY4NjldICAgYjMwYyAgICAgICAgIDE1NzI4NjQgbW1jYmxrMHAxMg0KPj4gWyAgICAzLjI1MTIx
OV0gYjMyMCAgICAgICAgICAgMTIyODggbW1jYmxrMGdwMSAoZHJpdmVyPykNCj4+IFsgICAgMy4y
NTYyNzJdIGIzMTAgICAgICAgICAgIDEyMjg4IG1tY2JsazBncDAgKGRyaXZlcj8pDQo+PiBbICAg
IDMuMjYxMzIwXSBLZXJuZWwgcGFuaWMgLSBub3Qgc3luY2luZzogVkZTOiBVbmFibGUgdG8gbW91
bnQgcm9vdCBmcyBvbiB1bmtub3duLWJsb2NrKDIsMCkNCj4+IFsgICAgMy4yNjk1NjZdIFBpZDog
MSwgY29tbTogc3dhcHBlciBOb3QgdGFpbnRlZCAyLjYuMzUgIzENCj4+IFsgICAgMy4yNzQ3NzZd
IENhbGwgVHJhY2U6DQo+PiBbICAgIDMuMjc3MjMyXSAgWzw4MGQwZGI1Yj5dID8gcHJpbnRrKzB4
MWUvMHgyMA0KPj4gWyAgICAzLjI4MTQ5Ml0gIFs8ODBkMGRhZDE+XSBwYW5pYysweDY1LzB4ZDEN
Cj4+IFsgICAgMy4yODU0OTVdICBbPDgwZWI5Y2UzPl0gbW91bnRfYmxvY2tfcm9vdCsweDEyNS8w
eDFiZQ0KPj4gWyAgICAzLjI5MDYzMV0gIFs8ODA5ZDFmNmQ+XSA/IHN5c19ta25vZCsweDJkLzB4
MzANCj4+IFsgICAgMy4yOTUxNTZdICBbPDgwZWI5ZjZkPl0gbW91bnRfcm9vdCsweGQwLzB4ZjIN
Cj4+IFsgICAgMy4yOTk1OTFdICBbPDgwZWJhMGQ5Pl0gcHJlcGFyZV9uYW1lc3BhY2UrMHgxNGEv
MHgxODQNCj4+IFsgICAgMy4zMDQ4MDNdICBbPDgwOWM0NGY2Pl0gPyBzeXNfYWNjZXNzKzB4MjYv
MHgzMA0KPj4gWyAgICAzLjMwOTQxMV0gIFs8ODBlYjlhNGU+XSBrZXJuZWxfaW5pdCsweDI1ZS8w
eDI2ZQ0KPj4gWyAgICAzLjMxNDEwNV0gIFs8ODBlYjk3ZjA+XSA/IGtlcm5lbF9pbml0KzB4MC8w
eDI2ZQ0KPj4gWyAgICAzLjMxODgwMF0gIFs8ODA5MDMyNDI+XSBrZXJuZWxfdGhyZWFkX2hlbHBl
cisweDYvMHgxMA0KPj4NCj4+DQo+PiAyLiBDbGllbnQgKG15IGVtYmVkZGVkIGJveCkgY29uZmln
dXJhdGlvbg0KPj4gICBJdCdzIGtlcm5lbCAyLjYuMzUgYmFzZWQsIGFuZCBoYXMgZm9sbG93aW5n
IE5GUyBrZXJuZWwgY29uZmlncy4NCj4+DQo+PiAjIGdyZXAgTkZTIC5jb25maWcNCj4+IENPTkZJ
R19ORlNfRlM9eQ0KPj4gQ09ORklHX05GU19WMz15DQo+PiBDT05GSUdfTkZTX1YzX0FDTD15DQo+
PiBDT05GSUdfTkZTX1Y0PXkNCj4+ICMgQ09ORklHX05GU19WNF8xIGlzIG5vdCBzZXQNCj4+IENP
TkZJR19ST09UX05GUz15DQo+PiAjIENPTkZJR19ORlNEIGlzIG5vdCBzZXQNCj4+IENPTkZJR19O
RlNfQUNMX1NVUFBPUlQ9eQ0KPj4gQ09ORklHX05GU19DT01NT049eQ0KPj4NCj4+DQo+PiAzLiBT
ZXJ2ZXIgKE5GU0QpIGNvbmZpZ3VyYXRpb24NCj4+ICAgIEZlZG9yYSAxOSArIGxhdGVzdCBsaW51
cyBnaXQga2VybmVsIDMuMTIuMC1yYzIrIChjb21taXQgMjIzNTZmNDQsIG1tOiBQbGFjZSBwcmVl
bXB0aW9uIHBvaW50IGluIGRvX21sb2NrYWxsKCkgbG9vcCkNCj4+DQo+Pg0KPj4gNC4gd29ya2Fy
b3VuZA0KPj4NCj4+IFJldmVydGluZyB0aGUgY29tbWl0IDRiZGMzM2VkIHJlc29sdmVzIG15IGlz
c3VlLCBORlMgYm9vdCBpcyB3b3JraW5nIHRoZW4uDQo+PiBJJ3ZlIGRvbmUgZ2l0IGJpc2VjdCwg
YnV0IGxvc3QgdGhlIHJlc3VsdGluZyBiaXNlY3QgbG9nIGR1ZSB0byBzdWRkZW4gcG93ZXIgbG9z
cyA6KC4NCj4+DQo+PiBCZXN0IHJlZ2FyZHMsDQo+PiBKb25nbWFuIEhlbw0KPg0KPg0KPg0KDQpI
aSwNCg0KUGxlYXNlIHNlZSBteSBlLW1haWwgcmVwbHkgdG8gSi4gQnJ1Y2UgRmllbGRzIGZvciB0
aGUgZGV0YWlsLg0KDQpUaGFua3MsDQpKb25nbWFuIEhlby4=




2013-09-27 01:12:46

by J. Bruce Fields

[permalink] [raw]
Subject: Re: Re: Re: Regression caused by commit 4bdc33ed ("NFSDv4.2: Add NFS v4.2 support to the NFS server")

On Thu, Sep 26, 2013 at 11:57:57PM +0000, Jongman Heo wrote:
> >------- Original Message -------
> >Sender : J. Bruce Fields<[email protected]>
> >This is pretty weird--it's not at all obvious how that patch would
> >affect this.
> >
> >You're absolutely positive that the *only* thing you're changing on the
> >server between the "good" and "bad" cases is that one kernel patch?
> >You're not changing anything in userspace?
> >
>
> Yes, pretty sure.
>
> >What does "cat /proc/fs/nfsd/versions" report in the good and bad cases?
> >
> >(BTW, out of curiosity: what kind of client is this that only supports
> >NFSv2 and NFSv3? Even for an embedded system that's a bit surprising.)
> >
> >--b.
> >
>
> Here are /proc/fs/nfsd/versions information for good and bad cases ;
>
> good (commit 4bdc33ed reverted)
>
> # cat /proc/fs/nfsd/versions
> +2 +3 +4 +4.1
>
>
> bad (current linus git)
>
> # cat /proc/fs/nfsd/versions
> -2 +3 +4 +4.1 -4.2
>
>
> I don't know why the commit 4bdc33ed makes this difference ( from +2 to -2 ).
>
> My NFS server just uses Fedora 19 + latest kernel (which is not a rare setup...),

The thing is, nfs-utils *did* make exactly this change with commit
6b4e4965a6b82e8d49cea1c0316b951ba4e9e83e "rpc.nfsd: No longer advertise
NFS v2 support." in 1.2.9-rc4 which entered f19 recently. And that
kernel commit doesn't look related. So I strongly suspect that you got
the nfs-utils update (or rebooted after the update) at the same time as
bisecting, and that confused the bisect results.

> so I think some people can verify if this version information change happens w/ and w/o the commit revert.
>
> Don't know the detail of NFS protocol, but our NFS client seems not to try with v3 and v4 in case v2 fails...
> Is this an unexpected (buggy) behavior of my old embedded box (NFS client of kernel 2.6.35), or expected one from the NFS protocol?

Digging into a historical git repo just for fun.... It looks like NFSv3
support was added in 2.3.99pre4-3, probably in 2000? (The date on that
commit is 2007, so obviously this repo I have is very confused. Maybe I
should go find if there's a better one someplace.)

So anyway it's either configured out of the kernel or the mount
commandline's asking for v2, or I don't know what....

--b.

2013-09-27 02:21:34

by Jongman Heo

[permalink] [raw]
Subject: Re: Re: Re: Re: Regression caused by commit 4bdc33ed ("NFSDv4.2: Add NFS v4.2 support to the NFS server")

SGksDQoNCj4NCj4tLS0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0tLS0tLQ0KPlNlbmRlciA6IEou
IEJydWNlIEZpZWxkczxiZmllbGRzQGZpZWxkc2VzLm9yZz4NCj5EYXRlIDogMjAxMy0wOS0yNyAx
MDoxMiAoR01UKzA5OjAwKQ0KPlRpdGxlIDogUmU6IFJlOiBSZTogUmVncmVzc2lvbiBjYXVzZWQg
YnkgY29tbWl0IDRiZGMzM2VkICgiTkZTRHY0LjI6IEFkZCBORlMgdjQuMiBzdXBwb3J0IHRvIHRo
ZSBORlMgc2VydmVyIikNCj4NCj5PbiBUaHUsIFNlcCAyNiwgMjAxMyBhdCAxMTo1Nzo1N1BNICsw
MDAwLCBKb25nbWFuIEhlbyB3cm90ZToNCj4+ID4tLS0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0t
LS0tLQ0KPj4gPlNlbmRlciA6IEouIEJydWNlIEZpZWxkcw0KPj4gPlRoaXMgaXMgcHJldHR5IHdl
aXJkLS1pdCdzIG5vdCBhdCBhbGwgb2J2aW91cyBob3cgdGhhdCBwYXRjaCB3b3VsZA0KPj4gPmFm
ZmVjdCB0aGlzLg0KPj4gPg0KPj4gPllvdSdyZSBhYnNvbHV0ZWx5IHBvc2l0aXZlIHRoYXQgdGhl
ICpvbmx5KiB0aGluZyB5b3UncmUgY2hhbmdpbmcgb24gdGhlDQo+PiA+c2VydmVyIGJldHdlZW4g
dGhlICJnb29kIiBhbmQgImJhZCIgY2FzZXMgaXMgdGhhdCBvbmUga2VybmVsIHBhdGNoPw0KPj4g
PllvdSdyZSBub3QgY2hhbmdpbmcgYW55dGhpbmcgaW4gdXNlcnNwYWNlPw0KPj4gPg0KPj4gDQo+
PiBZZXMsIHByZXR0eSBzdXJlLg0KPj4gDQo+PiA+V2hhdCBkb2VzICJjYXQgL3Byb2MvZnMvbmZz
ZC92ZXJzaW9ucyIgcmVwb3J0IGluIHRoZSBnb29kIGFuZCBiYWQgY2FzZXM/DQo+PiA+DQo+PiA+
KEJUVywgb3V0IG9mIGN1cmlvc2l0eTogd2hhdCBraW5kIG9mIGNsaWVudCBpcyB0aGlzIHRoYXQg
b25seSBzdXBwb3J0cw0KPj4gPk5GU3YyIGFuZCBORlN2Mz8gIEV2ZW4gZm9yIGFuIGVtYmVkZGVk
IHN5c3RlbSB0aGF0J3MgYSBiaXQgc3VycHJpc2luZy4pDQo+PiA+DQo+PiA+LS1iLg0KPj4gPg0K
Pj4gDQo+PiBIZXJlIGFyZSAvcHJvYy9mcy9uZnNkL3ZlcnNpb25zIGluZm9ybWF0aW9uIGZvciBn
b29kIGFuZCBiYWQgY2FzZXMgOw0KPj4gDQo+PiBnb29kIChjb21taXQgNGJkYzMzZWQgcmV2ZXJ0
ZWQpDQo+PiANCj4+ICMgY2F0IC9wcm9jL2ZzL25mc2QvdmVyc2lvbnMgDQo+PiArMiArMyArNCAr
NC4xDQo+PiANCj4+IA0KPj4gYmFkIChjdXJyZW50IGxpbnVzIGdpdCkNCj4+IA0KPj4gIyBjYXQg
L3Byb2MvZnMvbmZzZC92ZXJzaW9ucyAgDQo+PiAtMiArMyArNCArNC4xIC00LjINCj4+IA0KPj4g
DQo+PiBJIGRvbid0IGtub3cgd2h5IHRoZSBjb21taXQgNGJkYzMzZWQgbWFrZXMgdGhpcyBkaWZm
ZXJlbmNlICggZnJvbSArMiB0byAtMiApLg0KPj4gDQo+PiBNeSBORlMgc2VydmVyIGp1c3QgdXNl
cyBGZWRvcmEgMTkgKyBsYXRlc3Qga2VybmVsICh3aGljaCBpcyBub3QgYSByYXJlIHNldHVwLi4u
KSwgDQo+DQo+VGhlIHRoaW5nIGlzLCBuZnMtdXRpbHMgKmRpZCogbWFrZSBleGFjdGx5IHRoaXMg
Y2hhbmdlIHdpdGggY29tbWl0DQo+NmI0ZTQ5NjVhNmI4MmU4ZDQ5Y2VhMWMwMzE2Yjk1MWJhNGU5
ZTgzZSAicnBjLm5mc2Q6IE5vIGxvbmdlciBhZHZlcnRpc2UNCj5ORlMgdjIgc3VwcG9ydC4iIGlu
IDEuMi45LXJjNCB3aGljaCBlbnRlcmVkIGYxOSByZWNlbnRseS4gIEFuZCB0aGF0DQo+a2VybmVs
IGNvbW1pdCBkb2Vzbid0IGxvb2sgcmVsYXRlZC4gIFNvIEkgc3Ryb25nbHkgc3VzcGVjdCB0aGF0
IHlvdSBnb3QNCj50aGUgbmZzLXV0aWxzIHVwZGF0ZSAob3IgcmVib290ZWQgYWZ0ZXIgdGhlIHVw
ZGF0ZSkgYXQgdGhlIHNhbWUgdGltZSBhcw0KPmJpc2VjdGluZywgYW5kIHRoYXQgY29uZnVzZWQg
dGhlIGJpc2VjdCByZXN1bHRzLg0KPg0KDQpObywgSSBoYXZlbid0IGNoYW5nZWQvdXBncmFkZWQg
bmZzLXV0aWxzIHBhY2thZ2UgZHVyaW5nIGdpdCBiaXNlY3QuDQpBbmQgSSBjYW4gc3RpbGwgcmVw
cm9kdWNlIHRoZSBpc3N1ZS4NCg0KIyBycG0gLXFhfGdyZXAgbmZzLXV0aWxzDQpuZnMtdXRpbHMt
MS4yLjgtNC4wLmZjMTkuaTY4Ng0KDQojIHJwbSAtcSAtLWNoYW5nZWxvZyBuZnMtdXRpbHN8aGVh
ZCAtNg0KKiBNb24gQXVnIDE5IDIwMTMgU3RldmUgRGlja3NvbiA8c3RldmVkQHJlZGhhdC5jb20+
IDEuMi44LTQuMA0KLSBVcGRhdGVkIHRvIGxhdGVzdCB1cHN0cmVhbSBSQyByZWxlYXNlOiBuZnMt
dXRpbHMtMS0yLTktcmM0DQoNCiogVHVlIEp1bCAyMyAyMDEzIFN0ZXZlIERpY2tzb24gPHN0ZXZl
ZEByZWRoYXQuY29tPiAxLjIuOC0zLjANCi0gVXBkYXRlZCB0byBsYXRlc3QgdXBzdHJlYW0gUkMg
cmVsZWFzZTogbmZzLXV0aWxzLTEtMi05LXJjMw0KDQpBcyB5b3Ugbm90aWNlZCwgMS4yLjktcmM0
IGlzIGFwcGxpZWQgdG8gRmVkb3JhIDE5J3MgbmZzLXV0aWxzIHdoYXQgSSdtIHVzaW5nLi4uDQoN
CldpdGggdGhlIG5mcy11dGlscywgcmV2ZXJ0aW5nIHRoZSBjb21taXQgbWFrZXMgZGlmZmVyZW5j
ZSB0byBtZS4NCg0KDQpBbm90aGVyIHdvcmthcm91bmQgZnJvbSB1c2VyLXNwYWNlIChpbnN0ZWFk
IG9mIHJldmVydCkgd29ya3MgZm9yIG1lLg0KDQpMYXRlc3QgbGludXMgZ2l0IGdpdmVzIGZvbGxv
d2luZyBORlMgdmVyc2lvbiBzdXBwb3J0ICh3aXRoIG15IHNlcnZlcidzIC5jb25maWcpLg0KDQog
ICMgY2F0IC9wcm9jL2ZzL25mc2QvdmVyc2lvbnMgDQogIC0yICszICs0ICs0LjEgLTQuMg0KDQpJ
J3ZlIGNoYW5nZWQgL2V0Yy9zeXNjb25maWcvbmZzIGZpbGUgYXMgZm9sbG93aW5nIGRpZmYgOw0K
DQpAQCAtMTAsNyArMTAsNyBAQA0KICNMT0NLRF9VRFBQT1JUPTMyNzY5DQogIw0KICMgT3B0aW9u
YWwgYXJndW1lbnRzIHBhc3NlZCB0byBycGMubmZzZC4gU2VlIHJwYy5uZnNkKDgpDQotUlBDTkZT
REFSR1M9IiINCitSUENORlNEQVJHUz0iLVYgMiINCg0KDQpUaGVuLiBydW4gbmZzIHNlcnZlciBh
Z2Fpbi4uLg0KDQojIHN5c3RlbWN0bCByZXN0YXJ0IG5mcy1zZXJ2ZXIuc2VydmljZQ0KIyBjYXQg
L3Byb2MvZnMvbmZzZC92ZXJzaW9ucyANCisyICszICs0ICs0LjEgLTQuMg0KDQpOb3cgTkZTIGJv
b3QgaXMgd29ya2luZy4gDQpBY3R1YWxseSBJJ20gT0sgd2l0aCB0aGlzLCBzaW5jZSBORlMgYm9v
dCBpcyBqdXN0IHVzZWQgZm9yIGRlYnVnZ2luZyBwdXJwb3NlLCBub3QgZm9yIHByb2R1Y3Rpb24g
dXNlLCBpbiBteSBjYXNlLg0KDQoNCkZZSSwgaW4gb3RoZXIgTGludXggbWFjaGluZSAoVWJ1bnR1
IDEyLjA0KSwgbmZzLXV0aWxzIHZlcnNpb24gaXMgIjEuMi41LTN1YnVudHUzLjEiLCBhbmQgdGhl
IGtlcm5lbCBjb21taXQgZG9lc24ndCBjYXVzZSBORlMgdjIgc3VwcG9ydCBpc3N1ZS4NCg0KIyBj
YXQgL3Byb2MvZnMvbmZzZC92ZXJzaW9ucw0KKzIgKzMgKzQgKzQuMSAtNC4yDQoNClNvLCB0aGUg
Y2hhbmdlIGluIG5mcy11dGlscyAxLjIuOS1yYzQgc2VlbXMgdG8gYmUgdGhlIHJvb3QgY2F1c2Us
IGJ1dCBJIGRvbid0IGtub3cgd2h5IHRoZSBrZXJuZWwgY29tbWl0IHJldmVydCByZXNvbHZlcyB0
aGUgaXNzdWUuDQoNCj4+IHNvIEkgdGhpbmsgc29tZSBwZW9wbGUgY2FuIHZlcmlmeSBpZiB0aGlz
IHZlcnNpb24gaW5mb3JtYXRpb24gY2hhbmdlIGhhcHBlbnMgdy8gYW5kIHcvbyB0aGUgY29tbWl0
IHJldmVydC4NCj4+IA0KPj4gRG9uJ3Qga25vdyB0aGUgZGV0YWlsIG9mIE5GUyBwcm90b2NvbCwg
YnV0IG91ciBORlMgY2xpZW50IHNlZW1zIG5vdCB0byB0cnkgd2l0aCB2MyBhbmQgdjQgaW4gY2Fz
ZSB2MiBmYWlscy4uLg0KPj4gSXMgdGhpcyBhbiB1bmV4cGVjdGVkIChidWdneSkgYmVoYXZpb3Ig
b2YgbXkgb2xkIGVtYmVkZGVkIGJveCAoTkZTIGNsaWVudCBvZiBrZXJuZWwgMi42LjM1KSwgb3Ig
ZXhwZWN0ZWQgb25lIGZyb20gdGhlIE5GUyBwcm90b2NvbD8NCj4NCj5EaWdnaW5nIGludG8gYSBo
aXN0b3JpY2FsIGdpdCByZXBvIGp1c3QgZm9yIGZ1bi4uLi4gSXQgbG9va3MgbGlrZSBORlN2Mw0K
PnN1cHBvcnQgd2FzIGFkZGVkIGluIDIuMy45OXByZTQtMywgcHJvYmFibHkgaW4gMjAwMD8gIChU
aGUgZGF0ZSBvbiB0aGF0DQo+Y29tbWl0IGlzIDIwMDcsIHNvIG9idmlvdXNseSB0aGlzIHJlcG8g
SSBoYXZlIGlzIHZlcnkgY29uZnVzZWQuICBNYXliZSBJDQo+c2hvdWxkIGdvIGZpbmQgaWYgdGhl
cmUncyBhIGJldHRlciBvbmUgc29tZXBsYWNlLikNCj4NCj5TbyBhbnl3YXkgaXQncyBlaXRoZXIg
Y29uZmlndXJlZCBvdXQgb2YgdGhlIGtlcm5lbCBvciB0aGUgbW91bnQNCj5jb21tYW5kbGluZSdz
IGFza2luZyBmb3IgdjIsIG9yIEkgZG9uJ3Qga25vdyB3aGF0Li4uLg0KPg0KPi0tYi4NCj4NCg0K
VGhhbmtzLA0KSm9uZ21hbiBIZW8u



2013-09-27 20:09:42

by J. Bruce Fields

[permalink] [raw]
Subject: Re: Re: Re: Re: Regression caused by commit 4bdc33ed ("NFSDv4.2: Add NFS v4.2 support to the NFS server")

On Fri, Sep 27, 2013 at 02:21:33AM +0000, Jongman Heo wrote:
> Hi,
>
> >
> >------- Original Message -------
> >Sender : J. Bruce Fields<[email protected]>
> >Date : 2013-09-27 10:12 (GMT+09:00)
> >Title : Re: Re: Re: Regression caused by commit 4bdc33ed ("NFSDv4.2: Add NFS v4.2 support to the NFS server")
> >
> >On Thu, Sep 26, 2013 at 11:57:57PM +0000, Jongman Heo wrote:
> >> >------- Original Message -------
> >> >Sender : J. Bruce Fields
> >> >This is pretty weird--it's not at all obvious how that patch would
> >> >affect this.
> >> >
> >> >You're absolutely positive that the *only* thing you're changing on the
> >> >server between the "good" and "bad" cases is that one kernel patch?
> >> >You're not changing anything in userspace?
> >> >
> >>
> >> Yes, pretty sure.
> >>
> >> >What does "cat /proc/fs/nfsd/versions" report in the good and bad cases?
> >> >
> >> >(BTW, out of curiosity: what kind of client is this that only supports
> >> >NFSv2 and NFSv3? Even for an embedded system that's a bit surprising.)
> >> >
> >> >--b.
> >> >
> >>
> >> Here are /proc/fs/nfsd/versions information for good and bad cases ;
> >>
> >> good (commit 4bdc33ed reverted)
> >>
> >> # cat /proc/fs/nfsd/versions
> >> +2 +3 +4 +4.1
> >>
> >>
> >> bad (current linus git)
> >>
> >> # cat /proc/fs/nfsd/versions
> >> -2 +3 +4 +4.1 -4.2
> >>
> >>
> >> I don't know why the commit 4bdc33ed makes this difference ( from +2 to -2 ).
> >>
> >> My NFS server just uses Fedora 19 + latest kernel (which is not a rare setup...),
> >
> >The thing is, nfs-utils *did* make exactly this change with commit
> >6b4e4965a6b82e8d49cea1c0316b951ba4e9e83e "rpc.nfsd: No longer advertise
> >NFS v2 support." in 1.2.9-rc4 which entered f19 recently. And that
> >kernel commit doesn't look related. So I strongly suspect that you got
> >the nfs-utils update (or rebooted after the update) at the same time as
> >bisecting, and that confused the bisect results.
> >
>
> No, I haven't changed/upgraded nfs-utils package during git bisect.

Well, all it would take would be a long-ago yum update that you'd
forgotten about by the time you rebooted to a new kernel at which point
the new rpc.nfsd behavior would take affect on restarting the nfs
server.

> And I can still reproduce the issue.

So I'm still really skeptical but if you're positive then I guess I
should go try to reproduce and make sure there's not something very
screwed up with the nfsd/versions interface.

--b.