2018-06-22 05:06:49

by Yongcheng Yang

Subject: [PATCH] nfsstat: fix typo causing --mounts unrecognized option

From: Yongcheng Yang <[email protected]>

This reverts commit acf95d32a44fd8357c24e8a04ec53fc6900bfc58

Signed-off-by: Yongcheng Yang <[email protected]>
---

Hi Steve,

To keep pace with the (nfsstat) man page, "mounted" should be replaced by "mounts".

Test logs:

[root@ nfsstat]# rpm -q nfs-utils
nfs-utils-2.3.1-xxx
[root@ nfsstat]# nfsstat --mounts
nfsstat: unrecognized option '--mounts'
Try `nfsstat --help' for more information.

[root@ nfsstat]# nfsstat.new --mounts
/mnt from localhost:/export_test
Flags: rw,relatime,vers=4.2,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp6,timeo=600,retrans=2,sec=sys,clientaddr=::1,local_lock=none,addr=::1

[root@ nfsstat]#

Thanks,
Yongcheng

---

utils/nfsstat/nfsstat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utils/nfsstat/nfsstat.c b/utils/nfsstat/nfsstat.c
index 8fccea7..ca84532 100644
--- a/utils/nfsstat/nfsstat.c
+++ b/utils/nfsstat/nfsstat.c
@@ -340,7 +340,7 @@ static struct option longopts[] =
{ "all", 0, 0, 'v' },
{ "auto", 0, 0, '\3' },
{ "client", 0, 0, 'c' },
- { "mounted", 0, 0, 'm' },
+ { "mounts", 0, 0, 'm' },
{ "nfs", 0, 0, 'n' },
{ "rpc", 0, 0, 'r' },
{ "server", 0, 0, 's' },
--
2.5.5

2018-06-25 15:37:09

by Steve Dickson

Subject: Re: [PATCH] nfsstat: fix typo causing --mounts unrecognized option

On 06/22/2018 01:06 AM, [email protected] wrote:
> From: Yongcheng Yang <[email protected]>
>
> This reverts commit acf95d32a44fd8357c24e8a04ec53fc6900bfc58
>
> Signed-off-by: Yongcheng Yang <[email protected]>
Committed...

steved.

> ---
>
> Hi Steve,
>
> To keep pace with the (nfsstat) man page, "mounted" should be replaced by "mounts".
>
> Test logs:
>
> [root@ nfsstat]# rpm -q nfs-utils
> nfs-utils-2.3.1-xxx
> [root@ nfsstat]# nfsstat --mounts
> nfsstat: unrecognized option '--mounts'
> Try `nfsstat --help' for more information.
>
> [root@ nfsstat]# nfsstat.new --mounts
> /mnt from localhost:/export_test
> Flags: rw,relatime,vers=4.2,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp6,timeo=600,retrans=2,sec=sys,clientaddr=::1,local_lock=none,addr=::1
>
> [root@ nfsstat]#
>
> Thanks,
> Yongcheng
>
> ---
>
> utils/nfsstat/nfsstat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/nfsstat/nfsstat.c b/utils/nfsstat/nfsstat.c
> index 8fccea7..ca84532 100644
> --- a/utils/nfsstat/nfsstat.c
> +++ b/utils/nfsstat/nfsstat.c
> @@ -340,7 +340,7 @@ static struct option longopts[] =
> { "all", 0, 0, 'v' },
> { "auto", 0, 0, '\3' },
> { "client", 0, 0, 'c' },
> - { "mounted", 0, 0, 'm' },
> + { "mounts", 0, 0, 'm' },
> { "nfs", 0, 0, 'n' },
> { "rpc", 0, 0, 'r' },
> { "server", 0, 0, 's' },
>