2019-10-15 12:42:30

by chenxiang (M)

[permalink] [raw]
Subject: [PATCH] nfs: No need to add NULL check before function kfree()

From: Xiang Chen <[email protected]>

It fixes the warning as follows reported by coccicheck:
fs/nfs/sysfs.c:125:2-7: WARNING: NULL check before some freeing functions is not
needed.

Signed-off-by: Xiang Chen <[email protected]>
---
fs/nfs/sysfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/nfs/sysfs.c b/fs/nfs/sysfs.c
index 4f3390b..c489496 100644
--- a/fs/nfs/sysfs.c
+++ b/fs/nfs/sysfs.c
@@ -121,8 +121,7 @@ static void nfs_netns_client_release(struct kobject *kobj)
struct nfs_netns_client,
kobject);

- if (c->identifier)
- kfree(c->identifier);
+ kfree(c->identifier);
kfree(c);
}

--
2.8.1