2011-08-08 15:01:48

by Benny Halevy

[permalink] [raw]
Subject: Re: [PATCH-RFC 0/2] pNFS: recoalesce pages when ld read/write fails

I'm good with a private pnfs workqueue.

Benny
------Original Message------
From: Peng Tao
To: [email protected]
Cc: [email protected]
Cc: Benny Halevy
Cc: [email protected]
Subject: Re: [PATCH-RFC 0/2] pNFS: recoalesce pages when ld read/write fails
Sent: Aug 8, 2011 17:33

On Sat, Aug 6, 2011 at 11:52 PM, Peng Tao <[email protected]> wrote:
> Hi,
>
> I start to look at the error handling for ld_read/write_done.
> The two patches try to address the error handling for read/write pagelist
> failures, via nfs readpage/writepage interface. Please see if this method
> is proper. Thanks!
FWIW, this is just what we need for recoalescing pages when IO fails.
Currently ld_read/write_done is called in default workqueue, which is
not really a good place for IO path code. Trond mentioned that nfsiod
is not an ideal place for it either. So do we need to create a pnfs
private workqueue for this? Any other suggestions?

--
Thanks,
-Bergwolf