2020-11-06 05:41:54

by Alex Shi

[permalink] [raw]
Subject: [PATCH] nfsd/nfs3: remove unused macro nfsd3_fhandleres

The macro is unused, remove it to tame gcc warning:
fs/nfsd/nfs3proc.c:702:0: warning: macro "nfsd3_fhandleres" is not used
[-Wunused-macros]

Signed-off-by: Alex Shi <[email protected]>
Cc: "J. Bruce Fields" <[email protected]>
Cc: Chuck Lever <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
fs/nfsd/nfs3proc.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c
index 781e265921aa..6e79bae0af4d 100644
--- a/fs/nfsd/nfs3proc.c
+++ b/fs/nfsd/nfs3proc.c
@@ -687,7 +687,6 @@
#define nfsd3_mkdirargs nfsd3_createargs
#define nfsd3_readdirplusargs nfsd3_readdirargs
#define nfsd3_fhandleargs nfsd_fhandle
-#define nfsd3_fhandleres nfsd3_attrstat
#define nfsd3_attrstatres nfsd3_attrstat
#define nfsd3_wccstatres nfsd3_attrstat
#define nfsd3_createres nfsd3_diropres
--
1.8.3.1


2020-11-06 14:30:34

by Chuck Lever

[permalink] [raw]
Subject: Re: [PATCH] nfsd/nfs3: remove unused macro nfsd3_fhandleres



> On Nov 6, 2020, at 12:40 AM, Alex Shi <[email protected]> wrote:
>
> The macro is unused, remove it to tame gcc warning:
> fs/nfsd/nfs3proc.c:702:0: warning: macro "nfsd3_fhandleres" is not used
> [-Wunused-macros]
>
> Signed-off-by: Alex Shi <[email protected]>
> Cc: "J. Bruce Fields" <[email protected]>
> Cc: Chuck Lever <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> fs/nfsd/nfs3proc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c
> index 781e265921aa..6e79bae0af4d 100644
> --- a/fs/nfsd/nfs3proc.c
> +++ b/fs/nfsd/nfs3proc.c
> @@ -687,7 +687,6 @@
> #define nfsd3_mkdirargs nfsd3_createargs
> #define nfsd3_readdirplusargs nfsd3_readdirargs
> #define nfsd3_fhandleargs nfsd_fhandle
> -#define nfsd3_fhandleres nfsd3_attrstat
> #define nfsd3_attrstatres nfsd3_attrstat
> #define nfsd3_wccstatres nfsd3_attrstat
> #define nfsd3_createres nfsd3_diropres
> --
> 1.8.3.1

Applied to cel-next, thanks Alex.

The topic branch that collects patches for nfsd-5.11 is here:

http://git.linux-nfs.org/?p=cel/cel-2.6.git;a=shortlog;h=refs/heads/cel-next


--
Chuck Lever