2022-04-19 11:19:48

by Yang Xu (Fujitsu)

Subject: [PATCH v4 5/8] f2fs: Remove useless NULL assign value for acl and default_acl

Like other use ${fs}_init_acl and posix_acl_create filesystem, we don't
need to assign NULL for acl and default_acl pointer because f2fs_acl_create
will do this job. So remove it.

Signed-off-by: Yang Xu <[email protected]>
---
fs/f2fs/acl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c
index eaa240b21f07..9ae2d2fec58b 100644
--- a/fs/f2fs/acl.c
+++ b/fs/f2fs/acl.c
@@ -412,7 +412,7 @@ static int f2fs_acl_create(struct inode *dir, umode_t *mode,
int f2fs_init_acl(struct inode *inode, struct inode *dir, struct page *ipage,
struct page *dpage)
{
- struct posix_acl *default_acl = NULL, *acl = NULL;
+ struct posix_acl *default_acl, *acl;
int error;

error = f2fs_acl_create(dir, &inode->i_mode, &default_acl, &acl, dpage);
--
2.27.0

2022-04-19 18:23:45

by Christian Brauner

Subject: Re: [PATCH v4 5/8] f2fs: Remove useless NULL assign value for acl and default_acl

On Tue, Apr 19, 2022 at 07:47:11PM +0800, Yang Xu wrote:
> Like other use ${fs}_init_acl and posix_acl_create filesystem, we don't
> need to assign NULL for acl and default_acl pointer because f2fs_acl_create
> will do this job. So remove it.
>
> Signed-off-by: Yang Xu <[email protected]>
> ---
> fs/f2fs/acl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c
> index eaa240b21f07..9ae2d2fec58b 100644
> --- a/fs/f2fs/acl.c
> +++ b/fs/f2fs/acl.c
> @@ -412,7 +412,7 @@ static int f2fs_acl_create(struct inode *dir, umode_t *mode,
> int f2fs_init_acl(struct inode *inode, struct inode *dir, struct page *ipage,
> struct page *dpage)
> {
> - struct posix_acl *default_acl = NULL, *acl = NULL;
> + struct posix_acl *default_acl, *acl;

Hm, patches like this have nothing to do with the theme of this patch
series. They can go as completely independent patches to the relevant
fses. Imho, they don't belong with this series at all.

2022-04-22 09:55:42

by Yang Xu (Fujitsu)

Subject: Re: [PATCH v4 5/8] f2fs: Remove useless NULL assign value for acl and default_acl

on 2022/4/19 22:02, Christian Brauner wrote:
> On Tue, Apr 19, 2022 at 07:47:11PM +0800, Yang Xu wrote:
>> Like other use ${fs}_init_acl and posix_acl_create filesystem, we don't
>> need to assign NULL for acl and default_acl pointer because f2fs_acl_create
>> will do this job. So remove it.
>>
>> Signed-off-by: Yang Xu<[email protected]>
>> ---
>> fs/f2fs/acl.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c
>> index eaa240b21f07..9ae2d2fec58b 100644
>> --- a/fs/f2fs/acl.c
>> +++ b/fs/f2fs/acl.c
>> @@ -412,7 +412,7 @@ static int f2fs_acl_create(struct inode *dir, umode_t *mode,
>> int f2fs_init_acl(struct inode *inode, struct inode *dir, struct page *ipage,
>> struct page *dpage)
>> {
>> - struct posix_acl *default_acl = NULL, *acl = NULL;
>> + struct posix_acl *default_acl, *acl;
>
> Hm, patches like this have nothing to do with the theme of this patch
> series. They can go as completely independent patches to the relevant
> fses. Imho, they don't belong with this series at all.
Ok.