2008-01-25 17:02:18

by Myklebust, Trond

[permalink] [raw]
Subject: [PATCH 091/112] lockd: Eliminate harmless mixed sign comparison in nlmdbg_cookie2a()

From: Chuck Lever <[email protected]>

The cookie->len field is unsigned, so the loop index variable in
nlmdbg_cookie2a() should also be unsigned.

Signed-off-by: Chuck Lever <[email protected]>
Signed-off-by: Trond Myklebust <[email protected]>
---

fs/lockd/xdr.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/fs/lockd/xdr.c b/fs/lockd/xdr.c
index 633653b..3e459e1 100644
--- a/fs/lockd/xdr.c
+++ b/fs/lockd/xdr.c
@@ -612,8 +612,7 @@ const char *nlmdbg_cookie2a(const struct nlm_cookie *cookie)
* called with BKL held.
*/
static char buf[2*NLM_MAXCOOKIELEN+1];
- int i;
- int len = sizeof(buf);
+ unsigned int i, len = sizeof(buf);
char *p = buf;

len--; /* allow for trailing \0 */