2010-01-28 21:26:25

by Ben Myers

Subject: [PATCH 0/3] nfs-utils: multithreaded mountd fixes

Hey Steve,

The following fixes a problem with mountd where you get backed up behind the
rmtab lock. It may have happened that an xflock timed out and stat failed so
the filedescriptor was leaked in mountlist_list and the lock never released.
Skipping the fdatasync has also helped performance-wise.

Tested very lightly on TOT and more heavily on 1.0.7 where this bug was
discovered.

Thanks,
Ben

---

Ben Myers (3):
nfs-utils: remove xflock timeout
nfs-utils: dont leak fd in mountlist_list
nfs-utils: don't fdatasync the rmtab


support/nfs/cacheio.c | 5 ++---
support/nfs/rmtab.c | 23 ++++++++++++++++++-----
support/nfs/xio.c | 18 +-----------------
utils/mountd/rmtab.c | 5 ++++-
4 files changed, 25 insertions(+), 26 deletions(-)

--

2010-02-12 19:03:49

by Steve Dickson

Subject: Re: [PATCH 0/3] nfs-utils: multithreaded mountd fixes

On 01/28/2010 04:26 PM, Ben Myers wrote:
> Hey Steve,
>
> The following fixes a problem with mountd where you get backed up behind the
> rmtab lock. It may have happened that an xflock timed out and stat failed so
> the filedescriptor was leaked in mountlist_list and the lock never released.
> Skipping the fdatasync has also helped performance-wise.
>
> Tested very lightly on TOT and more heavily on 1.0.7 where this bug was
> discovered.
Committed...

steved.