2010-04-26 16:49:20

by Mike Frysinger

[permalink] [raw]
Subject: Re: [PATCH] make capabilities support optional

On Monday 26 April 2010 12:10:00 Steve Dickson wrote:
> On 04/26/2010 11:24 AM, Chuck Lever wrote:
> > At the very least, I think the man page should mention this bug somehow,
> > and maybe a warning should be generated during the build. Since this is
> > mostly for embedded systems, according to Mike, I doubt an actual
> > generated run-time warning would be visible to anyone.
>
> Mike would you be willing to test this out and document any
> differences in statd behaviour with and without that config
> flag set?

i think a BUGS section in statd is sufficient, but if you wanted to go
further, then a simple syslog() would be OK as well. dumping warnings to
stderr/stdout is obnoxious and non-standard for daemons. those really only
should be written when a daemon is quitting due to misconfiguration.

i can send a patch for the man page, but i'd only copy and paste what Chuck
wrote (about statd remaining registered upon exit).
-mike


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part.

2010-04-26 16:54:42

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH] make capabilities support optional



On 04/26/2010 12:51 PM, Mike Frysinger wrote:
> On Monday 26 April 2010 12:10:00 Steve Dickson wrote:
>> On 04/26/2010 11:24 AM, Chuck Lever wrote:
>>> At the very least, I think the man page should mention this bug somehow,
>>> and maybe a warning should be generated during the build. Since this is
>>> mostly for embedded systems, according to Mike, I doubt an actual
>>> generated run-time warning would be visible to anyone.
>>
>> Mike would you be willing to test this out and document any
>> differences in statd behaviour with and without that config
>> flag set?
>
> i think a BUGS section in statd is sufficient, but if you wanted to go
> further, then a simple syslog() would be OK as well. dumping warnings to
> stderr/stdout is obnoxious and non-standard for daemons. those really only
> should be written when a daemon is quitting due to misconfiguration.
I agree... a blurb in the BUGS section is all that is needed..
>
> i can send a patch for the man page, but i'd only copy and paste what Chuck
> wrote (about statd remaining registered upon exit).
That would be good... thanks!

steved.