2011-06-21 01:19:27

by Hartley Sweeten

Subject: [PATCH] svcauth_unix.c: quiet sparse noise

Like svcauth_unix, the symbol svcauth_null is used external from this
file. Declare it as extern to quiet the following sparse noise:

warning: symbol 'svcauth_null' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Trond Myklebust <[email protected]>
Cc: "J. Bruce Fields" <[email protected]>
Cc: Neil Brown <[email protected]>
Cc: "David S. Miller" <[email protected]>

---

diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c
index c8e1021..62e49e2 100644
--- a/net/sunrpc/svcauth_unix.c
+++ b/net/sunrpc/svcauth_unix.c
@@ -36,6 +36,7 @@ struct unix_domain {
/* other stuff later */
};

+extern struct auth_ops svcauth_null;
extern struct auth_ops svcauth_unix;

static void svcauth_unix_domain_release(struct auth_domain *dom)

2011-06-21 22:44:32

by J. Bruce Fields

Subject: Re: [PATCH] svcauth_unix.c: quiet sparse noise

On Mon, Jun 20, 2011 at 06:19:12PM -0700, H Hartley Sweeten wrote:
> Like svcauth_unix, the symbol svcauth_null is used external from this
> file. Declare it as extern to quiet the following sparse noise:
>
> warning: symbol 'svcauth_null' was not declared. Should it be static?

Also applying for 3.1.--b.

>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Trond Myklebust <[email protected]>
> Cc: "J. Bruce Fields" <[email protected]>
> Cc: Neil Brown <[email protected]>
> Cc: "David S. Miller" <[email protected]>
>
> ---
>
> diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c
> index c8e1021..62e49e2 100644
> --- a/net/sunrpc/svcauth_unix.c
> +++ b/net/sunrpc/svcauth_unix.c
> @@ -36,6 +36,7 @@ struct unix_domain {
> /* other stuff later */
> };
>
> +extern struct auth_ops svcauth_null;
> extern struct auth_ops svcauth_unix;
>
> static void svcauth_unix_domain_release(struct auth_domain *dom)