2011-06-21 00:55:10

by Hartley Sweeten

Subject: [PATCH] svcsock.c: include sunrpc.h to quite sparse noise

Include the private header sunrpc.h to pickup the declaration of the
function svc_send_common to quiet the following sparse noise:

warning: symbol 'svc_send_common' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Trond Myklebust <[email protected]>
Cc: "J. Bruce Fields" <[email protected]>
Cc: Neil Brown <[email protected]>
Cc: "David S. Miller" <[email protected]>

---

diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index af04f77..f2cb5b8 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -51,6 +51,8 @@
#include <linux/sunrpc/stats.h>
#include <linux/sunrpc/xprt.h>

+#include "sunrpc.h"
+
#define RPCDBG_FACILITY RPCDBG_SVCXPRT

2011-06-21 22:44:20

by J. Bruce Fields

Subject: Re: [PATCH] svcsock.c: include sunrpc.h to quite sparse noise

On Mon, Jun 20, 2011 at 05:54:51PM -0700, H Hartley Sweeten wrote:
> Include the private header sunrpc.h to pickup the declaration of the
> function svc_send_common to quiet the following sparse noise:
>
> warning: symbol 'svc_send_common' was not declared. Should it be static?

Thanks, applying for 3.1--b.

>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Trond Myklebust <[email protected]>
> Cc: "J. Bruce Fields" <[email protected]>
> Cc: Neil Brown <[email protected]>
> Cc: "David S. Miller" <[email protected]>
>
> ---
>
> diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
> index af04f77..f2cb5b8 100644
> --- a/net/sunrpc/svcsock.c
> +++ b/net/sunrpc/svcsock.c
> @@ -51,6 +51,8 @@
> #include <linux/sunrpc/stats.h>
> #include <linux/sunrpc/xprt.h>
>
> +#include "sunrpc.h"
> +
> #define RPCDBG_FACILITY RPCDBG_SVCXPRT
>
>