When NFSv4 is configured, the support goes into the nfs.ko module.
However, nfs-utils seems to pass "nfs4" as the fileststem type for
NFSv4 mounts. If the nfs module is not already loaded, the kernel
will eventually do a module request for "nfs4". Apparently, this
has worked until now as the distributions ship a module config file
that manually aliases "nfs4" to "nfs".
There is really no need to do this, as the kernel can provide a
module alias internally for nfs4. This adds that.
Signed-off-by: Josh Boyer <[email protected]>
---
fs/nfs/nfs4proc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 60d5f4c..d6929c3 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -6550,6 +6550,7 @@ const struct xattr_handler *nfs4_xattr_handlers[] = {
module_param(max_session_slots, ushort, 0644);
MODULE_PARM_DESC(max_session_slots, "Maximum number of outstanding NFSv4.1 "
"requests the client will negotiate");
+MODULE_ALIAS("nfs4");
/*
* Local variables:
--
1.7.10
On Fri, Apr 27, 2012 at 02:50:28PM +0000, Myklebust, Trond wrote:
> On Fri, 2012-04-27 at 10:48 -0400, Josh Boyer wrote:
> > On Fri, Apr 27, 2012 at 10:19:18AM -0400, Jim Rees wrote:
> > > Josh Boyer wrote:
> > >
> > > When NFSv4 is configured, the support goes into the nfs.ko module.
> > > However, nfs-utils seems to pass "nfs4" as the fileststem type for
> > > NFSv4 mounts.
> > >
> > > Weren't we going to change that to nfs and use nfsvers to select nfs4?
> >
> > I have, approximately, no idea. At least the version of nfs-utils found
> > in Fedora 17 and rawhide, it's still using "nfs4". I believe that is
> > nfs-utils-1.2.6-rc6 based.
>
> nfs4 is still _supported_ in Fedora 17, rawhide and upstream as a legacy
> feature, but the recommended practice should be to mount -t nfs -overs=4
> (or -overs=4.1).
OK. So either this patch needs to go in, or something needs to add:
alias nfs4 nfs
to a conf file so modprobe picks it up. I figured the kernel could add
the alias itself. Is there a reason not to?
josh
Josh Boyer wrote:
When NFSv4 is configured, the support goes into the nfs.ko module.
However, nfs-utils seems to pass "nfs4" as the fileststem type for
NFSv4 mounts.
Weren't we going to change that to nfs and use nfsvers to select nfs4?
T24gRnJpLCAyMDEyLTA0LTI3IGF0IDExOjE0IC0wNDAwLCBKb3NoIEJveWVyIHdyb3RlOg0KPiBP
biBGcmksIEFwciAyNywgMjAxMiBhdCAwMzowMjowN1BNICswMDAwLCBNeWtsZWJ1c3QsIFRyb25k
IHdyb3RlOg0KPiA+IE9uIEZyaSwgMjAxMi0wNC0yNyBhdCAxMDo1MyAtMDQwMCwgSm9zaCBCb3ll
ciB3cm90ZToNCj4gPiA+IE9uIEZyaSwgQXByIDI3LCAyMDEyIGF0IDAyOjUwOjI4UE0gKzAwMDAs
IE15a2xlYnVzdCwgVHJvbmQgd3JvdGU6DQo+ID4gPiA+IE9uIEZyaSwgMjAxMi0wNC0yNyBhdCAx
MDo0OCAtMDQwMCwgSm9zaCBCb3llciB3cm90ZToNCj4gPiA+ID4gPiBPbiBGcmksIEFwciAyNywg
MjAxMiBhdCAxMDoxOToxOEFNIC0wNDAwLCBKaW0gUmVlcyB3cm90ZToNCj4gPiA+ID4gPiA+IEpv
c2ggQm95ZXIgd3JvdGU6DQo+ID4gPiA+ID4gPiANCj4gPiA+ID4gPiA+ICAgV2hlbiBORlN2NCBp
cyBjb25maWd1cmVkLCB0aGUgc3VwcG9ydCBnb2VzIGludG8gdGhlIG5mcy5rbyBtb2R1bGUuDQo+
ID4gPiA+ID4gPiAgIEhvd2V2ZXIsIG5mcy11dGlscyBzZWVtcyB0byBwYXNzICJuZnM0IiBhcyB0
aGUgZmlsZXN0c3RlbSB0eXBlIGZvcg0KPiA+ID4gPiA+ID4gICBORlN2NCBtb3VudHMuDQo+ID4g
PiA+ID4gPiANCj4gPiA+ID4gPiA+IFdlcmVuJ3Qgd2UgZ29pbmcgdG8gY2hhbmdlIHRoYXQgdG8g
bmZzIGFuZCB1c2UgbmZzdmVycyB0byBzZWxlY3QgbmZzND8NCj4gPiA+ID4gPiANCj4gPiA+ID4g
PiBJIGhhdmUsIGFwcHJveGltYXRlbHksIG5vIGlkZWEuICBBdCBsZWFzdCB0aGUgdmVyc2lvbiBv
ZiBuZnMtdXRpbHMgZm91bmQNCj4gPiA+ID4gPiBpbiBGZWRvcmEgMTcgYW5kIHJhd2hpZGUsIGl0
J3Mgc3RpbGwgdXNpbmcgIm5mczQiLiAgIEkgYmVsaWV2ZSB0aGF0IGlzDQo+ID4gPiA+ID4gbmZz
LXV0aWxzLTEuMi42LXJjNiBiYXNlZC4NCj4gPiA+ID4gDQo+ID4gPiA+IG5mczQgaXMgc3RpbGwg
X3N1cHBvcnRlZF8gaW4gRmVkb3JhIDE3LCByYXdoaWRlIGFuZCB1cHN0cmVhbSBhcyBhIGxlZ2Fj
eQ0KPiA+ID4gPiBmZWF0dXJlLCBidXQgdGhlIHJlY29tbWVuZGVkIHByYWN0aWNlIHNob3VsZCBi
ZSB0byBtb3VudCAtdCBuZnMgLW92ZXJzPTQNCj4gPiA+ID4gKG9yIC1vdmVycz00LjEpLg0KPiA+
ID4gDQo+ID4gPiBPSy4gIFNvIGVpdGhlciB0aGlzIHBhdGNoIG5lZWRzIHRvIGdvIGluLCBvciBz
b21ldGhpbmcgbmVlZHMgdG8gYWRkOg0KPiA+ID4gDQo+ID4gPiBhbGlhcyBuZnM0IG5mcw0KPiA+
ID4gDQo+ID4gPiB0byBhIGNvbmYgZmlsZSBzbyBtb2Rwcm9iZSBwaWNrcyBpdCB1cC4gIEkgZmln
dXJlZCB0aGUga2VybmVsIGNvdWxkIGFkZA0KPiA+ID4gdGhlIGFsaWFzIGl0c2VsZi4gIElzIHRo
ZXJlIGEgcmVhc29uIG5vdCB0bz8NCj4gPiANCj4gPiBZZXMuIFRoaXMgaXMgYSBsZWdhY3kgZmVh
dHVyZSB0aGF0IHdlIHdhbnQgdG8gZW5jb3VyYWdlIHBlb3BsZSB0byBtb3ZlDQo+ID4gdGhlaXIg
c3lzdGVtcyBvZmYuLi4NCj4gDQo+IFNvIGVzc2VudGlhbGx5IHdoYXQgbmVlZHMgdG8gaGFwcGVu
IGlzOg0KPiANCj4gLSBSZWNlbnQgZGlzdHJvcyBzdGlsbCBzaGlwIHRoZSBtb2RhbGlhcyBpbiBh
IGNvbmYgZmlsZQ0KPiAtIFVwc3RyZWFtIG5mcy11dGlscyBzdGFydHMgdHJhbnNsYXRpbmcgJ21v
dW50IC10IG5mczQnIGludG8gJ21vdW50IC10DQo+ICAgbmZzIC1vdmVycz00JyBpbiAvc2Jpbi9t
b3VudC5uZnM0DQo+IC0gVXBzdHJlYW0gcmVsZWFzZXMgdGhhdA0KPiAtIERpc3Ryb3MgZHJvcCB0
aGUgYWxpYXMuDQo+IA0KPiBSaWdodD8NCg0KTm8uIFJlYWxseSBhbGwgd2UgbmVlZCB0byBkbyBp
cyBhZGQgYSBwcmludGYoKSB0byAvc2Jpbi9tb3VudC5uZnM0IHRvDQp0aGUgZWZmZWN0IHRoYXQg
dGhpcyBpcyBhIGxlZ2FjeSBmZWF0dXJlIGFuZCB0aGF0ICctdCBuZnMgLW92ZXJzPTQnIGlzDQp0
aGUgcmVjb21tZW5kZWQgbW91bnQgb3B0aW9uLiBQZXJoYXBzIHRoZSBkaXN0cm9zIGNhbiBhbHNv
IGhhdmUgdGhlaXINCmRpc3RybyB1cGdyYWRlIHV0aWxpdGllcyBlZGl0IC9ldGMvZnN0YWIgdG8g
dXBncmFkZSB0aG9zZSBhdXRvbWF0aWNhbGx5Lg0KDQpUaGVuIHRoZSBkaXN0cm9zIGNhbiBkcm9w
IHRoZSBhbGlhcyB3aGVuZXZlciB0aGV5IHRoaW5rIGl0IGlzDQphcHByb3ByaWF0ZS4NCg0KLS0g
DQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRhaW5lcg0KDQpOZXRBcHAN
ClRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tDQp3d3cubmV0YXBwLmNvbQ0KDQo=
On Fri, 27 Apr 2012 09:10:33 -0400
Josh Boyer <[email protected]> wrote:
> When NFSv4 is configured, the support goes into the nfs.ko module.
> However, nfs-utils seems to pass "nfs4" as the fileststem type for
> NFSv4 mounts. If the nfs module is not already loaded, the kernel
> will eventually do a module request for "nfs4". Apparently, this
> has worked until now as the distributions ship a module config file
> that manually aliases "nfs4" to "nfs".
>
> There is really no need to do this, as the kernel can provide a
> module alias internally for nfs4. This adds that.
>
> Signed-off-by: Josh Boyer <[email protected]>
> ---
> fs/nfs/nfs4proc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 60d5f4c..d6929c3 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -6550,6 +6550,7 @@ const struct xattr_handler *nfs4_xattr_handlers[] = {
> module_param(max_session_slots, ushort, 0644);
> MODULE_PARM_DESC(max_session_slots, "Maximum number of outstanding NFSv4.1 "
> "requests the client will negotiate");
> +MODULE_ALIAS("nfs4");
>
> /*
> * Local variables:
Looks reasonable to me.
Reviewed-by: Jeff Layton <[email protected]>
T24gRnJpLCAyMDEyLTA0LTI3IGF0IDEwOjQ4IC0wNDAwLCBKb3NoIEJveWVyIHdyb3RlOg0KPiBP
biBGcmksIEFwciAyNywgMjAxMiBhdCAxMDoxOToxOEFNIC0wNDAwLCBKaW0gUmVlcyB3cm90ZToN
Cj4gPiBKb3NoIEJveWVyIHdyb3RlOg0KPiA+IA0KPiA+ICAgV2hlbiBORlN2NCBpcyBjb25maWd1
cmVkLCB0aGUgc3VwcG9ydCBnb2VzIGludG8gdGhlIG5mcy5rbyBtb2R1bGUuDQo+ID4gICBIb3dl
dmVyLCBuZnMtdXRpbHMgc2VlbXMgdG8gcGFzcyAibmZzNCIgYXMgdGhlIGZpbGVzdHN0ZW0gdHlw
ZSBmb3INCj4gPiAgIE5GU3Y0IG1vdW50cy4NCj4gPiANCj4gPiBXZXJlbid0IHdlIGdvaW5nIHRv
IGNoYW5nZSB0aGF0IHRvIG5mcyBhbmQgdXNlIG5mc3ZlcnMgdG8gc2VsZWN0IG5mczQ/DQo+IA0K
PiBJIGhhdmUsIGFwcHJveGltYXRlbHksIG5vIGlkZWEuICBBdCBsZWFzdCB0aGUgdmVyc2lvbiBv
ZiBuZnMtdXRpbHMgZm91bmQNCj4gaW4gRmVkb3JhIDE3IGFuZCByYXdoaWRlLCBpdCdzIHN0aWxs
IHVzaW5nICJuZnM0Ii4gICBJIGJlbGlldmUgdGhhdCBpcw0KPiBuZnMtdXRpbHMtMS4yLjYtcmM2
IGJhc2VkLg0KDQpuZnM0IGlzIHN0aWxsIF9zdXBwb3J0ZWRfIGluIEZlZG9yYSAxNywgcmF3aGlk
ZSBhbmQgdXBzdHJlYW0gYXMgYSBsZWdhY3kNCmZlYXR1cmUsIGJ1dCB0aGUgcmVjb21tZW5kZWQg
cHJhY3RpY2Ugc2hvdWxkIGJlIHRvIG1vdW50IC10IG5mcyAtb3ZlcnM9NA0KKG9yIC1vdmVycz00
LjEpLg0KDQpDaGVlcnMNCiAgVHJvbmQNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMg
Y2xpZW50IG1haW50YWluZXINCg0KTmV0QXBwDQpUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbQ0K
d3d3Lm5ldGFwcC5jb20NCg0K
On Fri, 27 Apr 2012 15:02:07 +0000
"Myklebust, Trond" <[email protected]> wrote:
> On Fri, 2012-04-27 at 10:53 -0400, Josh Boyer wrote:
> > On Fri, Apr 27, 2012 at 02:50:28PM +0000, Myklebust, Trond wrote:
> > > On Fri, 2012-04-27 at 10:48 -0400, Josh Boyer wrote:
> > > > On Fri, Apr 27, 2012 at 10:19:18AM -0400, Jim Rees wrote:
> > > > > Josh Boyer wrote:
> > > > >
> > > > > When NFSv4 is configured, the support goes into the nfs.ko module.
> > > > > However, nfs-utils seems to pass "nfs4" as the fileststem type for
> > > > > NFSv4 mounts.
> > > > >
> > > > > Weren't we going to change that to nfs and use nfsvers to select nfs4?
> > > >
> > > > I have, approximately, no idea. At least the version of nfs-utils found
> > > > in Fedora 17 and rawhide, it's still using "nfs4". I believe that is
> > > > nfs-utils-1.2.6-rc6 based.
> > >
> > > nfs4 is still _supported_ in Fedora 17, rawhide and upstream as a legacy
> > > feature, but the recommended practice should be to mount -t nfs -overs=4
> > > (or -overs=4.1).
> >
> > OK. So either this patch needs to go in, or something needs to add:
> >
> > alias nfs4 nfs
> >
> > to a conf file so modprobe picks it up. I figured the kernel could add
> > the alias itself. Is there a reason not to?
>
> Yes. This is a legacy feature that we want to encourage people to move
> their systems off...
>
Ahh ok...I guess I didn't get that memo. In that case, is there a plan
to deprecate the nfs4 fstype altogether?
Otherwise, you're going to end up with inconsistent behavior with "-t
nfs4", depending on whether nfs.ko is already plugged in at the time or
not.
--
Jeff Layton <[email protected]>
On Fri, Apr 27, 2012 at 03:21:15PM +0000, Myklebust, Trond wrote:
> > > > OK. So either this patch needs to go in, or something needs to add:
> > > >
> > > > alias nfs4 nfs
> > > >
> > > > to a conf file so modprobe picks it up. I figured the kernel could add
> > > > the alias itself. Is there a reason not to?
> > >
> > > Yes. This is a legacy feature that we want to encourage people to move
> > > their systems off...
> >
> > So essentially what needs to happen is:
> >
> > - Recent distros still ship the modalias in a conf file
> > - Upstream nfs-utils starts translating 'mount -t nfs4' into 'mount -t
> > nfs -overs=4' in /sbin/mount.nfs4
> > - Upstream releases that
> > - Distros drop the alias.
> >
> > Right?
>
> No. Really all we need to do is add a printf() to /sbin/mount.nfs4 to
> the effect that this is a legacy feature and that '-t nfs -overs=4' is
> the recommended mount option. Perhaps the distros can also have their
> distro upgrade utilities edit /etc/fstab to upgrade those automatically.
>
> Then the distros can drop the alias whenever they think it is
> appropriate.
My limited experience shows that people won't change their habits until
those habits simply no longer work. Adding a printf is probably a fine
thing to do, but I'm not sure it will have much impact on how people go
about mounting NFSv4 filesystems. That leads me to believe that the
alias will be carried along for quite a while.
Anyway, the immediate problem can be solved by just keeping the alias in
a conf file. If that's what is recommended for now, OK.
josh
T24gRnJpLCAyMDEyLTA0LTI3IGF0IDEwOjUzIC0wNDAwLCBKb3NoIEJveWVyIHdyb3RlOg0KPiBP
biBGcmksIEFwciAyNywgMjAxMiBhdCAwMjo1MDoyOFBNICswMDAwLCBNeWtsZWJ1c3QsIFRyb25k
IHdyb3RlOg0KPiA+IE9uIEZyaSwgMjAxMi0wNC0yNyBhdCAxMDo0OCAtMDQwMCwgSm9zaCBCb3ll
ciB3cm90ZToNCj4gPiA+IE9uIEZyaSwgQXByIDI3LCAyMDEyIGF0IDEwOjE5OjE4QU0gLTA0MDAs
IEppbSBSZWVzIHdyb3RlOg0KPiA+ID4gPiBKb3NoIEJveWVyIHdyb3RlOg0KPiA+ID4gPiANCj4g
PiA+ID4gICBXaGVuIE5GU3Y0IGlzIGNvbmZpZ3VyZWQsIHRoZSBzdXBwb3J0IGdvZXMgaW50byB0
aGUgbmZzLmtvIG1vZHVsZS4NCj4gPiA+ID4gICBIb3dldmVyLCBuZnMtdXRpbHMgc2VlbXMgdG8g
cGFzcyAibmZzNCIgYXMgdGhlIGZpbGVzdHN0ZW0gdHlwZSBmb3INCj4gPiA+ID4gICBORlN2NCBt
b3VudHMuDQo+ID4gPiA+IA0KPiA+ID4gPiBXZXJlbid0IHdlIGdvaW5nIHRvIGNoYW5nZSB0aGF0
IHRvIG5mcyBhbmQgdXNlIG5mc3ZlcnMgdG8gc2VsZWN0IG5mczQ/DQo+ID4gPiANCj4gPiA+IEkg
aGF2ZSwgYXBwcm94aW1hdGVseSwgbm8gaWRlYS4gIEF0IGxlYXN0IHRoZSB2ZXJzaW9uIG9mIG5m
cy11dGlscyBmb3VuZA0KPiA+ID4gaW4gRmVkb3JhIDE3IGFuZCByYXdoaWRlLCBpdCdzIHN0aWxs
IHVzaW5nICJuZnM0Ii4gICBJIGJlbGlldmUgdGhhdCBpcw0KPiA+ID4gbmZzLXV0aWxzLTEuMi42
LXJjNiBiYXNlZC4NCj4gPiANCj4gPiBuZnM0IGlzIHN0aWxsIF9zdXBwb3J0ZWRfIGluIEZlZG9y
YSAxNywgcmF3aGlkZSBhbmQgdXBzdHJlYW0gYXMgYSBsZWdhY3kNCj4gPiBmZWF0dXJlLCBidXQg
dGhlIHJlY29tbWVuZGVkIHByYWN0aWNlIHNob3VsZCBiZSB0byBtb3VudCAtdCBuZnMgLW92ZXJz
PTQNCj4gPiAob3IgLW92ZXJzPTQuMSkuDQo+IA0KPiBPSy4gIFNvIGVpdGhlciB0aGlzIHBhdGNo
IG5lZWRzIHRvIGdvIGluLCBvciBzb21ldGhpbmcgbmVlZHMgdG8gYWRkOg0KPiANCj4gYWxpYXMg
bmZzNCBuZnMNCj4gDQo+IHRvIGEgY29uZiBmaWxlIHNvIG1vZHByb2JlIHBpY2tzIGl0IHVwLiAg
SSBmaWd1cmVkIHRoZSBrZXJuZWwgY291bGQgYWRkDQo+IHRoZSBhbGlhcyBpdHNlbGYuICBJcyB0
aGVyZSBhIHJlYXNvbiBub3QgdG8/DQoNClllcy4gVGhpcyBpcyBhIGxlZ2FjeSBmZWF0dXJlIHRo
YXQgd2Ugd2FudCB0byBlbmNvdXJhZ2UgcGVvcGxlIHRvIG1vdmUNCnRoZWlyIHN5c3RlbXMgb2Zm
Li4uDQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIN
Cg0KTmV0QXBwDQpUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbQ0Kd3d3Lm5ldGFwcC5jb20NCg0K
On Fri, Apr 27, 2012 at 10:19:18AM -0400, Jim Rees wrote:
> Josh Boyer wrote:
>
> When NFSv4 is configured, the support goes into the nfs.ko module.
> However, nfs-utils seems to pass "nfs4" as the fileststem type for
> NFSv4 mounts.
>
> Weren't we going to change that to nfs and use nfsvers to select nfs4?
I have, approximately, no idea. At least the version of nfs-utils found
in Fedora 17 and rawhide, it's still using "nfs4". I believe that is
nfs-utils-1.2.6-rc6 based.
josh
On Fri, Apr 27, 2012 at 03:02:07PM +0000, Myklebust, Trond wrote:
> On Fri, 2012-04-27 at 10:53 -0400, Josh Boyer wrote:
> > On Fri, Apr 27, 2012 at 02:50:28PM +0000, Myklebust, Trond wrote:
> > > On Fri, 2012-04-27 at 10:48 -0400, Josh Boyer wrote:
> > > > On Fri, Apr 27, 2012 at 10:19:18AM -0400, Jim Rees wrote:
> > > > > Josh Boyer wrote:
> > > > >
> > > > > When NFSv4 is configured, the support goes into the nfs.ko module.
> > > > > However, nfs-utils seems to pass "nfs4" as the fileststem type for
> > > > > NFSv4 mounts.
> > > > >
> > > > > Weren't we going to change that to nfs and use nfsvers to select nfs4?
> > > >
> > > > I have, approximately, no idea. At least the version of nfs-utils found
> > > > in Fedora 17 and rawhide, it's still using "nfs4". I believe that is
> > > > nfs-utils-1.2.6-rc6 based.
> > >
> > > nfs4 is still _supported_ in Fedora 17, rawhide and upstream as a legacy
> > > feature, but the recommended practice should be to mount -t nfs -overs=4
> > > (or -overs=4.1).
> >
> > OK. So either this patch needs to go in, or something needs to add:
> >
> > alias nfs4 nfs
> >
> > to a conf file so modprobe picks it up. I figured the kernel could add
> > the alias itself. Is there a reason not to?
>
> Yes. This is a legacy feature that we want to encourage people to move
> their systems off...
So essentially what needs to happen is:
- Recent distros still ship the modalias in a conf file
- Upstream nfs-utils starts translating 'mount -t nfs4' into 'mount -t
nfs -overs=4' in /sbin/mount.nfs4
- Upstream releases that
- Distros drop the alias.
Right?
josh