2013-05-11 16:15:12

by Dan Carpenter

Subject: [patch] svcauth_gss: fix error code in use_gss_proxy()

This should return zero on success and -EBUSY on error so the type
needs to be int instead of bool.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
index 871c73c..2c6a1ec 100644
--- a/net/sunrpc/auth_gss/svcauth_gss.c
+++ b/net/sunrpc/auth_gss/svcauth_gss.c
@@ -1287,7 +1287,7 @@ static bool use_gss_proxy(struct net *net)

#ifdef CONFIG_PROC_FS

-static bool set_gss_proxy(struct net *net, int type)
+static int set_gss_proxy(struct net *net, int type)
{
struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
int ret = 0;

2013-05-11 18:43:57

by J. Bruce Fields

Subject: Re: [patch] svcauth_gss: fix error code in use_gss_proxy()

On Sat, May 11, 2013 at 07:13:49PM +0300, Dan Carpenter wrote:
> This should return zero on success and -EBUSY on error so the type
> needs to be int instead of bool.

Oops, you're right--thanks. Applying.--b.

>
> Signed-off-by: Dan Carpenter <[email protected]>
>
> diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
> index 871c73c..2c6a1ec 100644
> --- a/net/sunrpc/auth_gss/svcauth_gss.c
> +++ b/net/sunrpc/auth_gss/svcauth_gss.c
> @@ -1287,7 +1287,7 @@ static bool use_gss_proxy(struct net *net)
>
> #ifdef CONFIG_PROC_FS
>
> -static bool set_gss_proxy(struct net *net, int type)
> +static int set_gss_proxy(struct net *net, int type)
> {
> struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
> int ret = 0;