2013-06-11 09:34:13

by Maximilian Wilhelm

[permalink] [raw]
Subject: [PATCH]: gssd: Fix preferred_realm option handling

Hi,

the gssd currently ignores any preferred realm given via the -R
command line option.

The attached patch fixes that behaviour and makes sure the
preferrred_realm is used first when searching for a valid principal
for mount authentication.

I would be happy if you would apply this. This would close bug #235 in
bugzilla.

Thanks
Max


Attachments:
(No filename) (338.00 B)
gssd_fix_preferred_realm.patch (1.32 kB)
Download all attachments

2013-06-17 17:02:56

by Maximilian Wilhelm

[permalink] [raw]
Subject: Re: [PATCH]: gssd: Fix preferred_realm option handling

Anno domini 2013 Jim Rees scripsit:

> Maximilian Wilhelm wrote:

> + * Make sure the preferred_realm (which may have been explicitly set
> + * on the command line, is tried first. If nothing is found go on with
> + * the host and local default realm (if that hasn't already been tried).

> You're missing a close paren there somewhere.

Indeed. The first '(' should have been a ','.

Anyone willing to apply this?

Thanks
Max
--
Fortschritt bedeutet, einen Schritt so zu machen,
daß man den nächsten auch noch machen kann.

2013-06-24 17:00:50

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH]: gssd: Fix preferred_realm option handling



On 17/06/13 13:02, Maximilian Wilhelm wrote:
> Anno domini 2013 Jim Rees scripsit:
>
>> Maximilian Wilhelm wrote:
>
>> + * Make sure the preferred_realm (which may have been explicitly set
>> + * on the command line, is tried first. If nothing is found go on with
>> + * the host and local default realm (if that hasn't already been tried).
>
>> You're missing a close paren there somewhere.
>
> Indeed. The first '(' should have been a ','.
>
> Anyone willing to apply this?
Its on my TODO list... and I'll fix the comment up...

steved.

>
> Thanks
> Max
>

2013-06-18 17:14:38

by J. Bruce Fields

[permalink] [raw]
Subject: Re: [PATCH]: gssd: Fix preferred_realm option handling

On Mon, Jun 17, 2013 at 07:02:47PM +0200, Maximilian Wilhelm wrote:
> Anno domini 2013 Jim Rees scripsit:
>
> > Maximilian Wilhelm wrote:
>
> > + * Make sure the preferred_realm (which may have been explicitly set
> > + * on the command line, is tried first. If nothing is found go on with
> > + * the host and local default realm (if that hasn't already been tried).
>
> > You're missing a close paren there somewhere.
>
> Indeed. The first '(' should have been a ','.
>
> Anyone willing to apply this?

Note nfs-utils patches should go to [email protected], cc'd to this
list.

But also note this is the week of the Ann Arbor bakeathon so many of us
will be less responsive this week.

--b.

2013-06-11 11:41:29

by Jim Rees

[permalink] [raw]
Subject: Re: [PATCH]: gssd: Fix preferred_realm option handling

Maximilian Wilhelm wrote:

+ * Make sure the preferred_realm (which may have been explicitly set
+ * on the command line, is tried first. If nothing is found go on with
+ * the host and local default realm (if that hasn't already been tried).

You're missing a close paren there somewhere.