2013-07-09 03:19:28

by J. Bruce Fields

[permalink] [raw]
Subject: [PATCH] nfsd4: support minorversion 1 by default

From: "J. Bruce Fields" <[email protected]>

We now have minimal minorversion 1 support; turn it on by default.

This can still be turned off with "echo -4.1 >/proc/fs/nfsd/versions".

Signed-off-by: J. Bruce Fields <[email protected]>
---
fs/nfsd/nfssvc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index 262df5c..6b9f48c 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -116,7 +116,7 @@ struct svc_program nfsd_program = {

};

-u32 nfsd_supported_minorversion;
+u32 nfsd_supported_minorversion = 1;

int nfsd_vers(int vers, enum vers_op change)
{
--
1.7.9.5



2013-07-09 17:05:11

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH] nfsd4: support minorversion 1 by default



On 09/07/13 12:58, J. Bruce Fields wrote:
> On Tue, Jul 09, 2013 at 11:56:56AM -0400, Steve Dickson wrote:
>>
>>
>> On 09/07/13 11:06, J. Bruce Fields wrote:
>>> On Mon, Jul 08, 2013 at 11:19:28PM -0400, J. Bruce Fields wrote:
>>>>> From: "J. Bruce Fields" <[email protected]>
>>>>>
>>>>> We now have minimal minorversion 1 support; turn it on by default.
>>>>>
>>>>> This can still be turned off with "echo -4.1 >/proc/fs/nfsd/versions".
>>> I intend this for 3.11, since as far as I can tell we're up to spec and
>>> the 4.1-specific bugs I know about have been fixed.
>> Ok... Its on my TODO list but I'll wait a bit until 3.11 hits
>> the street...
>
> I don't think there's anything for you to do here.
Ah... my bad... I thought I had to do something for rpc.nfsd but
after talking a look the code is already there...

steved.

2013-07-09 15:06:58

by J. Bruce Fields

[permalink] [raw]
Subject: Re: [PATCH] nfsd4: support minorversion 1 by default

On Mon, Jul 08, 2013 at 11:19:28PM -0400, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <[email protected]>
>
> We now have minimal minorversion 1 support; turn it on by default.
>
> This can still be turned off with "echo -4.1 >/proc/fs/nfsd/versions".

I intend this for 3.11, since as far as I can tell we're up to spec and
the 4.1-specific bugs I know about have been fixed.

--b.

>
> Signed-off-by: J. Bruce Fields <[email protected]>
> ---
> fs/nfsd/nfssvc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 262df5c..6b9f48c 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -116,7 +116,7 @@ struct svc_program nfsd_program = {
>
> };
>
> -u32 nfsd_supported_minorversion;
> +u32 nfsd_supported_minorversion = 1;
>
> int nfsd_vers(int vers, enum vers_op change)
> {
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2013-07-09 16:58:28

by J. Bruce Fields

[permalink] [raw]
Subject: Re: [PATCH] nfsd4: support minorversion 1 by default

On Tue, Jul 09, 2013 at 11:56:56AM -0400, Steve Dickson wrote:
>
>
> On 09/07/13 11:06, J. Bruce Fields wrote:
> > On Mon, Jul 08, 2013 at 11:19:28PM -0400, J. Bruce Fields wrote:
> >> > From: "J. Bruce Fields" <[email protected]>
> >> >
> >> > We now have minimal minorversion 1 support; turn it on by default.
> >> >
> >> > This can still be turned off with "echo -4.1 >/proc/fs/nfsd/versions".
> > I intend this for 3.11, since as far as I can tell we're up to spec and
> > the 4.1-specific bugs I know about have been fixed.
> Ok... Its on my TODO list but I'll wait a bit until 3.11 hits
> the street...

I don't think there's anything for you to do here.

--b.

2013-07-09 15:56:59

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH] nfsd4: support minorversion 1 by default



On 09/07/13 11:06, J. Bruce Fields wrote:
> On Mon, Jul 08, 2013 at 11:19:28PM -0400, J. Bruce Fields wrote:
>> > From: "J. Bruce Fields" <[email protected]>
>> >
>> > We now have minimal minorversion 1 support; turn it on by default.
>> >
>> > This can still be turned off with "echo -4.1 >/proc/fs/nfsd/versions".
> I intend this for 3.11, since as far as I can tell we're up to spec and
> the 4.1-specific bugs I know about have been fixed.
Ok... Its on my TODO list but I'll wait a bit until 3.11 hits
the street...

steved.