2013-09-19 19:12:05

by J. Bruce Fields

Subject: [PATCH] exportfs: test_export shouldn't use invalid uid/gid

From: "J. Bruce Fields" <[email protected]>

Some newer kernels are rejecting -1 uid/gid. Actually, worse--they're
silently ignoring any attempt to cache such exports, thus preventing
test_export from getting back the errors it needs.

And -1 wasn't a good choice anyway.

Signed-off-by: J. Bruce Fields <[email protected]>
---
utils/exportfs/exportfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
index 9f79541..4331697 100644
--- a/utils/exportfs/exportfs.c
+++ b/utils/exportfs/exportfs.c
@@ -420,7 +420,7 @@ static int test_export(char *path, int with_fsid)
char buf[1024];
int fd, n;

- sprintf(buf, "-test-client- %s 3 %d -1 -1 0\n",
+ sprintf(buf, "-test-client- %s 3 %d 65534 65534 0\n",
path,
with_fsid ? NFSEXP_FSID : 0);
fd = open("/proc/net/rpc/nfsd.export/channel", O_WRONLY);
--
1.7.9.5

2013-09-24 19:24:59

by Steve Dickson

Subject: Re: [PATCH] exportfs: test_export shouldn't use invalid uid/gid

On 19/09/13 15:12, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <[email protected]>
>
> Some newer kernels are rejecting -1 uid/gid. Actually, worse--they're
> silently ignoring any attempt to cache such exports, thus preventing
> test_export from getting back the errors it needs.
>
> And -1 wasn't a good choice anyway.
>
> Signed-off-by: J. Bruce Fields <[email protected]>
Committed...

steved.

> ---
> utils/exportfs/exportfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
> index 9f79541..4331697 100644
> --- a/utils/exportfs/exportfs.c
> +++ b/utils/exportfs/exportfs.c
> @@ -420,7 +420,7 @@ static int test_export(char *path, int with_fsid)
> char buf[1024];
> int fd, n;
>
> - sprintf(buf, "-test-client- %s 3 %d -1 -1 0\n",
> + sprintf(buf, "-test-client- %s 3 %d 65534 65534 0\n",
> path,
> with_fsid ? NFSEXP_FSID : 0);
> fd = open("/proc/net/rpc/nfsd.export/channel", O_WRONLY);
>