2013-10-04 20:38:14

by Mkrtchyan, Tigran

Subject: [PATCH] st_destroy_session: remove invalid testcase

we cant expect NFS4ERR_NOT_ONLY_OP if spec
enforces NFS4ERR_OP_NOT_IN_SESSION

Signed-off-by: Tigran Mkrtchyan <[email protected]>
---
nfs4.1/server41tests/st_destroy_session.py | 3 ---
1 file changed, 3 deletions(-)

diff --git a/nfs4.1/server41tests/st_destroy_session.py b/nfs4.1/server41tests/st_destroy_session.py
index 1feb671..f4f0762 100644
--- a/nfs4.1/server41tests/st_destroy_session.py
+++ b/nfs4.1/server41tests/st_destroy_session.py
@@ -164,6 +164,3 @@ def testDestoryNotSoleOps(t, env):
sid = sess1.sessionid
res = c.c.compound([op.destroy_session(sess1.sessionid), op.putrootfh()])
check(res, NFS4ERR_NOT_ONLY_OP)
-
- res = c.c.compound([op.putrootfh(), op.destroy_session(sess1.sessionid)])
- check(res, NFS4ERR_NOT_ONLY_OP)
--
1.8.3.1

2013-10-07 15:37:57

by J. Bruce Fields

Subject: Re: [PATCH] st_destroy_session: remove invalid testcase

On Fri, Oct 04, 2013 at 10:28:12PM +0200, Tigran Mkrtchyan wrote:
> we cant expect NFS4ERR_NOT_ONLY_OP if spec
> enforces NFS4ERR_OP_NOT_IN_SESSION

I guess we could just add that to the list of allowable error returns,
but... yeah, OK, let's just remove that test. Applied.

--b.

>
> Signed-off-by: Tigran Mkrtchyan <[email protected]>
> ---
> nfs4.1/server41tests/st_destroy_session.py | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/nfs4.1/server41tests/st_destroy_session.py b/nfs4.1/server41tests/st_destroy_session.py
> index 1feb671..f4f0762 100644
> --- a/nfs4.1/server41tests/st_destroy_session.py
> +++ b/nfs4.1/server41tests/st_destroy_session.py
> @@ -164,6 +164,3 @@ def testDestoryNotSoleOps(t, env):
> sid = sess1.sessionid
> res = c.c.compound([op.destroy_session(sess1.sessionid), op.putrootfh()])
> check(res, NFS4ERR_NOT_ONLY_OP)
> -
> - res = c.c.compound([op.putrootfh(), op.destroy_session(sess1.sessionid)])
> - check(res, NFS4ERR_NOT_ONLY_OP)
> --
> 1.8.3.1
>