2013-12-24 02:58:57

by Kinglong Mee

Subject: [PATCH] nfs4.1: check whether old session is discard for EID5f

Signed-off-by: Kinglong Mee <[email protected]>
---
nfs4.1/server41tests/st_exchange_id.py | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/nfs4.1/server41tests/st_exchange_id.py b/nfs4.1/server41tests/st_exchange_id.py
index c31af95..d2c0c97 100644
--- a/nfs4.1/server41tests/st_exchange_id.py
+++ b/nfs4.1/server41tests/st_exchange_id.py
@@ -244,7 +244,12 @@ def testNoUpdate101(t, env):
# Old session state should not be discarded until confirm:
res = sess1.compound([])
check(res)
- # FIXME - more checks here
+
+ # Old session state should be discarded after confirm:
+ sess2 = c2.create_session()
+ check(res)
+ res = sess1.compound([])
+ check(res, NFS4ERR_BADSESSION)

def testNoUpdate101b(t, env):
"""
--
1.8.4.2

2014-01-06 20:42:46

by J. Bruce Fields

Subject: Re: [PATCH] nfs4.1: check whether old session is discard for EID5f

On Tue, Dec 24, 2013 at 10:58:50AM +0800, Kinglong Mee wrote:
>
> Signed-off-by: Kinglong Mee <[email protected]>

Applied and pushed out with the previous pynfs patch; let me know if you
see anything missing in my pynfs repo.

--b.

> ---
> nfs4.1/server41tests/st_exchange_id.py | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/nfs4.1/server41tests/st_exchange_id.py b/nfs4.1/server41tests/st_exchange_id.py
> index c31af95..d2c0c97 100644
> --- a/nfs4.1/server41tests/st_exchange_id.py
> +++ b/nfs4.1/server41tests/st_exchange_id.py
> @@ -244,7 +244,12 @@ def testNoUpdate101(t, env):
> # Old session state should not be discarded until confirm:
> res = sess1.compound([])
> check(res)
> - # FIXME - more checks here
> +
> + # Old session state should be discarded after confirm:
> + sess2 = c2.create_session()
> + check(res)
> + res = sess1.compound([])
> + check(res, NFS4ERR_BADSESSION)
>
> def testNoUpdate101b(t, env):
> """
> --
> 1.8.4.2