2014-04-13 12:56:56

by Kinglong Mee

Subject: [PATCH 1/2] NFSD: Cleanup unused comments and codes in summarize_posix_acl

Signed-off-by: Kinglong Mee <[email protected]>
---
fs/nfsd/nfs4acl.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c
index 6f3f392..de5d66b 100644
--- a/fs/nfsd/nfs4acl.c
+++ b/fs/nfsd/nfs4acl.c
@@ -193,16 +193,9 @@ summarize_posix_acl(struct posix_acl *acl, struct
posix_acl_summary *pas)
{
struct posix_acl_entry *pa, *pe;

- /*
- * Only pas.users and pas.groups need initialization; previous
- * posix_acl_valid() calls ensure that the other fields will be
- * initialized in the following loop. But, just to placate gcc:
- */
memset(pas, 0, sizeof(*pas));
pas->mask = 07;

- pe = acl->a_entries + acl->a_count;
-
FOREACH_ACL_ENTRY(pa, acl, pe) {
switch (pa->e_tag) {
case ACL_USER_OBJ:
--
1.9.0

2014-04-13 13:12:46

by Kinglong Mee

Subject: [PATCH] NFSD: Cleanup unused comments and codes in summarize_posix_acl

Signed-off-by: Kinglong Mee <[email protected]>
---
fs/nfsd/nfs4acl.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c
index 6f3f392..de5d66b 100644
--- a/fs/nfsd/nfs4acl.c
+++ b/fs/nfsd/nfs4acl.c
@@ -193,16 +193,9 @@ summarize_posix_acl(struct posix_acl *acl, struct
posix_acl_summary *pas)
{
struct posix_acl_entry *pa, *pe;

- /*
- * Only pas.users and pas.groups need initialization; previous
- * posix_acl_valid() calls ensure that the other fields will be
- * initialized in the following loop. But, just to placate gcc:
- */
memset(pas, 0, sizeof(*pas));
pas->mask = 07;

- pe = acl->a_entries + acl->a_count;
-
FOREACH_ACL_ENTRY(pa, acl, pe) {
switch (pa->e_tag) {
case ACL_USER_OBJ:
--
1.9.0

2014-05-08 16:55:53

by J. Bruce Fields

Subject: Re: [PATCH] NFSD: Cleanup unused comments and codes in summarize_posix_acl

I'd rather leave the comment there as long as we keep the memset.

I think you're right about the pe initialization, I don't know why
that's there....

--b.

On Sun, Apr 13, 2014 at 09:12:09PM +0800, Kinglong Mee wrote:
> Signed-off-by: Kinglong Mee <[email protected]>
> ---
> fs/nfsd/nfs4acl.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c
> index 6f3f392..de5d66b 100644
> --- a/fs/nfsd/nfs4acl.c
> +++ b/fs/nfsd/nfs4acl.c
> @@ -193,16 +193,9 @@ summarize_posix_acl(struct posix_acl *acl, struct
> posix_acl_summary *pas)
> {
> struct posix_acl_entry *pa, *pe;
>
> - /*
> - * Only pas.users and pas.groups need initialization; previous
> - * posix_acl_valid() calls ensure that the other fields will be
> - * initialized in the following loop. But, just to placate gcc:
> - */
> memset(pas, 0, sizeof(*pas));
> pas->mask = 07;
>
> - pe = acl->a_entries + acl->a_count;
> -
> FOREACH_ACL_ENTRY(pa, acl, pe) {
> switch (pa->e_tag) {
> case ACL_USER_OBJ:
> --
> 1.9.0
>