2014-11-23 17:43:37

by Yann E. MORIN

Subject: [PATCH libtirpc v2] pkg-config: needs pthread as private library

libtirpc needs pthreads. This is automatically pulled in when linking
with the shared library, thanks to the DT_NEEDED ELF tags.

But for a static library, there is no such mechanism to identify
required libraries.

Thus, add -lpthread to the private libraries in the pkg-config file.

Signed-off-by: "Yann E. MORIN" <[email protected]>
Cc: Steve Dickson <[email protected]>

---
Changes v1 -> v2:
- posted publicly in appropriate locations (thanks Steve)
---
libtirpc.pc.in | 1 +
1 file changed, 1 insertion(+)

diff --git a/libtirpc.pc.in b/libtirpc.pc.in
index ec4cf75..38034c5 100644
--- a/libtirpc.pc.in
+++ b/libtirpc.pc.in
@@ -8,4 +8,5 @@ Description: Transport Independent RPC Library
Requires:
Version: @PACKAGE_VERSION@
Libs: -L@libdir@ -ltirpc
+Libs.private: -lpthread
Cflags: -I@includedir@/tirpc
--
1.9.1

2014-11-29 18:15:18

by Yann E. MORIN

Subject: Re: [PATCH libtirpc v2] pkg-config: needs pthread as private library

Hello All,

On 2014-11-23 18:43 +0100, Yann E. MORIN spake thusly:
> libtirpc needs pthreads. This is automatically pulled in when linking
> with the shared library, thanks to the DT_NEEDED ELF tags.
>
> But for a static library, there is no such mechanism to identify
> required libraries.
>
> Thus, add -lpthread to the private libraries in the pkg-config file.

Ping?

Regards,
Yann E. MORIN.

> Signed-off-by: "Yann E. MORIN" <[email protected]>
> Cc: Steve Dickson <[email protected]>
>
> ---
> Changes v1 -> v2:
> - posted publicly in appropriate locations (thanks Steve)
> ---
> libtirpc.pc.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libtirpc.pc.in b/libtirpc.pc.in
> index ec4cf75..38034c5 100644
> --- a/libtirpc.pc.in
> +++ b/libtirpc.pc.in
> @@ -8,4 +8,5 @@ Description: Transport Independent RPC Library
> Requires:
> Version: @PACKAGE_VERSION@
> Libs: -L@libdir@ -ltirpc
> +Libs.private: -lpthread
> Cflags: -I@includedir@/tirpc
> --
> 1.9.1
>

--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'

2014-12-13 14:40:18

by Steve Dickson

Subject: Re: [PATCH libtirpc v2] pkg-config: needs pthread as private library

On 11/23/2014 12:43 PM, Yann E. MORIN wrote:
> libtirpc needs pthreads. This is automatically pulled in when linking
> with the shared library, thanks to the DT_NEEDED ELF tags.
>
> But for a static library, there is no such mechanism to identify
> required libraries.
>
> Thus, add -lpthread to the private libraries in the pkg-config file.
>
> Signed-off-by: "Yann E. MORIN" <[email protected]>
> Cc: Steve Dickson <[email protected]>
Committed...

steved.

>
> ---
> Changes v1 -> v2:
> - posted publicly in appropriate locations (thanks Steve)
> ---
> libtirpc.pc.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libtirpc.pc.in b/libtirpc.pc.in
> index ec4cf75..38034c5 100644
> --- a/libtirpc.pc.in
> +++ b/libtirpc.pc.in
> @@ -8,4 +8,5 @@ Description: Transport Independent RPC Library
> Requires:
> Version: @PACKAGE_VERSION@
> Libs: -L@libdir@ -ltirpc
> +Libs.private: -lpthread
> Cflags: -I@includedir@/tirpc
>