2016-07-02 06:25:07

by Christophe JAILLET

Subject: [PATCH 2/2] nfsd: remove extraneous KERN_INFO prefix

smatch complains about using KERN_INFO as a prefix when calling dprintk

Signed-off-by: Christophe JAILLET <[email protected]>
---
fs/nfsd/nfs4state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index bc2173a..ba6b2df 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2226,7 +2226,7 @@ gen_callback(struct nfs4_client *clp, struct nfsd4_setclientid *se, struct svc_r
out_err:
conn->cb_addr.ss_family = AF_UNSPEC;
conn->cb_addrlen = 0;
- dprintk(KERN_INFO "NFSD: this client (clientid %08x/%08x) "
+ dprintk("NFSD: this client (clientid %08x/%08x) "
"will not receive delegations\n",
clp->cl_clientid.cl_boot, clp->cl_clientid.cl_id);

--
2.7.4

2016-07-06 13:52:26

by J. Bruce Fields

Subject: Re: [PATCH 2/2] nfsd: remove extraneous KERN_INFO prefix

Thanks, applying both patches.--b.

On Sat, Jul 02, 2016 at 08:24:48AM +0200, Christophe JAILLET wrote:
> smatch complains about using KERN_INFO as a prefix when calling dprintk
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> fs/nfsd/nfs4state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index bc2173a..ba6b2df 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -2226,7 +2226,7 @@ gen_callback(struct nfs4_client *clp, struct nfsd4_setclientid *se, struct svc_r
> out_err:
> conn->cb_addr.ss_family = AF_UNSPEC;
> conn->cb_addrlen = 0;
> - dprintk(KERN_INFO "NFSD: this client (clientid %08x/%08x) "
> + dprintk("NFSD: this client (clientid %08x/%08x) "
> "will not receive delegations\n",
> clp->cl_clientid.cl_boot, clp->cl_clientid.cl_id);
>
> --
> 2.7.4