2016-09-22 11:19:04

by Jeff Layton

Subject: [PATCH] nfsd: fix dprintk in nfsd4_encode_getdeviceinfo

nfserr is big-endian, so we should convert it to host-endian before
printing it.

Signed-off-by: Jeff Layton <[email protected]>
---
fs/nfsd/nfs4xdr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 0aa0236a1429..7f8232e32dc7 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -4062,7 +4062,7 @@ nfsd4_encode_getdeviceinfo(struct nfsd4_compoundres *resp, __be32 nfserr,
u32 starting_len = xdr->buf->len, needed_len;
__be32 *p;

- dprintk("%s: err %d\n", __func__, nfserr);
+ dprintk("%s: err %d\n", __func__, be32_to_cpu(nfserr));
if (nfserr)
goto out;

--
2.7.4

2016-09-22 16:12:37

by J. Bruce Fields

Subject: Re: [PATCH] nfsd: fix dprintk in nfsd4_encode_getdeviceinfo

On Thu, Sep 22, 2016 at 07:19:02AM -0400, Jeff Layton wrote:
> nfserr is big-endian, so we should convert it to host-endian before
> printing it.

Thanks, applying.--b.

>
> Signed-off-by: Jeff Layton <[email protected]>
> ---
> fs/nfsd/nfs4xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 0aa0236a1429..7f8232e32dc7 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -4062,7 +4062,7 @@ nfsd4_encode_getdeviceinfo(struct nfsd4_compoundres *resp, __be32 nfserr,
> u32 starting_len = xdr->buf->len, needed_len;
> __be32 *p;
>
> - dprintk("%s: err %d\n", __func__, nfserr);
> + dprintk("%s: err %d\n", __func__, be32_to_cpu(nfserr));
> if (nfserr)
> goto out;
>
> --
> 2.7.4