2016-12-31 13:00:27

by Kinglong Mee

Subject: [PATCH 3/3 v2] NFSD: Remove unused value inode in nfsd_vfs_write

Signed-off-by: Kinglong Mee <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
---
fs/nfsd/vfs.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index d1d4a11..2c13216 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -943,7 +943,6 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
unsigned long *cnt, int stable)
{
struct svc_export *exp;
- struct inode *inode;
mm_segment_t oldfs;
__be32 err = 0;
int host_err;
@@ -961,9 +960,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
*/
current->flags |= PF_LESS_THROTTLE;

- inode = file_inode(file);
- exp = fhp->fh_export;
-
+ exp = fhp->fh_export;
use_wgather = (rqstp->rq_vers == 2) && EX_WGATHER(exp);

if (!EX_ISSYNC(exp))
--
2.9.3

2017-01-04 17:47:02

by J. Bruce Fields

Subject: Re: [PATCH 3/3 v2] NFSD: Remove unused value inode in nfsd_vfs_write

These three look fine, thanks.--b.

On Sat, Dec 31, 2016 at 09:00:21PM +0800, Kinglong Mee wrote:
> Signed-off-by: Kinglong Mee <[email protected]>
> Reviewed-by: Christoph Hellwig <[email protected]>
> ---
> fs/nfsd/vfs.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index d1d4a11..2c13216 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -943,7 +943,6 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
> unsigned long *cnt, int stable)
> {
> struct svc_export *exp;
> - struct inode *inode;
> mm_segment_t oldfs;
> __be32 err = 0;
> int host_err;
> @@ -961,9 +960,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
> */
> current->flags |= PF_LESS_THROTTLE;
>
> - inode = file_inode(file);
> - exp = fhp->fh_export;
> -
> + exp = fhp->fh_export;
> use_wgather = (rqstp->rq_vers == 2) && EX_WGATHER(exp);
>
> if (!EX_ISSYNC(exp))
> --
> 2.9.3