2017-04-25 18:10:53

by Fabian Frédérick

Subject: [PATCH 1/1 linux-next] nfs: kmap can't fail

Remove NULL test on kmap()

Signed-off-by: Fabian Frederick <[email protected]>
---
fs/nfs/dir.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 3a188cb..f89e54c 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -179,8 +179,6 @@ struct nfs_cache_array *nfs_readdir_get_array(struct page *page)
if (page == NULL)
return ERR_PTR(-EIO);
ptr = kmap(page);
- if (ptr == NULL)
- return ERR_PTR(-ENOMEM);
return ptr;
}

--
2.9.3

2017-04-25 20:37:15

by Anna Schumaker

Subject: Re: [PATCH 1/1 linux-next] nfs: kmap can't fail

Hi Fabian,

On 04/25/2017 02:10 PM, Fabian Frederick wrote:
> Remove NULL test on kmap()
>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> fs/nfs/dir.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index 3a188cb..f89e54c 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -179,8 +179,6 @@ struct nfs_cache_array *nfs_readdir_get_array(struct page *page)
> if (page == NULL)
> return ERR_PTR(-EIO);
> ptr = kmap(page);
> - if (ptr == NULL)
> - return ERR_PTR(-ENOMEM);> return ptr;

While you're at it, can you remove the ptr variable entirely and change the code to "return kmap(page)" instead?

Thanks,
Anna

> }
>
>