2017-05-16 16:00:20

by Olga Kornievskaia

Subject: [PATCH 1/1] NFS fix COMMIT after COPY

Fix a typo in the commit e092693443b995c8e3a565a73b5fdb05f1260f9b
"NFS append COMMIT after synchronous COPY"

Reported-by: Eryu Guan <[email protected]>
Fixes: e092693443b ("NFS append COMMIT after synchronous COPY")
Signed-off-by: Olga Kornievskaia <[email protected]>
---
fs/nfs/nfs42proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/nfs42proc.c b/fs/nfs/nfs42proc.c
index 929d09a..319a47d 100644
--- a/fs/nfs/nfs42proc.c
+++ b/fs/nfs/nfs42proc.c
@@ -177,7 +177,7 @@ static ssize_t _nfs42_proc_copy(struct file *src,
if (status)
goto out;

- if (!nfs_write_verifier_cmp(&res->write_res.verifier.verifier,
+ if (nfs_write_verifier_cmp(&res->write_res.verifier.verifier,
&res->commit_res.verf->verifier)) {
status = -EAGAIN;
goto out;
--
1.8.3.1

2017-05-17 12:47:13

by Eryu Guan

Subject: Re: [PATCH 1/1] NFS fix COMMIT after COPY

On Tue, May 16, 2017 at 12:00:15PM -0400, Olga Kornievskaia wrote:
> Fix a typo in the commit e092693443b995c8e3a565a73b5fdb05f1260f9b
> "NFS append COMMIT after synchronous COPY"
>
> Reported-by: Eryu Guan <[email protected]>
> Fixes: e092693443b ("NFS append COMMIT after synchronous COPY")
> Signed-off-by: Olga Kornievskaia <[email protected]>

Thanks! This did fix the hang for me.

Tested-by: Eryu Guan <[email protected]>

> ---
> fs/nfs/nfs42proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/nfs42proc.c b/fs/nfs/nfs42proc.c
> index 929d09a..319a47d 100644
> --- a/fs/nfs/nfs42proc.c
> +++ b/fs/nfs/nfs42proc.c
> @@ -177,7 +177,7 @@ static ssize_t _nfs42_proc_copy(struct file *src,
> if (status)
> goto out;
>
> - if (!nfs_write_verifier_cmp(&res->write_res.verifier.verifier,
> + if (nfs_write_verifier_cmp(&res->write_res.verifier.verifier,
> &res->commit_res.verf->verifier)) {
> status = -EAGAIN;
> goto out;
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html