2017-07-18 05:33:32

by Eryu Guan

[permalink] [raw]
Subject: [PATCH] nfs: count correct array for mnt3_counts array size

Array size of mnt3_counts should be the size of array
mnt3_procedures, not mnt_procedures, though they're same in size
right now. Found this by code inspection.

Fixes: 1c5876ddbdb4 ("sunrpc: move p_count out of struct rpc_procinfo")
Cc: Christoph Hellwig <[email protected]>
Signed-off-by: Eryu Guan <[email protected]>
---
fs/nfs/mount_clnt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/mount_clnt.c b/fs/nfs/mount_clnt.c
index 3efe946672be..60bad882c123 100644
--- a/fs/nfs/mount_clnt.c
+++ b/fs/nfs/mount_clnt.c
@@ -512,7 +512,7 @@ static const struct rpc_version mnt_version1 = {
.counts = mnt_counts,
};

-static unsigned int mnt3_counts[ARRAY_SIZE(mnt_procedures)];
+static unsigned int mnt3_counts[ARRAY_SIZE(mnt3_procedures)];
static const struct rpc_version mnt_version3 = {
.number = 3,
.nrprocs = ARRAY_SIZE(mnt3_procedures),
--
2.13.3



2017-07-18 09:08:54

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH] nfs: count correct array for mnt3_counts array size

On Tue, Jul 18, 2017 at 01:32:32PM +0800, Eryu Guan wrote:
> Array size of mnt3_counts should be the size of array
> mnt3_procedures, not mnt_procedures, though they're same in size
> right now. Found this by code inspection.
>
> Fixes: 1c5876ddbdb4 ("sunrpc: move p_count out of struct rpc_procinfo")
> Cc: Christoph Hellwig <[email protected]>
> Signed-off-by: Eryu Guan <[email protected]>

Oops, yes.

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>

2017-07-18 16:04:45

by J. Bruce Fields

[permalink] [raw]
Subject: Re: [PATCH] nfs: count correct array for mnt3_counts array size

On Tue, Jul 18, 2017 at 11:08:53AM +0200, Christoph Hellwig wrote:
> On Tue, Jul 18, 2017 at 01:32:32PM +0800, Eryu Guan wrote:
> > Array size of mnt3_counts should be the size of array
> > mnt3_procedures, not mnt_procedures, though they're same in size
> > right now. Found this by code inspection.
> >
> > Fixes: 1c5876ddbdb4 ("sunrpc: move p_count out of struct rpc_procinfo")
> > Cc: Christoph Hellwig <[email protected]>
> > Signed-off-by: Eryu Guan <[email protected]>
>
> Oops, yes.
>
> Looks good:
>
> Reviewed-by: Christoph Hellwig <[email protected]>

Thanks, I'm assuming Anna gets this.

--b.

2017-07-18 17:31:48

by Anna Schumaker

[permalink] [raw]
Subject: Re: [PATCH] nfs: count correct array for mnt3_counts array size



On 07/18/2017 12:04 PM, J. Bruce Fields wrote:
> On Tue, Jul 18, 2017 at 11:08:53AM +0200, Christoph Hellwig wrote:
>> On Tue, Jul 18, 2017 at 01:32:32PM +0800, Eryu Guan wrote:
>>> Array size of mnt3_counts should be the size of array
>>> mnt3_procedures, not mnt_procedures, though they're same in size
>>> right now. Found this by code inspection.
>>>
>>> Fixes: 1c5876ddbdb4 ("sunrpc: move p_count out of struct rpc_procinfo")
>>> Cc: Christoph Hellwig <[email protected]>
>>> Signed-off-by: Eryu Guan <[email protected]>
>>
>> Oops, yes.
>>
>> Looks good:
>>
>> Reviewed-by: Christoph Hellwig <[email protected]>
>
> Thanks, I'm assuming Anna gets this.

Yep, I'll take it.

>
> --b.
>