2017-11-01 12:09:21

by Andrew W Elble

[permalink] [raw]
Subject: [PATCH] 4.1 server tests: make DELEG8 also check that an operation using a revoked stateid returns revoked status

Signed-off-by: Andrew Elble <[email protected]>
---
nfs4.1/server41tests/st_delegation.py | 2 ++
1 file changed, 2 insertions(+)

diff --git a/nfs4.1/server41tests/st_delegation.py b/nfs4.1/server41tests/st_delegation.py
index a5066926a89d..c5959f6cda84 100644
--- a/nfs4.1/server41tests/st_delegation.py
+++ b/nfs4.1/server41tests/st_delegation.py
@@ -186,6 +186,8 @@ def testDelegRevocation(t, env):
# depend on the above compound waiting no longer than the
# server's lease period:
res = sess1.compound([])
+ res = sess1.compound([op.putfh(fh), op.read(delegstateid, 0, 1000)])
+ check(res, NFS4ERR_DELEG_REVOKED, "Read with a revoked delegation")
slot, seq_op = sess1._prepare_compound({})
res = sess1.c.compound([seq_op])
flags = res.resarray[0].sr_status_flags;
--
2.10.1



2017-11-09 14:13:30

by J. Bruce Fields

[permalink] [raw]
Subject: Re: [PATCH] 4.1 server tests: make DELEG8 also check that an operation using a revoked stateid returns revoked status

Applied, thanks.--b.

On Wed, Nov 01, 2017 at 08:08:55AM -0400, Andrew Elble wrote:
> Signed-off-by: Andrew Elble <[email protected]>
> ---
> nfs4.1/server41tests/st_delegation.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/nfs4.1/server41tests/st_delegation.py b/nfs4.1/server41tests/st_delegation.py
> index a5066926a89d..c5959f6cda84 100644
> --- a/nfs4.1/server41tests/st_delegation.py
> +++ b/nfs4.1/server41tests/st_delegation.py
> @@ -186,6 +186,8 @@ def testDelegRevocation(t, env):
> # depend on the above compound waiting no longer than the
> # server's lease period:
> res = sess1.compound([])
> + res = sess1.compound([op.putfh(fh), op.read(delegstateid, 0, 1000)])
> + check(res, NFS4ERR_DELEG_REVOKED, "Read with a revoked delegation")
> slot, seq_op = sess1._prepare_compound({})
> res = sess1.c.compound([seq_op])
> flags = res.resarray[0].sr_status_flags;
> --
> 2.10.1