2018-03-29 16:46:23

by J. Bruce Fields

[permalink] [raw]
Subject: Re: [pynfs] [PATCH 3/3] Fix DELEG21 to have CODE:

Uh, I think I didn't actually mean to commit that test at all. Oh well,
I'll take this and then go see if I can find what else I had to patch to
make it work.

I realized after writing this that the existing tests all *require* that
clients' operations conflict with their own delegations. So at some
point those tests need fixing too, but for now they're useful tests of
my patches--when they start failing I know I've got something right.

--b.

On Wed, Mar 28, 2018 at 04:07:27PM -0700, Frank Filz wrote:
> Signed-off-by: Frank S. Filz <[email protected]>
>
> ---
>
> nfs4.0/servertests/st_delegation.py | 2 +-
>
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
>
> diff --git a/nfs4.0/servertests/st_delegation.py
> b/nfs4.0/servertests/st_delegation.py
>
> index e204e50..1d69fb5 100644
>
> --- a/nfs4.0/servertests/st_delegation.py
>
> +++ b/nfs4.0/servertests/st_delegation.py
>
> @@ -714,7 +714,7 @@ def testServerSelfConflict(t, env):
>
> It should not conflict with the read delegation.
>
> FLAGS: delegations
>
> - DELEG21
>
> + CODE: DELEG21
>
> """
>
> c = env.c1
>
> count = c.cb_server.opcounts[OP_CB_RECALL]
>
> --
>
> 2.5.5
>
>
>
>
>
>
>