2018-05-14 17:20:09

by Chuck Lever III

Subject: [PATCH] svcrdma: Fix incorrect return value/type in svc_rdma_post_recvs

This crept in during the development process and wasn't caught
before I posted the "final" version.

Reported-by: Dan Carpenter <[email protected]>
Fixes: 0b2613c5883f ('svcrdma: Allocate recv_ctxt's on CPU ... ')
Signed-off-by: Chuck Lever <[email protected]>
---
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
index 09ce09b..841fca1 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
@@ -270,7 +270,7 @@ bool svc_rdma_post_recvs(struct svcxprt_rdma *rdma)
for (i = 0; i < rdma->sc_max_requests; i++) {
ctxt = svc_rdma_recv_ctxt_get(rdma);
if (!ctxt)
- return -ENOMEM;
+ return false;
ctxt->rc_temp = true;
ret = __svc_rdma_post_recv(rdma, ctxt);
if (ret) {

2018-05-16 18:15:24

by J. Bruce Fields

Subject: Re: [PATCH] svcrdma: Fix incorrect return value/type in svc_rdma_post_recvs

Thanks!

--b.

On Mon, May 14, 2018 at 01:20:06PM -0400, Chuck Lever wrote:
> This crept in during the development process and wasn't caught
> before I posted the "final" version.
>
> Reported-by: Dan Carpenter <[email protected]>
> Fixes: 0b2613c5883f ('svcrdma: Allocate recv_ctxt's on CPU ... ')
> Signed-off-by: Chuck Lever <[email protected]>
> ---
> net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> index 09ce09b..841fca1 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> @@ -270,7 +270,7 @@ bool svc_rdma_post_recvs(struct svcxprt_rdma *rdma)
> for (i = 0; i < rdma->sc_max_requests; i++) {
> ctxt = svc_rdma_recv_ctxt_get(rdma);
> if (!ctxt)
> - return -ENOMEM;
> + return false;
> ctxt->rc_temp = true;
> ret = __svc_rdma_post_recv(rdma, ctxt);
> if (ret) {