2018-10-05 21:27:26

by Trond Myklebust

Subject: [PATCH] NFS: Fix up a typo in nfs_dns_ent_put

call_rcu() needs to take a first argument of type (struct rcu_head *).

Fixes: fd497f1e40d9 ("NFS: Lockless DNS lookups")
Signed-off-by: Trond Myklebust <[email protected]>
---
- Apologies for the screwup

fs/nfs/dns_resolve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/dns_resolve.c b/fs/nfs/dns_resolve.c
index e93a5dc07c8c..a7d3df85736d 100644
--- a/fs/nfs/dns_resolve.c
+++ b/fs/nfs/dns_resolve.c
@@ -116,7 +116,7 @@ static void nfs_dns_ent_put(struct kref *ref)
struct nfs_dns_ent *item;

item = container_of(ref, struct nfs_dns_ent, h.ref);
- call_rcu(item, nfs_dns_ent_free_rcu);
+ call_rcu(&item->rcu_head, nfs_dns_ent_free_rcu);
}

static struct cache_head *nfs_dns_ent_alloc(void)
--
2.17.1

2018-10-08 21:35:33

by J. Bruce Fields

Subject: Re: [PATCH] NFS: Fix up a typo in nfs_dns_ent_put

On Fri, Oct 05, 2018 at 10:27:20AM -0400, Trond Myklebust wrote:
> call_rcu() needs to take a first argument of type (struct rcu_head *).
>
> Fixes: fd497f1e40d9 ("NFS: Lockless DNS lookups")
> Signed-off-by: Trond Myklebust <[email protected]>

Thanks! Applying.--b.

> ---
> - Apologies for the screwup
>
> fs/nfs/dns_resolve.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/dns_resolve.c b/fs/nfs/dns_resolve.c
> index e93a5dc07c8c..a7d3df85736d 100644
> --- a/fs/nfs/dns_resolve.c
> +++ b/fs/nfs/dns_resolve.c
> @@ -116,7 +116,7 @@ static void nfs_dns_ent_put(struct kref *ref)
> struct nfs_dns_ent *item;
>
> item = container_of(ref, struct nfs_dns_ent, h.ref);
> - call_rcu(item, nfs_dns_ent_free_rcu);
> + call_rcu(&item->rcu_head, nfs_dns_ent_free_rcu);
> }
>
> static struct cache_head *nfs_dns_ent_alloc(void)
> --
> 2.17.1