2019-01-09 16:38:42

by Santosh Kumar Pradhan

Subject: [PATCH] sunrpc: kernel BUG at kernel/cred.c:825!

Init missing debug member magic with CRED_MAGIC.

Signed-off-by: Santosh kumar pradhan <[email protected]>
Reported-by: Dave Jones <[email protected]>
---
net/sunrpc/auth.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
index 1ff9768f5456..f3023bbc0b7f 100644
--- a/net/sunrpc/auth.c
+++ b/net/sunrpc/auth.c
@@ -41,6 +41,9 @@ static unsigned long number_cred_unused;

static struct cred machine_cred = {
.usage = ATOMIC_INIT(1),
+#ifdef CONFIG_DEBUG_CREDENTIALS
+ .magic = CRED_MAGIC,
+#endif
};

/*
--
2.20.1

2019-01-10 15:53:34

by Anna Schumaker

Subject: Re: [PATCH] sunrpc: kernel BUG at kernel/cred.c:825!

On Wed, 2019-01-09 at 22:08 +0530, Santosh kumar pradhan wrote:
> Init missing debug member magic with CRED_MAGIC.
>
> Signed-off-by: Santosh kumar pradhan <[email protected]>
> Reported-by: Dave Jones <[email protected]>

This patch looks good to me, thanks!

Anna

> ---
> net/sunrpc/auth.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
> index 1ff9768f5456..f3023bbc0b7f 100644
> --- a/net/sunrpc/auth.c
> +++ b/net/sunrpc/auth.c
> @@ -41,6 +41,9 @@ static unsigned long number_cred_unused;
>
> static struct cred machine_cred = {
> .usage = ATOMIC_INIT(1),
> +#ifdef CONFIG_DEBUG_CREDENTIALS
> + .magic = CRED_MAGIC,
> +#endif
> };
>
> /*
> --
> 2.20.1
>