2020-02-12 22:32:43

by Olga Kornievskaia

Subject: [PATCH 1/1] NFSv4.1 make cachethis=no for writes

From: Olga Kornievskaia <[email protected]>

Turning caching off for writes on the server should improve performance.

Signed-off-by: Olga Kornievskaia <[email protected]>
---
fs/nfs/nfs4proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 7f5802b..22dca49 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -5336,7 +5336,7 @@ static void nfs4_proc_write_setup(struct nfs_pgio_header *hdr,
hdr->timestamp = jiffies;

msg->rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_WRITE];
- nfs4_init_sequence(&hdr->args.seq_args, &hdr->res.seq_res, 1, 0);
+ nfs4_init_sequence(&hdr->args.seq_args, &hdr->res.seq_res, 0, 0);
nfs4_state_protect_write(server->nfs_client, clnt, msg, hdr);
}

--
1.8.3.1

2020-02-13 01:20:49

by Trond Myklebust

Subject: Re: [PATCH 1/1] NFSv4.1 make cachethis=no for writes

On Wed, 2020-02-12 at 17:32 -0500, Olga Kornievskaia wrote:
> From: Olga Kornievskaia <[email protected]>
>
> Turning caching off for writes on the server should improve
> performance.
>
> Signed-off-by: Olga Kornievskaia <[email protected]>
> ---
> fs/nfs/nfs4proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 7f5802b..22dca49 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -5336,7 +5336,7 @@ static void nfs4_proc_write_setup(struct
> nfs_pgio_header *hdr,
> hdr->timestamp = jiffies;
>
> msg->rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_WRITE];
> - nfs4_init_sequence(&hdr->args.seq_args, &hdr->res.seq_res, 1,
> 0);
> + nfs4_init_sequence(&hdr->args.seq_args, &hdr->res.seq_res, 0,
> 0);
> nfs4_state_protect_write(server->nfs_client, clnt, msg, hdr);
> }
>

Reviewed-by: Trond Myklebust <[email protected]>


Anna, we can probably also add a

Fixes: fba83f34119a ("NFS: Pass "privileged" value to nfs4_init_sequence()")

--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
[email protected]