2020-06-05 14:49:38

by Rohan Sable

Subject: [PATCH v3] mountstats: Adding 'Day, Hour:Min:Sec' to "mountstats --nfs" for ease of understanding.

This patch adds printing of 'Days, Hours:Mins:Sec' like below to --nfs in mountstats :
NFS mount age : 12 days, 23:59:59

Signed-off-by: Rohan Sable <[email protected]>
---
tools/mountstats/mountstats.py | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
index d565385d..014f38a3 100755
--- a/tools/mountstats/mountstats.py
+++ b/tools/mountstats/mountstats.py
@@ -4,6 +4,7 @@
"""

from __future__ import print_function
+import datetime as datetime

__copyright__ = """
Copyright (C) 2005, Chuck Lever <[email protected]>
@@ -391,6 +392,7 @@ class DeviceData:
"""Pretty-print the NFS options
"""
print(' NFS mount options: %s' % ','.join(self.__nfs_data['mountoptions']))
+ print(' NFS mount age: %s' % datetime.timedelta(seconds = self.__nfs_data['age']))
print(' NFS server capabilities: %s' % ','.join(self.__nfs_data['servercapabilities']))
if 'nfsv4flags' in self.__nfs_data:
print(' NFSv4 capability flags: %s' % ','.join(self.__nfs_data['nfsv4flags']))
--
2.25.4

2020-06-18 17:10:34

by Steve Dickson

Subject: Re: [PATCH v3] mountstats: Adding 'Day, Hour:Min:Sec' to "mountstats --nfs" for ease of understanding.

On 6/5/20 10:48 AM, Rohan Sable wrote:
> This patch adds printing of 'Days, Hours:Mins:Sec' like below to --nfs in mountstats :
> NFS mount age : 12 days, 23:59:59
>
> Signed-off-by: Rohan Sable <[email protected]>
Committed....

steved.
> ---
> tools/mountstats/mountstats.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
> index d565385d..014f38a3 100755
> --- a/tools/mountstats/mountstats.py
> +++ b/tools/mountstats/mountstats.py
> @@ -4,6 +4,7 @@
> """
>
> from __future__ import print_function
> +import datetime as datetime
>
> __copyright__ = """
> Copyright (C) 2005, Chuck Lever <[email protected]>
> @@ -391,6 +392,7 @@ class DeviceData:
> """Pretty-print the NFS options
> """
> print(' NFS mount options: %s' % ','.join(self.__nfs_data['mountoptions']))
> + print(' NFS mount age: %s' % datetime.timedelta(seconds = self.__nfs_data['age']))
> print(' NFS server capabilities: %s' % ','.join(self.__nfs_data['servercapabilities']))
> if 'nfsv4flags' in self.__nfs_data:
> print(' NFSv4 capability flags: %s' % ','.join(self.__nfs_data['nfsv4flags']))
>