2020-08-12 14:13:45

by Alex Dewar

Subject: [PATCH 2/2] nfsd: Fix typo in comment

Fix typos in nfs4xdr.c.

Signed-off-by: Alex Dewar <[email protected]>
---
fs/nfsd/nfs4xdr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 1a0341fd80f9a..3db789139a71f 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -4828,7 +4828,7 @@ nfsd4_encode_listxattrs(struct nfsd4_compoundres *resp, __be32 nfserr,
slen = strlen(sp);

/*
- * Check if this a user. attribute, skip it if not.
+ * Check if this is a user attribute, skip it if not.
*/
if (strncmp(sp, XATTR_USER_PREFIX, XATTR_USER_PREFIX_LEN))
goto contloop;
--
2.28.0

2020-08-12 20:38:55

by Frank van der Linden

Subject: Re: [PATCH 2/2] nfsd: Fix typo in comment

On Wed, Aug 12, 2020 at 03:12:52PM +0100, Alex Dewar wrote:
>
> Fix typos in nfs4xdr.c.
>
> Signed-off-by: Alex Dewar <[email protected]>
> ---
> fs/nfsd/nfs4xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 1a0341fd80f9a..3db789139a71f 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -4828,7 +4828,7 @@ nfsd4_encode_listxattrs(struct nfsd4_compoundres *resp, __be32 nfserr,
> slen = strlen(sp);
>
> /*
> - * Check if this a user. attribute, skip it if not.
> + * Check if this is a user attribute, skip it if not.
> */
> if (strncmp(sp, XATTR_USER_PREFIX, XATTR_USER_PREFIX_LEN))
> goto contloop;
> --
> 2.28.0
>

"this a" should indeed by "this is a", but "user." is not a typo - it is
talking about checking the prefix of the extended attribute, which is
"user.", so the "." is intended to be there.

Thanks,

- Frank