2021-11-16 09:56:54

by An Long

[permalink] [raw]
Subject: [PATCH 1/2] README: Fix typo of install guide

Signed-off-by: An Long <[email protected]>
---
README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README b/README
index fe2eae3..b8b4e77 100644
--- a/README
+++ b/README
@@ -12,7 +12,7 @@ Install dependent modules:
yum install krb5-devel python3-devel swig python3-gssapi python3-ply

* openSUSE
- zypper in install krb5-devel python3-devel swig python3-gssapi python3-ply
+ zypper install krb5-devel python3-devel swig python3-gssapi python3-ply

You can prepare both for use with
./setup.py build
--
2.31.1



2021-11-16 09:57:14

by An Long

[permalink] [raw]
Subject: [PATCH 2/2] server: Fix t.time_taken type for xml_printresults

t.time_taken does replace in _write_data, but 'float' object has no attribute 'replace'

Signed-off-by: An Long <[email protected]>
---
nfs4.1/testmod.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nfs4.1/testmod.py b/nfs4.1/testmod.py
index 47016dd..11e759d 100644
--- a/nfs4.1/testmod.py
+++ b/nfs4.1/testmod.py
@@ -524,7 +524,7 @@ def xml_printresults(tests, file_name, suite='all'):
testcase.setAttribute("code", t.code)
testcase.setAttribute("name", t.name)
testcase.setAttribute("classname", t.suite)
- testcase.setAttribute("time", t.time_taken)
+ testcase.setAttribute("time", str(t.time_taken))

total_time += t.time_taken
if t.result == TEST_FAIL:
--
2.31.1


2021-11-16 14:54:01

by J. Bruce Fields

[permalink] [raw]
Subject: Re: [PATCH 1/2] README: Fix typo of install guide

Thanks, both applied.--b.

On Tue, Nov 16, 2021 at 05:56:31PM +0800, An Long wrote:
> Signed-off-by: An Long <[email protected]>
> ---
> README | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/README b/README
> index fe2eae3..b8b4e77 100644
> --- a/README
> +++ b/README
> @@ -12,7 +12,7 @@ Install dependent modules:
> yum install krb5-devel python3-devel swig python3-gssapi python3-ply
>
> * openSUSE
> - zypper in install krb5-devel python3-devel swig python3-gssapi python3-ply
> + zypper install krb5-devel python3-devel swig python3-gssapi python3-ply
>
> You can prepare both for use with
> ./setup.py build
> --
> 2.31.1