2023-01-04 17:18:28

by Steve Dickson

Subject: [PATCH 2/2] Covscan Scan: Fixed a couple CLANG_WARNINGs

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2151971
Signed-off-by: Steve Dickson <[email protected]>
---
tools/nfsrahead/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/nfsrahead/main.c b/tools/nfsrahead/main.c
index c83c6f7..8a11cf1 100644
--- a/tools/nfsrahead/main.c
+++ b/tools/nfsrahead/main.c
@@ -167,7 +167,7 @@ int main(int argc, char **argv)
if ((ret = get_device_info(argv[optind], &device)) == 0)
break;

- if (ret != 0) {
+ if (ret != 0 || device.fstype == NULL) {
xlog(D_GENERAL, "unable to find device %s\n", argv[optind]);
goto out;
}
--
2.38.1

2023-01-11 16:04:03

by Steve Dickson

Subject: Re: [PATCH 2/2] Covscan Scan: Fixed a couple CLANG_WARNINGs

On 1/4/23 12:08 PM, Steve Dickson wrote:
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2151971
> Signed-off-by: Steve Dickson <[email protected]>
Committed... (tag: nfs-utils-2-6-3-rc6)

steved.
> ---
> tools/nfsrahead/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/nfsrahead/main.c b/tools/nfsrahead/main.c
> index c83c6f7..8a11cf1 100644
> --- a/tools/nfsrahead/main.c
> +++ b/tools/nfsrahead/main.c
> @@ -167,7 +167,7 @@ int main(int argc, char **argv)
> if ((ret = get_device_info(argv[optind], &device)) == 0)
> break;
>
> - if (ret != 0) {
> + if (ret != 0 || device.fstype == NULL) {
> xlog(D_GENERAL, "unable to find device %s\n", argv[optind]);
> goto out;
> }