2024-01-11 13:23:11

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH] keys, dns: Fix size check of V1 server-list header

On Wed, Jan 10, 2024 at 09:11:40PM +0000, David Howells wrote:
>
> Fix the size check added to dns_resolver_preparse() for the V1 server-list
> header so that it doesn't give EINVAL if the size supplied is the same as
> the size of the header struct (which should be valid).
>
> This can be tested with:
>
> echo -n -e '\0\0\01\xff\0\0' | keyctl padd dns_resolver desc @p
>
> which will give "add_key: Invalid argument" without this fix.
>
> Fixes: 1997b3cb4217 ("keys, dns: Fix missing size check of V1 server-list header")
> Reported-by: Pengfei Xu <[email protected]>
> Link: https://lore.kernel.org/r/[email protected]/
> Signed-off-by: David Howells <[email protected]>

Reviewed-by: Simon Horman <[email protected]>