2024-04-04 21:49:19

by kernel test robot

[permalink] [raw]
Subject: [trondmy-nfs:testing 31/31] fs/nfs/inode.c:2434:13: warning: assignment to 'int' from 'struct proc_dir_entry *' makes integer from pointer without a cast

tree: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git testing
head: f290a586e31f8965387dde660729c716a3af9b6c
commit: f290a586e31f8965387dde660729c716a3af9b6c [31/31] nfs: Handle error of rpc_proc_register() in nfs_net_init().
config: arc-defconfig (https://download.01.org/0day-ci/archive/20240405/[email protected]/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240405/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

fs/nfs/inode.c: In function 'nfs_net_init':
>> fs/nfs/inode.c:2434:13: warning: assignment to 'int' from 'struct proc_dir_entry *' makes integer from pointer without a cast [-Wint-conversion]
2434 | err = rpc_proc_register(net, &nn->rpcstats);
| ^


vim +2434 fs/nfs/inode.c

2426
2427 static int nfs_net_init(struct net *net)
2428 {
2429 struct nfs_net *nn = net_generic(net, nfs_net_id);
2430 int err;
2431
2432 nfs_clients_init(net);
2433
> 2434 err = rpc_proc_register(net, &nn->rpcstats);
2435 if (err) {
2436 nfs_clients_exit(net);
2437 return err;
2438 }
2439
2440 return nfs_fs_proc_net_init(net);
2441 }
2442

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


2024-04-04 22:02:29

by Kuniyuki Iwashima

[permalink] [raw]
Subject: Re: [trondmy-nfs:testing 31/31] fs/nfs/inode.c:2434:13: warning: assignment to 'int' from 'struct proc_dir_entry *' makes integer from pointer without a cast

From: kernel test robot <[email protected]>
Date: Fri, 5 Apr 2024 05:48:13 +0800
> tree: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git testing
> head: f290a586e31f8965387dde660729c716a3af9b6c
> commit: f290a586e31f8965387dde660729c716a3af9b6c [31/31] nfs: Handle error of rpc_proc_register() in nfs_net_init().
> config: arc-defconfig (https://download.01.org/0day-ci/archive/20240405/[email protected]/config)
> compiler: arc-elf-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240405/[email protected]/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <[email protected]>
> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
>
> All warnings (new ones prefixed by >>):
>
> fs/nfs/inode.c: In function 'nfs_net_init':
> >> fs/nfs/inode.c:2434:13: warning: assignment to 'int' from 'struct proc_dir_entry *' makes integer from pointer without a cast [-Wint-conversion]
> 2434 | err = rpc_proc_register(net, &nn->rpcstats);
> | ^

Ugh... sorry I forgot to turn on RPC after defconfig...

I'll post v2 soon.

Thanks!



>
>
> vim +2434 fs/nfs/inode.c
>
> 2426
> 2427 static int nfs_net_init(struct net *net)
> 2428 {
> 2429 struct nfs_net *nn = net_generic(net, nfs_net_id);
> 2430 int err;
> 2431
> 2432 nfs_clients_init(net);
> 2433
> > 2434 err = rpc_proc_register(net, &nn->rpcstats);
> 2435 if (err) {
> 2436 nfs_clients_exit(net);
> 2437 return err;
> 2438 }
> 2439
> 2440 return nfs_fs_proc_net_init(net);
> 2441 }
> 2442
>