2024-04-13 15:57:14

by Chuck Lever III

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

On Sat, Apr 13, 2024 at 03:04:19AM +0530, Harshit Mogalapalli wrote:
> Hi Chuck and Greg,
>
> On 13/04/24 01:53, Chuck Lever wrote:
> > On Sat, Apr 13, 2024 at 01:41:52AM +0530, Harshit Mogalapalli wrote:
> > > # first bad commit: [2267b2e84593bd3d61a1188e68fba06307fa9dab] lockd:
> > > introduce safe async lock op
> > >
> > >
> > > Hope the above might help.
> >
> > Nice work. Thanks!
> >
> >
> > > I didnot test the revert of culprit commit on top of 5.15.154 yet.
> >
> > Please try reverting that one -- it's very close to the top so one
> > or two others might need to be pulled off as well.
> >
>
> I have reverted the bad commit: 2267b2e84593 ("lockd: introduce safe async
> lock op") and the test passes.
>
> Note: Its reverts cleanly on 5.15.154

Harshit also informs me that "lockd: introduce safe async lock op"
is not applied to v6.1, so it's not likely necessary to include here
and can be safely reverted from v5.15.y.


--
Chuck Lever


2024-04-14 06:13:46

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

On Sat, Apr 13, 2024 at 11:56:15AM -0400, Chuck Lever wrote:
> On Sat, Apr 13, 2024 at 03:04:19AM +0530, Harshit Mogalapalli wrote:
> > Hi Chuck and Greg,
> >
> > On 13/04/24 01:53, Chuck Lever wrote:
> > > On Sat, Apr 13, 2024 at 01:41:52AM +0530, Harshit Mogalapalli wrote:
> > > > # first bad commit: [2267b2e84593bd3d61a1188e68fba06307fa9dab] lockd:
> > > > introduce safe async lock op
> > > >
> > > >
> > > > Hope the above might help.
> > >
> > > Nice work. Thanks!
> > >
> > >
> > > > I didnot test the revert of culprit commit on top of 5.15.154 yet.
> > >
> > > Please try reverting that one -- it's very close to the top so one
> > > or two others might need to be pulled off as well.
> > >
> >
> > I have reverted the bad commit: 2267b2e84593 ("lockd: introduce safe async
> > lock op") and the test passes.
> >
> > Note: Its reverts cleanly on 5.15.154
>
> Harshit also informs me that "lockd: introduce safe async lock op"
> is not applied to v6.1, so it's not likely necessary to include here
> and can be safely reverted from v5.15.y.

Chuck, can you send a series of reverts for what needs to be done here
as these were your original backports?

thanks,

greg k-h