2013-09-25 21:03:11

by Anna Schumaker

Subject: [PATCH] NFS: Give "flavor" an initial value to fix a compile warning

From: Anna Schumaker <[email protected]>

cd3c993 introduces a compile warning by not assigning an initial value
to the "flavor" variable. This could only be a problem if the server
returns a supported secflavor list of length zero, but it's better to
fix this before it's ever hit.

Signed-off-by: Anna Schumaker <[email protected]>
---
fs/nfs/nfs4proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index f5fe16b..d53d678 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -7576,7 +7576,7 @@ nfs41_find_root_sec(struct nfs_server *server, struct nfs_fh *fhandle,
{
int err;
struct page *page;
- rpc_authflavor_t flavor;
+ rpc_authflavor_t flavor = RPC_AUTH_MAXFLAVOR;
struct nfs4_secinfo_flavors *flavors;
struct nfs4_secinfo4 *secinfo;
int i;
--
1.8.4

2013-09-25 21:16:50

by Adamson, Dros

Subject: Re: [PATCH] NFS: Give "flavor" an initial value to fix a compile warning

On Sep 25, 2013, at 5:02 PM, [email protected] wrote:

> From: Anna Schumaker <[email protected]>
>
> cd3c993 introduces a compile warning by not assigning an initial value
> to the "flavor" variable. This could only be a problem if the server
> returns a supported secflavor list of length zero, but it's better to
> fix this before it's ever hit.
>
> Signed-off-by: Anna Schumaker <[email protected]>

Acked-by: Weston Andros Adamson <[email protected]>

Thanks!
-dros

> ---
> fs/nfs/nfs4proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index f5fe16b..d53d678 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -7576,7 +7576,7 @@ nfs41_find_root_sec(struct nfs_server *server, struct nfs_fh *fhandle,
> {
> int err;
> struct page *page;
> - rpc_authflavor_t flavor;
> + rpc_authflavor_t flavor = RPC_AUTH_MAXFLAVOR;
> struct nfs4_secinfo_flavors *flavors;
> struct nfs4_secinfo4 *secinfo;
> int i;
> --
> 1.8.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html