On 2024/2/24 21:51, [email protected] wrote:
> From: Chengming Zhou <[email protected]>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
Update changelog to make it clearer:
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete to avoid confusion for users.
Here we can just remove all its users, which has no functional change.
[1] https://lore.kernel.org/all/[email protected]/
Thanks!
>
> Signed-off-by: Chengming Zhou <[email protected]>
> ---
> net/sunrpc/rpc_pipe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c
> index dcc2b4f49e77..910a5d850d04 100644
> --- a/net/sunrpc/rpc_pipe.c
> +++ b/net/sunrpc/rpc_pipe.c
> @@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void)
> rpc_inode_cachep = kmem_cache_create("rpc_inode_cache",
> sizeof(struct rpc_inode),
> 0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
> - SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> + SLAB_ACCOUNT),
> init_once);
> if (!rpc_inode_cachep)
> return -ENOMEM;
On Mon, Feb 26, 2024 at 12:23:49PM +0800, Chengming Zhou wrote:
> On 2024/2/24 21:51, [email protected] wrote:
> > From: Chengming Zhou <[email protected]>
> >
> > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> > its usage so we can delete it from slab. No functional change.
>
> Update changelog to make it clearer:
>
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed as of v6.8-rc1, so it became a dead flag since the commit
> 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
> series[1] went on to mark it obsolete to avoid confusion for users.
> Here we can just remove all its users, which has no functional change.
>
> [1] https://lore.kernel.org/all/[email protected]/
>
> Thanks!
Thanks Chengming Zhou,
As per my comment on a similar patch [*], this seems reasonable to me. But
I think it would be best to post a v2 of this patch with the updated patch
description (which is very helpful, BTW).
[*] https://lore.kernel.org/all/[email protected]/
>
> >
> > Signed-off-by: Chengming Zhou <[email protected]>
> > ---
> > net/sunrpc/rpc_pipe.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c
> > index dcc2b4f49e77..910a5d850d04 100644
> > --- a/net/sunrpc/rpc_pipe.c
> > +++ b/net/sunrpc/rpc_pipe.c
> > @@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void)
> > rpc_inode_cachep = kmem_cache_create("rpc_inode_cache",
> > sizeof(struct rpc_inode),
> > 0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
> > - SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> > + SLAB_ACCOUNT),
> > init_once);
Also, while we are here, perhaps the indentation can be improved.
Something like:
rpc_inode_cachep = kmem_cache_create("rpc_inode_cache",
sizeof(struct rpc_inode),
0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
SLAB_ACCOUNT),
init_once);
> > if (!rpc_inode_cachep)
> > return -ENOMEM;
>
From: Chengming Zhou <[email protected]>
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete to avoid confusion for users.
Here we can just remove all its users, which has no functional change.
[1] https://lore.kernel.org/all/[email protected]/
Signed-off-by: Chengming Zhou <[email protected]>
---
v2:
- Update the patch description and include the related link to
make it clearer that SLAB_MEM_SPREAD flag is now a no-op.
---
net/sunrpc/rpc_pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c
index dcc2b4f49e77..910a5d850d04 100644
--- a/net/sunrpc/rpc_pipe.c
+++ b/net/sunrpc/rpc_pipe.c
@@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void)
rpc_inode_cachep = kmem_cache_create("rpc_inode_cache",
sizeof(struct rpc_inode),
0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
- SLAB_MEM_SPREAD|SLAB_ACCOUNT),
+ SLAB_ACCOUNT),
init_once);
if (!rpc_inode_cachep)
return -ENOMEM;
--
2.40.1
From: Chengming Zhou <[email protected]>
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete to avoid confusion for users.
Here we can just remove all its users, which has no functional change.
[1] https://lore.kernel.org/all/[email protected]/
Signed-off-by: Chengming Zhou <[email protected]>
---
v3:
- Improve the indentation, per Simon Horman.
v2:
- Update the patch description and include the related link to
make it clearer that SLAB_MEM_SPREAD flag is now a no-op.
---
net/sunrpc/rpc_pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c
index dcc2b4f49e77..b639d8eb6080 100644
--- a/net/sunrpc/rpc_pipe.c
+++ b/net/sunrpc/rpc_pipe.c
@@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void)
rpc_inode_cachep = kmem_cache_create("rpc_inode_cache",
sizeof(struct rpc_inode),
0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
- SLAB_MEM_SPREAD|SLAB_ACCOUNT),
+ SLAB_ACCOUNT),
init_once);
if (!rpc_inode_cachep)
return -ENOMEM;
--
2.40.1
On Wed, Feb 28, 2024 at 03:12:34AM +0000, Chengming Zhou wrote:
> From: Chengming Zhou <[email protected]>
>
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed as of v6.8-rc1, so it became a dead flag since the commit
> 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
> series[1] went on to mark it obsolete to avoid confusion for users.
> Here we can just remove all its users, which has no functional change.
>
> [1] https://lore.kernel.org/all/[email protected]/
>
> Signed-off-by: Chengming Zhou <[email protected]>
> ---
> v3:
> - Improve the indentation, per Simon Horman.
>
> v2:
> - Update the patch description and include the related link to
> make it clearer that SLAB_MEM_SPREAD flag is now a no-op.
Thanks for the updates.
Reviewed-by: Simon Horman <[email protected]>
In future please consider the following:
1. Don't post new revisions of a series more than once every 24h
2. Do post new revisions as new email threads
Link: https://docs.kernel.org/process/maintainer-netdev.html