2017-12-15 13:00:51

by Steve Dickson

Subject: [PATCH][V2] rpcbind.service: Not pulling the rpcbind.target

According to systemd.special(7) manpage:

rpcbind.target
The portmapper/rpcbind pulls in this target and orders itself
before it, to indicate its availability. systemd automatically
adds dependencies of type After= for this target unit to
all SysV init script service units with an LSB header
referring to the "$portmap" facility.

Signed-off-by: Steve Dickson <[email protected]>
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1431574
---
systemd/rpcbind.service.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/systemd/rpcbind.service.in b/systemd/rpcbind.service.in
index f8cfa9f..9dbc82c 100644
--- a/systemd/rpcbind.service.in
+++ b/systemd/rpcbind.service.in
@@ -6,8 +6,8 @@ RequiresMountsFor=@statedir@

# Make sure we use the IP addresses listed for
# rpcbind.socket, no matter how this unit is started.
-Wants=rpcbind.socket
-After=rpcbind.socket
+Requires=rpcbind.socket
+Before=rpcbind.target

[Service]
Type=notify
--
2.14.3

2017-12-15 14:52:06

by Lennart Poettering

Subject: Re: [systemd-devel] [PATCH][V2] rpcbind.service: Not pulling the rpcbind.target

On Fr, 15.12.17 08:00, Steve Dickson ([email protected]) wrote:

> According to systemd.special(7) manpage:
>
> rpcbind.target
> The portmapper/rpcbind pulls in this target and orders itself
> before it, to indicate its availability. systemd automatically
> adds dependencies of type After= for this target unit to
> all SysV init script service units with an LSB header
> referring to the "$portmap" facility.
>
> Signed-off-by: Steve Dickson <[email protected]>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1431574
> ---
> systemd/rpcbind.service.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/systemd/rpcbind.service.in b/systemd/rpcbind.service.in
> index f8cfa9f..9dbc82c 100644
> --- a/systemd/rpcbind.service.in
> +++ b/systemd/rpcbind.service.in
> @@ -6,8 +6,8 @@ RequiresMountsFor=@statedir@
>
> # Make sure we use the IP addresses listed for
> # rpcbind.socket, no matter how this unit is started.
> -Wants=rpcbind.socket
> -After=rpcbind.socket
> +Requires=rpcbind.socket
> +Before=rpcbind.target

You should still pull in rpcbind.target as the man page
says. i.e. "Wants=rpcbind.target" really should be there.

Lennart

--
Lennart Poettering, Red Hat

2017-12-15 18:26:26

by Steve Dickson

Subject: Re: [systemd-devel] [PATCH][V2] rpcbind.service: Not pulling the rpcbind.target

On 12/15/2017 09:52 AM, Lennart Poettering wrote:
> On Fr, 15.12.17 08:00, Steve Dickson ([email protected]) wrote:
>
>> According to systemd.special(7) manpage:
>>
>> rpcbind.target
>> The portmapper/rpcbind pulls in this target and orders itself
>> before it, to indicate its availability. systemd automatically
>> adds dependencies of type After= for this target unit to
>> all SysV init script service units with an LSB header
>> referring to the "$portmap" facility.
>>
>> Signed-off-by: Steve Dickson <[email protected]>
>> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1431574
>> ---
>> systemd/rpcbind.service.in | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/systemd/rpcbind.service.in b/systemd/rpcbind.service.in
>> index f8cfa9f..9dbc82c 100644
>> --- a/systemd/rpcbind.service.in
>> +++ b/systemd/rpcbind.service.in
>> @@ -6,8 +6,8 @@ RequiresMountsFor=@statedir@
>>
>> # Make sure we use the IP addresses listed for
>> # rpcbind.socket, no matter how this unit is started.
>> -Wants=rpcbind.socket
>> -After=rpcbind.socket
>> +Requires=rpcbind.socket
>> +Before=rpcbind.target
>
> You should still pull in rpcbind.target as the man page
> says. i.e. "Wants=rpcbind.target" really should be there.
Duly noted... and changed!

thanks!

steved.
>
> Lennart
>