2009-09-30 15:14:53

by James Pearson

[permalink] [raw]
Subject: Re: [PATCH] NFS: Revert default r/wsize behavior

Trond Myklebust wrote:
>
> Hmm.... Strictly speaking, I don't think we need to do this for the
> NFSv4 case, since that has no equivalent to the NFSv3 rtpref/wtpref
> attribute. It might help make the code look more consistent, though.
>
> Note: at some point soon, I want to clean those functions up by
> introducing an 'alloc_nfs_parsed_mount_data()' function that both
> allocates the nfs_parsed_mount_data structure and initialises it with
> the common defaults.

I notice that 2.6.32-rc1 now has the 'alloc_nfs_parsed_mount_data()'
function - but [rw]size still defaults to NFS_MAX_FILE_IO_SIZE -
shouldn't these now be set to 0 by default?

Thanks

James Pearson