2011-08-29 17:21:51

by Anna Schumaker

Subject: [PATCH] VFS: Add "device" tag to /proc/self/mountstats

nfsiostat was failing to find mounted filesystems on kernels after
2.6.38 because of changes to show_vfsstat() by commit
c7f404b40a3665d9f4e9a927cc5c1ee0479ed8f9. This patch adds back the
"device" tag before the nfs server entry so scripts can parse the
mountstats file correctly.

Signed-off-by: Bryan Schumaker <[email protected]>
---
fs/namespace.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index 22bfe82..1429114 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1109,6 +1109,7 @@ static int show_vfsstat(struct seq_file *m, void *v)

/* device */
if (mnt->mnt_sb->s_op->show_devname) {
+ seq_puts(m, "device ");
err = mnt->mnt_sb->s_op->show_devname(m, mnt);
} else {
if (mnt->mnt_devname) {
--
1.7.6

2011-09-21 18:27:25

by Anna Schumaker

Subject: Re: [PATCH] VFS: Add "device" tag to /proc/self/mountstats

What is the status of this patch? I hope it didn't get forgotten with the kernel.org confusion...

- Bryan

On 08/29/2011 01:21 PM, Bryan Schumaker wrote:
>
> nfsiostat was failing to find mounted filesystems on kernels after
> 2.6.38 because of changes to show_vfsstat() by commit
> c7f404b40a3665d9f4e9a927cc5c1ee0479ed8f9. This patch adds back the
> "device" tag before the nfs server entry so scripts can parse the
> mountstats file correctly.
>
> Signed-off-by: Bryan Schumaker <[email protected]>
> ---
> fs/namespace.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index 22bfe82..1429114 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -1109,6 +1109,7 @@ static int show_vfsstat(struct seq_file *m, void *v)
>
> /* device */
> if (mnt->mnt_sb->s_op->show_devname) {
> + seq_puts(m, "device ");
> err = mnt->mnt_sb->s_op->show_devname(m, mnt);
> } else {
> if (mnt->mnt_devname) {