2011-10-19 20:43:34

by Steve Dickson

[permalink] [raw]
Subject: [PATCH 1/1] rpcdebug: Add missing debug flags

This patch added the following debug flags:

fscache - enable FSCache debugging
pnfs - enable general pNFS debugging
pnfs_ld - enable file layout pNFS debugging

Signed-off-by: Steve Dickson <[email protected]>
---
support/include/nfs/debug.h | 3 +++
tools/rpcdebug/rpcdebug.c | 3 +++
2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/support/include/nfs/debug.h b/support/include/nfs/debug.h
index d391e91..dbec5ba 100644
--- a/support/include/nfs/debug.h
+++ b/support/include/nfs/debug.h
@@ -76,6 +76,9 @@ enum {
#define NFSDBG_CALLBACK 0x0100
#define NFSDBG_CLIENT 0x0200
#define NFSDBG_MOUNT 0x0400
+#define NFSDBG_FSCACHE 0x0800
+#define NFSDBG_PNFS 0x1000
+#define NFSDBG_PNFS_LD 0x2000
#define NFSDBG_ALL 0xFFFF

#endif /* _NFS_DEBUG_H */
diff --git a/tools/rpcdebug/rpcdebug.c b/tools/rpcdebug/rpcdebug.c
index 275a491..444616d 100644
--- a/tools/rpcdebug/rpcdebug.c
+++ b/tools/rpcdebug/rpcdebug.c
@@ -167,6 +167,9 @@ static struct flagmap {
FLAG(NFS, CALLBACK),
FLAG(NFS, CLIENT),
FLAG(NFS, MOUNT),
+ FLAG(NFS, FSCACHE),
+ FLAG(NFS, PNFS),
+ FLAG(NFS, PNFS_LD),
FLAG(NFS, ALL),

/* nfsd */
--
1.7.6.2



2011-10-20 18:55:19

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH 1/1] rpcdebug: Add missing debug flags



On 10/19/2011 04:43 PM, Steve Dickson wrote:
> This patch added the following debug flags:
>
> fscache - enable FSCache debugging
> pnfs - enable general pNFS debugging
> pnfs_ld - enable file layout pNFS debugging
>
> Signed-off-by: Steve Dickson <[email protected]>
Committed...

steved.

> ---
> support/include/nfs/debug.h | 3 +++
> tools/rpcdebug/rpcdebug.c | 3 +++
> 2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/support/include/nfs/debug.h b/support/include/nfs/debug.h
> index d391e91..dbec5ba 100644
> --- a/support/include/nfs/debug.h
> +++ b/support/include/nfs/debug.h
> @@ -76,6 +76,9 @@ enum {
> #define NFSDBG_CALLBACK 0x0100
> #define NFSDBG_CLIENT 0x0200
> #define NFSDBG_MOUNT 0x0400
> +#define NFSDBG_FSCACHE 0x0800
> +#define NFSDBG_PNFS 0x1000
> +#define NFSDBG_PNFS_LD 0x2000
> #define NFSDBG_ALL 0xFFFF
>
> #endif /* _NFS_DEBUG_H */
> diff --git a/tools/rpcdebug/rpcdebug.c b/tools/rpcdebug/rpcdebug.c
> index 275a491..444616d 100644
> --- a/tools/rpcdebug/rpcdebug.c
> +++ b/tools/rpcdebug/rpcdebug.c
> @@ -167,6 +167,9 @@ static struct flagmap {
> FLAG(NFS, CALLBACK),
> FLAG(NFS, CLIENT),
> FLAG(NFS, MOUNT),
> + FLAG(NFS, FSCACHE),
> + FLAG(NFS, PNFS),
> + FLAG(NFS, PNFS_LD),
> FLAG(NFS, ALL),
>
> /* nfsd */

2011-10-20 01:33:36

by Boaz Harrosh

[permalink] [raw]
Subject: Re: [PATCH 1/1] rpcdebug: Add missing debug flags

On 10/19/2011 01:43 PM, Steve Dickson wrote:
> This patch added the following debug flags:
>
> fscache - enable FSCache debugging
> pnfs - enable general pNFS debugging
> pnfs_ld - enable file layout pNFS debugging

"Any layout-driver debugging", not only files. We all use the same bit

Boaz

>

> Signed-off-by: Steve Dickson <[email protected]>
> ---
> support/include/nfs/debug.h | 3 +++
> tools/rpcdebug/rpcdebug.c | 3 +++
> 2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/support/include/nfs/debug.h b/support/include/nfs/debug.h
> index d391e91..dbec5ba 100644
> --- a/support/include/nfs/debug.h
> +++ b/support/include/nfs/debug.h
> @@ -76,6 +76,9 @@ enum {
> #define NFSDBG_CALLBACK 0x0100
> #define NFSDBG_CLIENT 0x0200
> #define NFSDBG_MOUNT 0x0400
> +#define NFSDBG_FSCACHE 0x0800
> +#define NFSDBG_PNFS 0x1000
> +#define NFSDBG_PNFS_LD 0x2000
> #define NFSDBG_ALL 0xFFFF
>
> #endif /* _NFS_DEBUG_H */
> diff --git a/tools/rpcdebug/rpcdebug.c b/tools/rpcdebug/rpcdebug.c
> index 275a491..444616d 100644
> --- a/tools/rpcdebug/rpcdebug.c
> +++ b/tools/rpcdebug/rpcdebug.c
> @@ -167,6 +167,9 @@ static struct flagmap {
> FLAG(NFS, CALLBACK),
> FLAG(NFS, CLIENT),
> FLAG(NFS, MOUNT),
> + FLAG(NFS, FSCACHE),
> + FLAG(NFS, PNFS),
> + FLAG(NFS, PNFS_LD),
> FLAG(NFS, ALL),
>
> /* nfsd */


2011-10-20 13:55:12

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH 1/1] rpcdebug: Add missing debug flags



On 10/19/2011 09:33 PM, Boaz Harrosh wrote:
> On 10/19/2011 01:43 PM, Steve Dickson wrote:
>> This patch added the following debug flags:
>>
>> fscache - enable FSCache debugging
>> pnfs - enable general pNFS debugging
>> pnfs_ld - enable file layout pNFS debugging
>
> "Any layout-driver debugging", not only files. We all use the same bit
Noted... thanks!

steved.

>
> Boaz
>
>>
>
>> Signed-off-by: Steve Dickson <[email protected]>
>> ---
>> support/include/nfs/debug.h | 3 +++
>> tools/rpcdebug/rpcdebug.c | 3 +++
>> 2 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/support/include/nfs/debug.h b/support/include/nfs/debug.h
>> index d391e91..dbec5ba 100644
>> --- a/support/include/nfs/debug.h
>> +++ b/support/include/nfs/debug.h
>> @@ -76,6 +76,9 @@ enum {
>> #define NFSDBG_CALLBACK 0x0100
>> #define NFSDBG_CLIENT 0x0200
>> #define NFSDBG_MOUNT 0x0400
>> +#define NFSDBG_FSCACHE 0x0800
>> +#define NFSDBG_PNFS 0x1000
>> +#define NFSDBG_PNFS_LD 0x2000
>> #define NFSDBG_ALL 0xFFFF
>>
>> #endif /* _NFS_DEBUG_H */
>> diff --git a/tools/rpcdebug/rpcdebug.c b/tools/rpcdebug/rpcdebug.c
>> index 275a491..444616d 100644
>> --- a/tools/rpcdebug/rpcdebug.c
>> +++ b/tools/rpcdebug/rpcdebug.c
>> @@ -167,6 +167,9 @@ static struct flagmap {
>> FLAG(NFS, CALLBACK),
>> FLAG(NFS, CLIENT),
>> FLAG(NFS, MOUNT),
>> + FLAG(NFS, FSCACHE),
>> + FLAG(NFS, PNFS),
>> + FLAG(NFS, PNFS_LD),
>> FLAG(NFS, ALL),
>>
>> /* nfsd */
>