2011-10-25 00:01:32

by Boaz Harrosh

Subject: [PATCH] fs/Makefile: Always inspect exofs/

fs/exofs directory has multiple targets now, of which the
ore.ko will be needed by the pnfs-objects-layout-driver
(fs/nfs/objlayout).

As suggested by: Michal Marek <[email protected]> convert
inclusion of exofs/ from obj-$(CONFIG_EXOFS_FS) => obj-$(y).
So ORE can be selected also from fs/nfs/Kconfig

CC: Michal Marek <[email protected]>
CC: Al Viro <[email protected]>
Signed-off-by: Boaz Harrosh <[email protected]>
---
fs/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/Makefile b/fs/Makefile
index afc1096..5c30a13 100644
--- a/fs/Makefile
+++ b/fs/Makefile
@@ -120,6 +120,6 @@ obj-$(CONFIG_DEBUG_FS) += debugfs/
obj-$(CONFIG_OCFS2_FS) += ocfs2/
obj-$(CONFIG_BTRFS_FS) += btrfs/
obj-$(CONFIG_GFS2_FS) += gfs2/
-obj-$(CONFIG_EXOFS_FS) += exofs/
+obj-$(y) += exofs/ # Multiple mods, used by nfs/objlayout
obj-$(CONFIG_CEPH_FS) += ceph/
obj-$(CONFIG_PSTORE) += pstore/
--
1.7.6.4

2011-10-27 10:54:34

by Michal Marek

Subject: Re: [PATCH] fs/Makefile: Always inspect exofs/

On 25.10.2011 01:55, Boaz Harrosh wrote:
>
> fs/exofs directory has multiple targets now, of which the
> ore.ko will be needed by the pnfs-objects-layout-driver
> (fs/nfs/objlayout).
>
> As suggested by: Michal Marek <[email protected]> convert
> inclusion of exofs/ from obj-$(CONFIG_EXOFS_FS) => obj-$(y).

I suggested obj-y verbatim, at least this is what I meant. obj-$(y)
expands to "obj-" and will do nothing.

Michal

2011-10-27 23:32:00

by Boaz Harrosh

Subject: Re: [PATCH] fs/Makefile: Always inspect exofs/

On 10/27/2011 03:54 AM, Michal Marek wrote:
> On 25.10.2011 01:55, Boaz Harrosh wrote:
>>
>> fs/exofs directory has multiple targets now, of which the
>> ore.ko will be needed by the pnfs-objects-layout-driver
>> (fs/nfs/objlayout).
>>
>> As suggested by: Michal Marek <[email protected]> convert
>> inclusion of exofs/ from obj-$(CONFIG_EXOFS_FS) => obj-$(y).
>
> I suggested obj-y verbatim, at least this is what I meant. obj-$(y)
> expands to "obj-" and will do nothing.
>
> Michal

Thanks Michal.

Yes that was a stupid, stupid TYPO bug I did and I'm so embarrassed
I already sent a fix to Linus, he pulled it.

Dear, you have eyes of an hawk, how did you see it? I stared at it for
15 minutes and did not get it.

Boaz