2011-10-28 09:53:06

by Mi Jinlong

[permalink] [raw]
Subject: [PATCH 1/3] 4.1 CLNT: Create session before using at OPEN6

4.1 CLNT: Create session before using at OPEN6

Signed-off-by: Mi Jinlong <[email protected]>
---
nfs4.1/server41tests/st_open.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/nfs4.1/server41tests/st_open.py b/nfs4.1/server41tests/st_open.py
index 2aa3ec4..bd995a5 100644
--- a/nfs4.1/server41tests/st_open.py
+++ b/nfs4.1/server41tests/st_open.py
@@ -192,7 +192,7 @@ def testEXCLUSIVE4AtNameAttribute(t, env):
FLAGS: open all
CODE: OPEN6
"""
- sess1 = env.c1.new_client(env.testname(t))
+ sess1 = env.c1.new_client_session(env.testname(t))

res = create_file(sess1, env.testname(t), mode=EXCLUSIVE4_1)
check(res)
--
1.7.5.1




2011-11-04 21:52:13

by J. Bruce Fields

[permalink] [raw]
Subject: Re: [PATCH 1/3] 4.1 CLNT: Create session before using at OPEN6

On Fri, Oct 28, 2011 at 05:57:48PM +0800, Mi Jinlong wrote:
> 4.1 CLNT: Create session before using at OPEN6

Makes sense--but then how did this test ever work?

--b.

>
> Signed-off-by: Mi Jinlong <[email protected]>
> ---
> nfs4.1/server41tests/st_open.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/nfs4.1/server41tests/st_open.py b/nfs4.1/server41tests/st_open.py
> index 2aa3ec4..bd995a5 100644
> --- a/nfs4.1/server41tests/st_open.py
> +++ b/nfs4.1/server41tests/st_open.py
> @@ -192,7 +192,7 @@ def testEXCLUSIVE4AtNameAttribute(t, env):
> FLAGS: open all
> CODE: OPEN6
> """
> - sess1 = env.c1.new_client(env.testname(t))
> + sess1 = env.c1.new_client_session(env.testname(t))
>
> res = create_file(sess1, env.testname(t), mode=EXCLUSIVE4_1)
> check(res)
> --
> 1.7.5.1
>
>

2011-11-04 22:18:04

by J. Bruce Fields

[permalink] [raw]
Subject: Re: [PATCH 1/3] 4.1 CLNT: Create session before using at OPEN6

On Fri, Nov 04, 2011 at 05:52:11PM -0400, J. Bruce Fields wrote:
> On Fri, Oct 28, 2011 at 05:57:48PM +0800, Mi Jinlong wrote:
> > 4.1 CLNT: Create session before using at OPEN6
>
> Makes sense--but then how did this test ever work?

Oh, I see, it didn't--I just added it to the skip-list for my tests
without investigating.

Thanks, applied!

--b.

>
> --b.
>
> >
> > Signed-off-by: Mi Jinlong <[email protected]>
> > ---
> > nfs4.1/server41tests/st_open.py | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/nfs4.1/server41tests/st_open.py b/nfs4.1/server41tests/st_open.py
> > index 2aa3ec4..bd995a5 100644
> > --- a/nfs4.1/server41tests/st_open.py
> > +++ b/nfs4.1/server41tests/st_open.py
> > @@ -192,7 +192,7 @@ def testEXCLUSIVE4AtNameAttribute(t, env):
> > FLAGS: open all
> > CODE: OPEN6
> > """
> > - sess1 = env.c1.new_client(env.testname(t))
> > + sess1 = env.c1.new_client_session(env.testname(t))
> >
> > res = create_file(sess1, env.testname(t), mode=EXCLUSIVE4_1)
> > check(res)
> > --
> > 1.7.5.1
> >
> >