2012-02-20 00:38:26

by Chris Rankin

[permalink] [raw]
Subject: [OOPS] NFS dereferenced NULL pointer with 3.2.6 kernel.

Hi,

My 3.2.6 (x86, 32 bit) kernel oopsed last night while pulling a file across an
NFS mount:

BUG: unable to handle kernel NULL pointer dereference at (null)
IP: [<c107a333>] page_address+0x7/0xa4
*pde = 00000000
Oops: 0000 [#1] PREEMPT SMP
Modules linked in: nfs fuse cpufreq_ondemand p4_clockmod speedstep_lib bnep
bluetooth rfkill crc16 ip6t_LOG ipt_LOG nf_conntrack_ipv6 xt_tcpudp
nf_defrag_ipv6 nf_conntrack_ipv4 nf_defrag_ipv4 xt_state nf_conntrack max6650
ip6table_filter iptable_filter ip6_tables ip_tables x_tables dm_mirror
dm_region_hash dm_log dm_mod snd_emu10k1_synth snd_emux_synth snd_seq_virmidi
snd_seq_midi_event snd_seq_midi_emul snd_emu10k1 snd_ac97_codec snd_usb_audio
ac97_bus snd_seq snd_pcm snd_timer snd_page_alloc snd_util_mem uvcvideo
snd_hwdep snd_usbmidi_lib snd_rawmidi snd_seq_device joydev snd usbhid psmouse
ppdev videodev parport_pc floppy parport sg firewire_ohci firewire_core pcspkr
dcdbas crc_itu_t soundcore serio_raw processor i2c_i801 binfmt_misc nfsd lockd
nfs_acl auth_rpcgss sunrpc exportfs uinput ipv6 ext3 jbd mbcache sr_mod sd_mod
cdrom sata_sil pata_acpi uhci_hcd ata_piix libata ehci_hcd e1000 scsi_mod
usbcore usb_common button radeon intel_agp intel_gtt ttm drm_kms_helper drm
agpgart backlight i2c_algo_bit cfbcopyarea cfbimgblt cfbfillrect [last unloaded:
scsi_wait_scan]

Pid: 3403, comm: mv Not tainted 3.2.6 #1 Dell Computer Corporation Precision
WorkStation 650 /0F1262
EIP: 0060:[<c107a333>] EFLAGS: 00210206 CPU: 1
EIP is at page_address+0x7/0xa4
EAX: 00000000 EBX: f247fde8 ECX: f43df1e4 EDX: 00000038
ESI: f247fccc EDI: 0000000e EBP: 00000000 ESP: f247fc74
DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
Process mv (pid: 3403, ti=f247e000 task=f55c3b00 task.ti=f247e000)
Stack:
f43df1e4 f247fde8 f247fccc 0000000e f2b79c00 f91d006f 00000000 00001000
f247fc98 00000000 00000002 f43df074 00000000 00000000 0000006e 00000000
f54d8400 f2b79c00 00000000 f91d0008 f84d25ff f43df020 f43df0ac f2b79c04
Call Trace:
[<f91d006f>] ? nfs4_xdr_enc_getacl+0x67/0x86 [nfs]
[<f91d0008>] ? nfs4_xdr_enc_fs_locations+0x87/0x87 [nfs]
[<f84d25ff>] ? rpcauth_wrap_req+0x72/0x7c [sunrpc]
[<f84cc3ef>] ? call_transmit+0x172/0x1dd [sunrpc]
[<f84d182e>] ? __rpc_execute+0x59/0x216 [sunrpc]
[<c1021a61>] ? add_preempt_count+0x88/0x8a
[<c1039936>] ? wake_up_bit+0xb/0x16
[<f84cc71b>] ? rpc_run_task+0x57/0x5c [sunrpc]
[<f84cc7fb>] ? rpc_call_sync+0x3a/0x54 [sunrpc]
[<f91c9164>] ? __nfs4_get_acl_uncached+0x15d/0x1ed [nfs]
[<f91cb43a>] ? nfs4_xattr_get_nfs4_acl+0xdf/0x10c [nfs]
[<c10abaee>] ? generic_getxattr+0x3b/0x43
[<c10abab3>] ? xattr_resolve_name+0x4b/0x4b
[<c10abeb1>] ? vfs_getxattr+0x74/0x7b
[<c10abf2c>] ? getxattr+0x74/0xc5
[<c109fd8c>] ? path_openat+0x2bb/0x2d0
[<c107d0b7>] ? handle_pte_fault+0x23b/0x5fc
[<c109fe4a>] ? do_filp_open+0x23/0x5c
[<c109d1dc>] ? getname_flags+0x20/0xf1
[<c1021948>] ? get_parent_ip+0x8/0x19
[<c1021948>] ? get_parent_ip+0x8/0x19
[<c10219cd>] ? sub_preempt_count+0x74/0x80
[<c1021948>] ? get_parent_ip+0x8/0x19
[<c1021a61>] ? add_preempt_count+0x88/0x8a
[<c1094ede>] ? do_sys_open+0x161/0x16b
[<c1094ede>] ? do_sys_open+0x161/0x16b
[<c10ac041>] ? listxattr+0x80/0x88
[<c10ac5a8>] ? sys_fgetxattr+0x42/0x5a
[<c1219b8c>] ? sysenter_do_call+0x12/0x22
Code: eb 05 bb ea ff ff ff 89 d8 83 c4 20 5b 5e 5f 5d c3 8b 6c 24 18 f7 44 24 44
00 00 01 00 74 86 31 db eb c5 90 55 57 56 53 51 89 c5 <8b> 00 c1 e8 1e c1 e0 0a
05 80 33 2f c1 2b 80 8c 03 00 00 3d 00
EIP: [<c107a333>] page_address+0x7/0xa4 SS:ESP 0068:f247fc74
CR2: 0000000000000000

The remote host was also running 3.2.6, but was x86_64. (I've not had any
trouble copying NFS files between two 32 bit 3.2.6 kernels, which is why I'm
thinking that the remote host being x86_64 might be significant.)

For the record, the file was actually copied successfully. After I'd rebooted, I
confirmed that the SHA1 sums matched. The "mv" operation obviously failed before
the remote copy could be deleted.

Cheers,
Chris




2012-02-20 20:53:23

by Jim Rees

[permalink] [raw]
Subject: Re: [OOPS] NFS dereferenced NULL pointer with 3.2.6 kernel.

Myklebust, Trond wrote:

On Mon, 2012-02-20 at 13:27 -0500, Jim Rees wrote:
> Myklebust, Trond wrote:
>
> It's a known bug. There is a fix at
>
> http://git.linux-nfs.org/?p=trondmy/nfs-2.6.git;a=commit;h=331818f1c468a24e581aedcbe52af799366a9dfe
>
> Shouldn't this be in stable by now? You sent it Feb 3, and there have been
> two stable releases since then.

I've been waiting for Andy to get back from vacation. We've already sent
one buggy patch to stable...

That explains why I have two versions of this patch.

The obvious solution is that Andy should not be allowed to take any
vacations. Should we chain him to his desk?

2012-02-20 18:27:14

by Jim Rees

[permalink] [raw]
Subject: Re: [OOPS] NFS dereferenced NULL pointer with 3.2.6 kernel.

Myklebust, Trond wrote:

It's a known bug. There is a fix at

http://git.linux-nfs.org/?p=trondmy/nfs-2.6.git;a=commit;h=331818f1c468a24e581aedcbe52af799366a9dfe

Shouldn't this be in stable by now? You sent it Feb 3, and there have been
two stable releases since then.

2012-02-20 19:33:16

by Andy Adamson

[permalink] [raw]
Subject: Re: [OOPS] NFS dereferenced NULL pointer with 3.2.6 kernel.

I'll test ACLs with the patch this week at Connectathon.

-->Andy

On Mon, Feb 20, 2012 at 2:16 PM, Ben Greear <[email protected]> wrote:
> On 02/20/2012 11:09 AM, Myklebust, Trond wrote:
>>
>> On Mon, 2012-02-20 at 10:43 -0800, Ben Greear wrote:
>>>
>>> On 02/20/2012 10:35 AM, Myklebust, Trond wrote:
>>>>
>>>> On Mon, 2012-02-20 at 13:27 -0500, Jim Rees wrote:
>>>>>
>>>>> Myklebust, Trond wrote:
>>>>>
>>>>> ? ?It's a known bug. There is a fix at
>>>>>
>>>>>
>>>>> ?http://git.linux-nfs.org/?p=trondmy/nfs-2.6.git;a=commit;h=331818f1c468a24e581aedcbe52af799366a9dfe
>>>>>
>>>>> Shouldn't this be in stable by now? ?You sent it Feb 3, and there have
>>>>> been
>>>>> two stable releases since then.
>>>>
>>>>
>>>> I've been waiting for Andy to get back from vacation. We've already sent
>>>> one buggy patch to stable...
>>>>
>>>
>>> It's still not in 3.3-rc either, at least put it there so others
>>> can test it?
>>
>>
>> 3.3-rc is _NOT_ a place to put patches for testing... You test the
>> patches _BEFORE_ you send them upstream.
>
>
> Ok, but seems like it would be pretty lame to release 3.3 with this known
> crash bug.
>
> And, though I haven't done any thorough NFS testing, I could hit the
> bug every time before I applied the patch..and since I applied it,
> I have not had any problems.
>
> So, it has been tested at least a bit.
>
>
> Thanks,
> Ben
>
> --
> Ben Greear <[email protected]>
> Candela Technologies Inc ?http://www.candelatech.com
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html

2012-02-20 02:01:53

by Jim Rees

[permalink] [raw]
Subject: Re: [OOPS] NFS dereferenced NULL pointer with 3.2.6 kernel.

Chris Rankin wrote:

My 3.2.6 (x86, 32 bit) kernel oopsed last night while pulling a file
across an NFS mount:

I think this is fixed by commit 331818f1c4, "Fix an Oops in the NFSv4 getacl
code." Shouldn't this be in stable by now? It doesn't seem to be.

2012-02-20 18:44:18

by Ben Greear

[permalink] [raw]
Subject: Re: [OOPS] NFS dereferenced NULL pointer with 3.2.6 kernel.

On 02/20/2012 10:35 AM, Myklebust, Trond wrote:
> On Mon, 2012-02-20 at 13:27 -0500, Jim Rees wrote:
>> Myklebust, Trond wrote:
>>
>> It's a known bug. There is a fix at
>>
>> http://git.linux-nfs.org/?p=trondmy/nfs-2.6.git;a=commit;h=331818f1c468a24e581aedcbe52af799366a9dfe
>>
>> Shouldn't this be in stable by now? You sent it Feb 3, and there have been
>> two stable releases since then.
>
> I've been waiting for Andy to get back from vacation. We've already sent
> one buggy patch to stable...
>

It's still not in 3.3-rc either, at least put it there so others
can test it?

I've been testing with the patch applied to 3.3 and it fixes
the crashes for me....

Thanks,
Ben

--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com


2012-02-20 18:01:13

by Myklebust, Trond

[permalink] [raw]
Subject: Re: [OOPS] NFS dereferenced NULL pointer with 3.2.6 kernel.

T24gTW9uLCAyMDEyLTAyLTIwIGF0IDAwOjMzICswMDAwLCBDaHJpcyBSYW5raW4gd3JvdGU6DQo+
IEhpLA0KPiANCj4gTXkgMy4yLjYgKHg4NiwgMzIgYml0KSBrZXJuZWwgb29wc2VkIGxhc3Qgbmln
aHQgd2hpbGUgcHVsbGluZyBhIGZpbGUgYWNyb3NzIGFuIA0KPiBORlMgbW91bnQ6DQo+IA0KPiBC
VUc6IHVuYWJsZSB0byBoYW5kbGUga2VybmVsIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSBhdCAg
IChudWxsKQ0KPiBJUDogWzxjMTA3YTMzMz5dIHBhZ2VfYWRkcmVzcysweDcvMHhhNA0KPiAqcGRl
ID0gMDAwMDAwMDANCj4gT29wczogMDAwMCBbIzFdIFBSRUVNUFQgU01QDQo+IE1vZHVsZXMgbGlu
a2VkIGluOiBuZnMgZnVzZSBjcHVmcmVxX29uZGVtYW5kIHA0X2Nsb2NrbW9kIHNwZWVkc3RlcF9s
aWIgYm5lcCANCj4gYmx1ZXRvb3RoIHJma2lsbCBjcmMxNiBpcDZ0X0xPRyBpcHRfTE9HIG5mX2Nv
bm50cmFja19pcHY2IHh0X3RjcHVkcCANCj4gbmZfZGVmcmFnX2lwdjYgbmZfY29ubnRyYWNrX2lw
djQgbmZfZGVmcmFnX2lwdjQgeHRfc3RhdGUgbmZfY29ubnRyYWNrIG1heDY2NTAgDQo+IGlwNnRh
YmxlX2ZpbHRlciBpcHRhYmxlX2ZpbHRlciBpcDZfdGFibGVzIGlwX3RhYmxlcyB4X3RhYmxlcyBk
bV9taXJyb3IgDQo+IGRtX3JlZ2lvbl9oYXNoIGRtX2xvZyBkbV9tb2Qgc25kX2VtdTEwazFfc3lu
dGggc25kX2VtdXhfc3ludGggc25kX3NlcV92aXJtaWRpIA0KPiBzbmRfc2VxX21pZGlfZXZlbnQg
c25kX3NlcV9taWRpX2VtdWwgc25kX2VtdTEwazEgc25kX2FjOTdfY29kZWMgc25kX3VzYl9hdWRp
byANCj4gYWM5N19idXMgc25kX3NlcSBzbmRfcGNtIHNuZF90aW1lciBzbmRfcGFnZV9hbGxvYyBz
bmRfdXRpbF9tZW0gdXZjdmlkZW8gDQo+IHNuZF9od2RlcCBzbmRfdXNibWlkaV9saWIgc25kX3Jh
d21pZGkgc25kX3NlcV9kZXZpY2Ugam95ZGV2IHNuZCB1c2JoaWQgcHNtb3VzZSANCj4gcHBkZXYg
dmlkZW9kZXYgcGFycG9ydF9wYyBmbG9wcHkgcGFycG9ydCBzZyBmaXJld2lyZV9vaGNpIGZpcmV3
aXJlX2NvcmUgcGNzcGtyIA0KPiBkY2RiYXMgY3JjX2l0dV90IHNvdW5kY29yZSBzZXJpb19yYXcg
cHJvY2Vzc29yIGkyY19pODAxIGJpbmZtdF9taXNjIG5mc2QgbG9ja2QgDQo+IG5mc19hY2wgYXV0
aF9ycGNnc3Mgc3VucnBjIGV4cG9ydGZzIHVpbnB1dCBpcHY2IGV4dDMgamJkIG1iY2FjaGUgc3Jf
bW9kIHNkX21vZCANCj4gY2Ryb20gc2F0YV9zaWwgcGF0YV9hY3BpIHVoY2lfaGNkIGF0YV9waWl4
IGxpYmF0YSBlaGNpX2hjZCBlMTAwMCBzY3NpX21vZCANCj4gdXNiY29yZSB1c2JfY29tbW9uIGJ1
dHRvbiByYWRlb24gaW50ZWxfYWdwIGludGVsX2d0dCB0dG0gZHJtX2ttc19oZWxwZXIgZHJtIA0K
PiBhZ3BnYXJ0IGJhY2tsaWdodCBpMmNfYWxnb19iaXQgY2ZiY29weWFyZWEgY2ZiaW1nYmx0IGNm
YmZpbGxyZWN0IFtsYXN0IHVubG9hZGVkOiANCj4gc2NzaV93YWl0X3NjYW5dDQo+IA0KPiBQaWQ6
IDM0MDMsIGNvbW06IG12IE5vdCB0YWludGVkIDMuMi42ICMxIERlbGwgQ29tcHV0ZXIgQ29ycG9y
YXRpb24gUHJlY2lzaW9uIA0KPiBXb3JrU3RhdGlvbiA2NTAgICAgLzBGMTI2Mg0KPiBFSVA6IDAw
NjA6WzxjMTA3YTMzMz5dIEVGTEFHUzogMDAyMTAyMDYgQ1BVOiAxDQo+IEVJUCBpcyBhdCBwYWdl
X2FkZHJlc3MrMHg3LzB4YTQNCj4gRUFYOiAwMDAwMDAwMCBFQlg6IGYyNDdmZGU4IEVDWDogZjQz
ZGYxZTQgRURYOiAwMDAwMDAzOA0KPiBFU0k6IGYyNDdmY2NjIEVESTogMDAwMDAwMGUgRUJQOiAw
MDAwMDAwMCBFU1A6IGYyNDdmYzc0DQo+ICAgRFM6IDAwN2IgRVM6IDAwN2IgRlM6IDAwZDggR1M6
IDAwMzMgU1M6IDAwNjgNCj4gUHJvY2VzcyBtdiAocGlkOiAzNDAzLCB0aT1mMjQ3ZTAwMCB0YXNr
PWY1NWMzYjAwIHRhc2sudGk9ZjI0N2UwMDApDQo+IFN0YWNrOg0KPiAgIGY0M2RmMWU0IGYyNDdm
ZGU4IGYyNDdmY2NjIDAwMDAwMDBlIGYyYjc5YzAwIGY5MWQwMDZmIDAwMDAwMDAwIDAwMDAxMDAw
DQo+ICAgZjI0N2ZjOTggMDAwMDAwMDAgMDAwMDAwMDIgZjQzZGYwNzQgMDAwMDAwMDAgMDAwMDAw
MDAgMDAwMDAwNmUgMDAwMDAwMDANCj4gICBmNTRkODQwMCBmMmI3OWMwMCAwMDAwMDAwMCBmOTFk
MDAwOCBmODRkMjVmZiBmNDNkZjAyMCBmNDNkZjBhYyBmMmI3OWMwNA0KPiBDYWxsIFRyYWNlOg0K
PiAgIFs8ZjkxZDAwNmY+XSA/IG5mczRfeGRyX2VuY19nZXRhY2wrMHg2Ny8weDg2IFtuZnNdDQo+
ICAgWzxmOTFkMDAwOD5dID8gbmZzNF94ZHJfZW5jX2ZzX2xvY2F0aW9ucysweDg3LzB4ODcgW25m
c10NCj4gICBbPGY4NGQyNWZmPl0gPyBycGNhdXRoX3dyYXBfcmVxKzB4NzIvMHg3YyBbc3VucnBj
XQ0KPiAgIFs8Zjg0Y2MzZWY+XSA/IGNhbGxfdHJhbnNtaXQrMHgxNzIvMHgxZGQgW3N1bnJwY10N
Cj4gICBbPGY4NGQxODJlPl0gPyBfX3JwY19leGVjdXRlKzB4NTkvMHgyMTYgW3N1bnJwY10NCj4g
ICBbPGMxMDIxYTYxPl0gPyBhZGRfcHJlZW1wdF9jb3VudCsweDg4LzB4OGENCj4gICBbPGMxMDM5
OTM2Pl0gPyB3YWtlX3VwX2JpdCsweGIvMHgxNg0KPiAgIFs8Zjg0Y2M3MWI+XSA/IHJwY19ydW5f
dGFzaysweDU3LzB4NWMgW3N1bnJwY10NCj4gICBbPGY4NGNjN2ZiPl0gPyBycGNfY2FsbF9zeW5j
KzB4M2EvMHg1NCBbc3VucnBjXQ0KPiAgIFs8ZjkxYzkxNjQ+XSA/IF9fbmZzNF9nZXRfYWNsX3Vu
Y2FjaGVkKzB4MTVkLzB4MWVkIFtuZnNdDQo+ICAgWzxmOTFjYjQzYT5dID8gbmZzNF94YXR0cl9n
ZXRfbmZzNF9hY2wrMHhkZi8weDEwYyBbbmZzXQ0KPiAgIFs8YzEwYWJhZWU+XSA/IGdlbmVyaWNf
Z2V0eGF0dHIrMHgzYi8weDQzDQo+ICAgWzxjMTBhYmFiMz5dID8geGF0dHJfcmVzb2x2ZV9uYW1l
KzB4NGIvMHg0Yg0KPiAgIFs8YzEwYWJlYjE+XSA/IHZmc19nZXR4YXR0cisweDc0LzB4N2INCj4g
ICBbPGMxMGFiZjJjPl0gPyBnZXR4YXR0cisweDc0LzB4YzUNCj4gICBbPGMxMDlmZDhjPl0gPyBw
YXRoX29wZW5hdCsweDJiYi8weDJkMA0KPiAgIFs8YzEwN2QwYjc+XSA/IGhhbmRsZV9wdGVfZmF1
bHQrMHgyM2IvMHg1ZmMNCj4gICBbPGMxMDlmZTRhPl0gPyBkb19maWxwX29wZW4rMHgyMy8weDVj
DQo+ICAgWzxjMTA5ZDFkYz5dID8gZ2V0bmFtZV9mbGFncysweDIwLzB4ZjENCj4gICBbPGMxMDIx
OTQ4Pl0gPyBnZXRfcGFyZW50X2lwKzB4OC8weDE5DQo+ICAgWzxjMTAyMTk0OD5dID8gZ2V0X3Bh
cmVudF9pcCsweDgvMHgxOQ0KPiAgIFs8YzEwMjE5Y2Q+XSA/IHN1Yl9wcmVlbXB0X2NvdW50KzB4
NzQvMHg4MA0KPiAgIFs8YzEwMjE5NDg+XSA/IGdldF9wYXJlbnRfaXArMHg4LzB4MTkNCj4gICBb
PGMxMDIxYTYxPl0gPyBhZGRfcHJlZW1wdF9jb3VudCsweDg4LzB4OGENCj4gICBbPGMxMDk0ZWRl
Pl0gPyBkb19zeXNfb3BlbisweDE2MS8weDE2Yg0KPiAgIFs8YzEwOTRlZGU+XSA/IGRvX3N5c19v
cGVuKzB4MTYxLzB4MTZiDQo+ICAgWzxjMTBhYzA0MT5dID8gbGlzdHhhdHRyKzB4ODAvMHg4OA0K
PiAgIFs8YzEwYWM1YTg+XSA/IHN5c19mZ2V0eGF0dHIrMHg0Mi8weDVhDQo+ICAgWzxjMTIxOWI4
Yz5dID8gc3lzZW50ZXJfZG9fY2FsbCsweDEyLzB4MjINCj4gQ29kZTogZWIgMDUgYmIgZWEgZmYg
ZmYgZmYgODkgZDggODMgYzQgMjAgNWIgNWUgNWYgNWQgYzMgOGIgNmMgMjQgMTggZjcgNDQgMjQg
NDQgDQo+IDAwIDAwIDAxIDAwIDc0IDg2IDMxIGRiIGViIGM1IDkwIDU1IDU3IDU2IDUzIDUxIDg5
IGM1IDw4Yj4gMDAgYzEgZTggMWUgYzEgZTAgMGEgDQo+IDA1IDgwIDMzIDJmIGMxIDJiIDgwIDhj
IDAzIDAwIDAwIDNkIDAwDQo+IEVJUDogWzxjMTA3YTMzMz5dIHBhZ2VfYWRkcmVzcysweDcvMHhh
NCBTUzpFU1AgMDA2ODpmMjQ3ZmM3NA0KPiBDUjI6IDAwMDAwMDAwMDAwMDAwMDANCj4gDQo+IFRo
ZSByZW1vdGUgaG9zdCB3YXMgYWxzbyBydW5uaW5nIDMuMi42LCBidXQgd2FzIHg4Nl82NC4gKEkn
dmUgbm90IGhhZCBhbnkgDQo+IHRyb3VibGUgY29weWluZyBORlMgZmlsZXMgYmV0d2VlbiB0d28g
MzIgYml0IDMuMi42IGtlcm5lbHMsIHdoaWNoIGlzIHdoeSBJJ20gDQo+IHRoaW5raW5nIHRoYXQg
dGhlIHJlbW90ZSBob3N0IGJlaW5nIHg4Nl82NCBtaWdodCBiZSBzaWduaWZpY2FudC4pDQo+IA0K
PiBGb3IgdGhlIHJlY29yZCwgdGhlIGZpbGUgd2FzIGFjdHVhbGx5IGNvcGllZCBzdWNjZXNzZnVs
bHkuIEFmdGVyIEknZCByZWJvb3RlZCwgSSANCj4gY29uZmlybWVkIHRoYXQgdGhlIFNIQTEgc3Vt
cyBtYXRjaGVkLiBUaGUgIm12IiBvcGVyYXRpb24gb2J2aW91c2x5IGZhaWxlZCBiZWZvcmUgDQo+
IHRoZSByZW1vdGUgY29weSBjb3VsZCBiZSBkZWxldGVkLg0KDQpJdCdzIGEga25vd24gYnVnLiBU
aGVyZSBpcyBhIGZpeCBhdA0KDQpodHRwOi8vZ2l0LmxpbnV4LW5mcy5vcmcvP3A9dHJvbmRteS9u
ZnMtMi42LmdpdDthPWNvbW1pdDtoPTMzMTgxOGYxYzQ2OGEyNGU1ODFhZWRjYmU1MmFmNzk5MzY2
YTlkZmUNCg0KQ2hlZXJzDQogIFRyb25kDQotLSANClRyb25kIE15a2xlYnVzdA0KTGludXggTkZT
IGNsaWVudCBtYWludGFpbmVyDQoNCk5ldEFwcA0KVHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20N
Cnd3dy5uZXRhcHAuY29tDQoNCg==

2012-02-20 18:36:13

by Myklebust, Trond

[permalink] [raw]
Subject: Re: [OOPS] NFS dereferenced NULL pointer with 3.2.6 kernel.

T24gTW9uLCAyMDEyLTAyLTIwIGF0IDEzOjI3IC0wNTAwLCBKaW0gUmVlcyB3cm90ZToNCj4gTXlr
bGVidXN0LCBUcm9uZCB3cm90ZToNCj4gDQo+ICAgSXQncyBhIGtub3duIGJ1Zy4gVGhlcmUgaXMg
YSBmaXggYXQNCj4gICANCj4gICBodHRwOi8vZ2l0LmxpbnV4LW5mcy5vcmcvP3A9dHJvbmRteS9u
ZnMtMi42LmdpdDthPWNvbW1pdDtoPTMzMTgxOGYxYzQ2OGEyNGU1ODFhZWRjYmU1MmFmNzk5MzY2
YTlkZmUNCj4gDQo+IFNob3VsZG4ndCB0aGlzIGJlIGluIHN0YWJsZSBieSBub3c/ICBZb3Ugc2Vu
dCBpdCBGZWIgMywgYW5kIHRoZXJlIGhhdmUgYmVlbg0KPiB0d28gc3RhYmxlIHJlbGVhc2VzIHNp
bmNlIHRoZW4uDQoNCkkndmUgYmVlbiB3YWl0aW5nIGZvciBBbmR5IHRvIGdldCBiYWNrIGZyb20g
dmFjYXRpb24uIFdlJ3ZlIGFscmVhZHkgc2VudA0Kb25lIGJ1Z2d5IHBhdGNoIHRvIHN0YWJsZS4u
Lg0KDQotLSANClRyb25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBtYWludGFpbmVyDQoN
Ck5ldEFwcA0KVHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20NCnd3dy5uZXRhcHAuY29tDQoNCg==

2012-02-20 19:16:08

by Ben Greear

[permalink] [raw]
Subject: Re: [OOPS] NFS dereferenced NULL pointer with 3.2.6 kernel.

On 02/20/2012 11:09 AM, Myklebust, Trond wrote:
> On Mon, 2012-02-20 at 10:43 -0800, Ben Greear wrote:
>> On 02/20/2012 10:35 AM, Myklebust, Trond wrote:
>>> On Mon, 2012-02-20 at 13:27 -0500, Jim Rees wrote:
>>>> Myklebust, Trond wrote:
>>>>
>>>> It's a known bug. There is a fix at
>>>>
>>>> http://git.linux-nfs.org/?p=trondmy/nfs-2.6.git;a=commit;h=331818f1c468a24e581aedcbe52af799366a9dfe
>>>>
>>>> Shouldn't this be in stable by now? You sent it Feb 3, and there have been
>>>> two stable releases since then.
>>>
>>> I've been waiting for Andy to get back from vacation. We've already sent
>>> one buggy patch to stable...
>>>
>>
>> It's still not in 3.3-rc either, at least put it there so others
>> can test it?
>
> 3.3-rc is _NOT_ a place to put patches for testing... You test the
> patches _BEFORE_ you send them upstream.

Ok, but seems like it would be pretty lame to release 3.3 with this known
crash bug.

And, though I haven't done any thorough NFS testing, I could hit the
bug every time before I applied the patch..and since I applied it,
I have not had any problems.

So, it has been tested at least a bit.

Thanks,
Ben

--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com


2012-02-20 19:09:13

by Myklebust, Trond

[permalink] [raw]
Subject: Re: [OOPS] NFS dereferenced NULL pointer with 3.2.6 kernel.

T24gTW9uLCAyMDEyLTAyLTIwIGF0IDEwOjQzIC0wODAwLCBCZW4gR3JlZWFyIHdyb3RlOg0KPiBP
biAwMi8yMC8yMDEyIDEwOjM1IEFNLCBNeWtsZWJ1c3QsIFRyb25kIHdyb3RlOg0KPiA+IE9uIE1v
biwgMjAxMi0wMi0yMCBhdCAxMzoyNyAtMDUwMCwgSmltIFJlZXMgd3JvdGU6DQo+ID4+IE15a2xl
YnVzdCwgVHJvbmQgd3JvdGU6DQo+ID4+DQo+ID4+ICAgIEl0J3MgYSBrbm93biBidWcuIFRoZXJl
IGlzIGEgZml4IGF0DQo+ID4+DQo+ID4+ICAgIGh0dHA6Ly9naXQubGludXgtbmZzLm9yZy8/cD10
cm9uZG15L25mcy0yLjYuZ2l0O2E9Y29tbWl0O2g9MzMxODE4ZjFjNDY4YTI0ZTU4MWFlZGNiZTUy
YWY3OTkzNjZhOWRmZQ0KPiA+Pg0KPiA+PiBTaG91bGRuJ3QgdGhpcyBiZSBpbiBzdGFibGUgYnkg
bm93PyAgWW91IHNlbnQgaXQgRmViIDMsIGFuZCB0aGVyZSBoYXZlIGJlZW4NCj4gPj4gdHdvIHN0
YWJsZSByZWxlYXNlcyBzaW5jZSB0aGVuLg0KPiA+DQo+ID4gSSd2ZSBiZWVuIHdhaXRpbmcgZm9y
IEFuZHkgdG8gZ2V0IGJhY2sgZnJvbSB2YWNhdGlvbi4gV2UndmUgYWxyZWFkeSBzZW50DQo+ID4g
b25lIGJ1Z2d5IHBhdGNoIHRvIHN0YWJsZS4uLg0KPiA+DQo+IA0KPiBJdCdzIHN0aWxsIG5vdCBp
biAzLjMtcmMgZWl0aGVyLCBhdCBsZWFzdCBwdXQgaXQgdGhlcmUgc28gb3RoZXJzDQo+IGNhbiB0
ZXN0IGl0Pw0KDQozLjMtcmMgaXMgX05PVF8gYSBwbGFjZSB0byBwdXQgcGF0Y2hlcyBmb3IgdGVz
dGluZy4uLiBZb3UgdGVzdCB0aGUNCnBhdGNoZXMgX0JFRk9SRV8geW91IHNlbmQgdGhlbSB1cHN0
cmVhbS4NCg0KSW4gdGhpcyBjYXNlLCB0aGUgZGVsYXkgaGFzIGJlZW4gdGhyZWVmb2xkLg0KDQox
KSBBbmR5IHdhcyBvbiB2YWNhdGlvbg0KMikgVGhlcmUgYXJlIG90aGVyIGZpeGVzIHRoYXQgbmVl
ZCB0byBiZSBwdXNoZWQgYW5kIHRoYXQgdGVzdGVkIHRvbw0KMykgSSdtIGluIE5vcndheSB0cnlp
bmcgdG8gYXR0ZW5kIGEgZnVuZXJhbC4uLg0KDQoNCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxp
bnV4IE5GUyBjbGllbnQgbWFpbnRhaW5lcg0KDQpOZXRBcHANClRyb25kLk15a2xlYnVzdEBuZXRh
cHAuY29tDQp3d3cubmV0YXBwLmNvbQ0KDQo=